1 .. _submittingpatches: 1 .. _submittingpatches:
2 2
3 Submitting patches: the essential guide to get 3 Submitting patches: the essential guide to getting your code into the kernel
4 ============================================== 4 ============================================================================
5 5
6 For a person or company who wishes to submit a 6 For a person or company who wishes to submit a change to the Linux
7 kernel, the process can sometimes be daunting 7 kernel, the process can sometimes be daunting if you're not familiar
8 with "the system." This text is a collection 8 with "the system." This text is a collection of suggestions which
9 can greatly increase the chances of your chang 9 can greatly increase the chances of your change being accepted.
10 10
11 This document contains a large number of sugge 11 This document contains a large number of suggestions in a relatively terse
12 format. For detailed information on how the k 12 format. For detailed information on how the kernel development process
13 works, see Documentation/process/development-p 13 works, see Documentation/process/development-process.rst. Also, read
14 Documentation/process/submit-checklist.rst 14 Documentation/process/submit-checklist.rst
15 for a list of items to check before submitting !! 15 for a list of items to check before submitting code. If you are submitting
16 For device tree binding patches, read !! 16 a driver, also read Documentation/process/submitting-drivers.rst; for device
>> 17 tree binding patches, read
17 Documentation/devicetree/bindings/submitting-p 18 Documentation/devicetree/bindings/submitting-patches.rst.
18 19
19 This documentation assumes that you're using ` 20 This documentation assumes that you're using ``git`` to prepare your patches.
20 If you're unfamiliar with ``git``, you would b 21 If you're unfamiliar with ``git``, you would be well-advised to learn how to
21 use it, it will make your life as a kernel dev 22 use it, it will make your life as a kernel developer and in general much
22 easier. 23 easier.
23 24
24 Some subsystems and maintainer trees have addi 25 Some subsystems and maintainer trees have additional information about
25 their workflow and expectations, see 26 their workflow and expectations, see
26 :ref:`Documentation/process/maintainer-handboo 27 :ref:`Documentation/process/maintainer-handbooks.rst <maintainer_handbooks_main>`.
27 28
28 Obtain a current source tree 29 Obtain a current source tree
29 ---------------------------- 30 ----------------------------
30 31
31 If you do not have a repository with the curre 32 If you do not have a repository with the current kernel source handy, use
32 ``git`` to obtain one. You'll want to start w 33 ``git`` to obtain one. You'll want to start with the mainline repository,
33 which can be grabbed with:: 34 which can be grabbed with::
34 35
35 git clone git://git.kernel.org/pub/scm/linux 36 git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
36 37
37 Note, however, that you may not want to develo 38 Note, however, that you may not want to develop against the mainline tree
38 directly. Most subsystem maintainers run thei 39 directly. Most subsystem maintainers run their own trees and want to see
39 patches prepared against those trees. See the 40 patches prepared against those trees. See the **T:** entry for the subsystem
40 in the MAINTAINERS file to find that tree, or 41 in the MAINTAINERS file to find that tree, or simply ask the maintainer if
41 the tree is not listed there. 42 the tree is not listed there.
42 43
43 .. _describe_changes: 44 .. _describe_changes:
44 45
45 Describe your changes 46 Describe your changes
46 --------------------- 47 ---------------------
47 48
48 Describe your problem. Whether your patch is 49 Describe your problem. Whether your patch is a one-line bug fix or
49 5000 lines of a new feature, there must be an 50 5000 lines of a new feature, there must be an underlying problem that
50 motivated you to do this work. Convince the r 51 motivated you to do this work. Convince the reviewer that there is a
51 problem worth fixing and that it makes sense f 52 problem worth fixing and that it makes sense for them to read past the
52 first paragraph. 53 first paragraph.
53 54
54 Describe user-visible impact. Straight up cra 55 Describe user-visible impact. Straight up crashes and lockups are
55 pretty convincing, but not all bugs are that b 56 pretty convincing, but not all bugs are that blatant. Even if the
56 problem was spotted during code review, descri 57 problem was spotted during code review, describe the impact you think
57 it can have on users. Keep in mind that the m 58 it can have on users. Keep in mind that the majority of Linux
58 installations run kernels from secondary stabl 59 installations run kernels from secondary stable trees or
59 vendor/product-specific trees that cherry-pick 60 vendor/product-specific trees that cherry-pick only specific patches
60 from upstream, so include anything that could 61 from upstream, so include anything that could help route your change
61 downstream: provoking circumstances, excerpts 62 downstream: provoking circumstances, excerpts from dmesg, crash
62 descriptions, performance regressions, latency 63 descriptions, performance regressions, latency spikes, lockups, etc.
63 64
64 Quantify optimizations and trade-offs. If you 65 Quantify optimizations and trade-offs. If you claim improvements in
65 performance, memory consumption, stack footpri 66 performance, memory consumption, stack footprint, or binary size,
66 include numbers that back them up. But also d 67 include numbers that back them up. But also describe non-obvious
67 costs. Optimizations usually aren't free but 68 costs. Optimizations usually aren't free but trade-offs between CPU,
68 memory, and readability; or, when it comes to 69 memory, and readability; or, when it comes to heuristics, between
69 different workloads. Describe the expected do 70 different workloads. Describe the expected downsides of your
70 optimization so that the reviewer can weigh co 71 optimization so that the reviewer can weigh costs against benefits.
71 72
72 Once the problem is established, describe what 73 Once the problem is established, describe what you are actually doing
73 about it in technical detail. It's important 74 about it in technical detail. It's important to describe the change
74 in plain English for the reviewer to verify th 75 in plain English for the reviewer to verify that the code is behaving
75 as you intend it to. 76 as you intend it to.
76 77
77 The maintainer will thank you if you write you 78 The maintainer will thank you if you write your patch description in a
78 form which can be easily pulled into Linux's s 79 form which can be easily pulled into Linux's source code management
79 system, ``git``, as a "commit log". See :ref: 80 system, ``git``, as a "commit log". See :ref:`the_canonical_patch_format`.
80 81
81 Solve only one problem per patch. If your des 82 Solve only one problem per patch. If your description starts to get
82 long, that's a sign that you probably need to 83 long, that's a sign that you probably need to split up your patch.
83 See :ref:`split_changes`. 84 See :ref:`split_changes`.
84 85
85 When you submit or resubmit a patch or patch s 86 When you submit or resubmit a patch or patch series, include the
86 complete patch description and justification f 87 complete patch description and justification for it. Don't just
87 say that this is version N of the patch (serie 88 say that this is version N of the patch (series). Don't expect the
88 subsystem maintainer to refer back to earlier 89 subsystem maintainer to refer back to earlier patch versions or referenced
89 URLs to find the patch description and put tha 90 URLs to find the patch description and put that into the patch.
90 I.e., the patch (series) and its description s 91 I.e., the patch (series) and its description should be self-contained.
91 This benefits both the maintainers and reviewe 92 This benefits both the maintainers and reviewers. Some reviewers
92 probably didn't even receive earlier versions 93 probably didn't even receive earlier versions of the patch.
93 94
94 Describe your changes in imperative mood, e.g. 95 Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
95 instead of "[This patch] makes xyzzy do frotz" 96 instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
96 to do frotz", as if you are giving orders to t 97 to do frotz", as if you are giving orders to the codebase to change
97 its behaviour. 98 its behaviour.
98 99
99 If you want to refer to a specific commit, don 100 If you want to refer to a specific commit, don't just refer to the
100 SHA-1 ID of the commit. Please also include th 101 SHA-1 ID of the commit. Please also include the oneline summary of
101 the commit, to make it easier for reviewers to 102 the commit, to make it easier for reviewers to know what it is about.
102 Example:: 103 Example::
103 104
104 Commit e21d2170f36602ae2708 ("video: r 105 Commit e21d2170f36602ae2708 ("video: remove unnecessary
105 platform_set_drvdata()") removed the u 106 platform_set_drvdata()") removed the unnecessary
106 platform_set_drvdata(), but left the v 107 platform_set_drvdata(), but left the variable "dev" unused,
107 delete it. 108 delete it.
108 109
109 You should also be sure to use at least the fi 110 You should also be sure to use at least the first twelve characters of the
110 SHA-1 ID. The kernel repository holds a *lot* 111 SHA-1 ID. The kernel repository holds a *lot* of objects, making
111 collisions with shorter IDs a real possibility 112 collisions with shorter IDs a real possibility. Bear in mind that, even if
112 there is no collision with your six-character 113 there is no collision with your six-character ID now, that condition may
113 change five years from now. 114 change five years from now.
114 115
115 If related discussions or any other background 116 If related discussions or any other background information behind the change
116 can be found on the web, add 'Link:' tags poin !! 117 can be found on the web, add 'Link:' tags pointing to it. In case your patch
117 result of some earlier mailing list discussion !! 118 fixes a bug, for example, add a tag with a URL referencing the report in the
118 web, point to it. !! 119 mailing list archives or a bug tracker; if the patch is a result of some
>> 120 earlier mailing list discussion or something documented on the web, point to
>> 121 it.
119 122
120 When linking to mailing list archives, prefera 123 When linking to mailing list archives, preferably use the lore.kernel.org
121 message archiver service. To create the link U 124 message archiver service. To create the link URL, use the contents of the
122 ``Message-ID`` header of the message without t !! 125 ``Message-Id`` header of the message without the surrounding angle brackets.
123 For example:: 126 For example::
124 127
125 Link: https://lore.kernel.org/30th.anniver !! 128 Link: https://lore.kernel.org/r/30th.anniversary.repost@klaava.Helsinki.FI/
126 129
127 Please check the link to make sure that it is 130 Please check the link to make sure that it is actually working and points
128 to the relevant message. 131 to the relevant message.
129 132
130 However, try to make your explanation understa 133 However, try to make your explanation understandable without external
131 resources. In addition to giving a URL to a ma 134 resources. In addition to giving a URL to a mailing list archive or bug,
132 summarize the relevant points of the discussio 135 summarize the relevant points of the discussion that led to the
133 patch as submitted. 136 patch as submitted.
134 137
135 In case your patch fixes a bug, use the 'Close <<
136 the report in the mailing list archives or a p <<
137 <<
138 Closes: https://example.com/issues/123 <<
139 <<
140 Some bug trackers have the ability to close is <<
141 commit with such a tag is applied. Some bots m <<
142 also track such tags and take certain actions. <<
143 invalid URLs are forbidden. <<
144 <<
145 If your patch fixes a bug in a specific commit 138 If your patch fixes a bug in a specific commit, e.g. you found an issue using
146 ``git bisect``, please use the 'Fixes:' tag wi 139 ``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
147 the SHA-1 ID, and the one line summary. Do no 140 the SHA-1 ID, and the one line summary. Do not split the tag across multiple
148 lines, tags are exempt from the "wrap at 75 co 141 lines, tags are exempt from the "wrap at 75 columns" rule in order to simplify
149 parsing scripts. For example:: 142 parsing scripts. For example::
150 143
151 Fixes: 54a4f0239f2e ("KVM: MMU: make k 144 Fixes: 54a4f0239f2e ("KVM: MMU: make kvm_mmu_zap_page() return the number of pages it actually freed")
152 145
153 The following ``git config`` settings can be u 146 The following ``git config`` settings can be used to add a pretty format for
154 outputting the above style in the ``git log`` 147 outputting the above style in the ``git log`` or ``git show`` commands::
155 148
156 [core] 149 [core]
157 abbrev = 12 150 abbrev = 12
158 [pretty] 151 [pretty]
159 fixes = Fixes: %h (\"%s\") 152 fixes = Fixes: %h (\"%s\")
160 153
161 An example call:: 154 An example call::
162 155
163 $ git log -1 --pretty=fixes 54a4f0239f 156 $ git log -1 --pretty=fixes 54a4f0239f2e
164 Fixes: 54a4f0239f2e ("KVM: MMU: make k 157 Fixes: 54a4f0239f2e ("KVM: MMU: make kvm_mmu_zap_page() return the number of pages it actually freed")
165 158
166 .. _split_changes: 159 .. _split_changes:
167 160
168 Separate your changes 161 Separate your changes
169 --------------------- 162 ---------------------
170 163
171 Separate each **logical change** into a separa 164 Separate each **logical change** into a separate patch.
172 165
173 For example, if your changes include both bug 166 For example, if your changes include both bug fixes and performance
174 enhancements for a single driver, separate tho 167 enhancements for a single driver, separate those changes into two
175 or more patches. If your changes include an A 168 or more patches. If your changes include an API update, and a new
176 driver which uses that new API, separate those 169 driver which uses that new API, separate those into two patches.
177 170
178 On the other hand, if you make a single change 171 On the other hand, if you make a single change to numerous files,
179 group those changes into a single patch. Thus 172 group those changes into a single patch. Thus a single logical change
180 is contained within a single patch. 173 is contained within a single patch.
181 174
182 The point to remember is that each patch shoul 175 The point to remember is that each patch should make an easily understood
183 change that can be verified by reviewers. Eac 176 change that can be verified by reviewers. Each patch should be justifiable
184 on its own merits. 177 on its own merits.
185 178
186 If one patch depends on another patch in order 179 If one patch depends on another patch in order for a change to be
187 complete, that is OK. Simply note **"this pat 180 complete, that is OK. Simply note **"this patch depends on patch X"**
188 in your patch description. 181 in your patch description.
189 182
190 When dividing your change into a series of pat 183 When dividing your change into a series of patches, take special care to
191 ensure that the kernel builds and runs properl 184 ensure that the kernel builds and runs properly after each patch in the
192 series. Developers using ``git bisect`` to tr 185 series. Developers using ``git bisect`` to track down a problem can end up
193 splitting your patch series at any point; they 186 splitting your patch series at any point; they will not thank you if you
194 introduce bugs in the middle. 187 introduce bugs in the middle.
195 188
196 If you cannot condense your patch set into a s 189 If you cannot condense your patch set into a smaller set of patches,
197 then only post say 15 or so at a time and wait 190 then only post say 15 or so at a time and wait for review and integration.
198 191
199 192
200 193
201 Style-check your changes 194 Style-check your changes
202 ------------------------ 195 ------------------------
203 196
204 Check your patch for basic style violations, d 197 Check your patch for basic style violations, details of which can be
205 found in Documentation/process/coding-style.rs 198 found in Documentation/process/coding-style.rst.
206 Failure to do so simply wastes 199 Failure to do so simply wastes
207 the reviewers time and will get your patch rej 200 the reviewers time and will get your patch rejected, probably
208 without even being read. 201 without even being read.
209 202
210 One significant exception is when moving code 203 One significant exception is when moving code from one file to
211 another -- in this case you should not modify 204 another -- in this case you should not modify the moved code at all in
212 the same patch which moves it. This clearly d 205 the same patch which moves it. This clearly delineates the act of
213 moving the code and your changes. This greatl 206 moving the code and your changes. This greatly aids review of the
214 actual differences and allows tools to better 207 actual differences and allows tools to better track the history of
215 the code itself. 208 the code itself.
216 209
217 Check your patches with the patch style checke 210 Check your patches with the patch style checker prior to submission
218 (scripts/checkpatch.pl). Note, though, that t 211 (scripts/checkpatch.pl). Note, though, that the style checker should be
219 viewed as a guide, not as a replacement for hu 212 viewed as a guide, not as a replacement for human judgment. If your code
220 looks better with a violation then its probabl 213 looks better with a violation then its probably best left alone.
221 214
222 The checker reports at three levels: 215 The checker reports at three levels:
223 - ERROR: things that are very likely to be wr 216 - ERROR: things that are very likely to be wrong
224 - WARNING: things requiring careful review 217 - WARNING: things requiring careful review
225 - CHECK: things requiring thought 218 - CHECK: things requiring thought
226 219
227 You should be able to justify all violations t 220 You should be able to justify all violations that remain in your
228 patch. 221 patch.
229 222
230 223
231 Select the recipients for your patch 224 Select the recipients for your patch
232 ------------------------------------ 225 ------------------------------------
233 226
234 You should always copy the appropriate subsyst !! 227 You should always copy the appropriate subsystem maintainer(s) on any patch
235 any patch to code that they maintain; look thr !! 228 to code that they maintain; look through the MAINTAINERS file and the
236 source code revision history to see who those !! 229 source code revision history to see who those maintainers are. The
237 scripts/get_maintainer.pl can be very useful a !! 230 script scripts/get_maintainer.pl can be very useful at this step (pass paths to
238 patches as arguments to scripts/get_maintainer !! 231 your patches as arguments to scripts/get_maintainer.pl). If you cannot find a
239 maintainer for the subsystem you are working o 232 maintainer for the subsystem you are working on, Andrew Morton
240 (akpm@linux-foundation.org) serves as a mainta 233 (akpm@linux-foundation.org) serves as a maintainer of last resort.
241 234
242 linux-kernel@vger.kernel.org should be used by !! 235 You should also normally choose at least one mailing list to receive a copy
243 volume on that list has caused a number of dev !! 236 of your patch set. linux-kernel@vger.kernel.org should be used by default
244 do not spam unrelated lists and unrelated peop !! 237 for all patches, but the volume on that list has caused a number of
245 !! 238 developers to tune it out. Look in the MAINTAINERS file for a
246 Many kernel-related lists are hosted at kernel !! 239 subsystem-specific list; your patch will probably get more attention there.
247 of them at https://subspace.kernel.org. There !! 240 Please do not spam unrelated lists, though.
248 hosted elsewhere as well, though. !! 241
>> 242 Many kernel-related lists are hosted on vger.kernel.org; you can find a
>> 243 list of them at http://vger.kernel.org/vger-lists.html. There are
>> 244 kernel-related lists hosted elsewhere as well, though.
>> 245
>> 246 Do not send more than 15 patches at once to the vger mailing lists!!!
249 247
250 Linus Torvalds is the final arbiter of all cha 248 Linus Torvalds is the final arbiter of all changes accepted into the
251 Linux kernel. His e-mail address is <torvalds@ 249 Linux kernel. His e-mail address is <torvalds@linux-foundation.org>.
252 He gets a lot of e-mail, and, at this point, v 250 He gets a lot of e-mail, and, at this point, very few patches go through
253 Linus directly, so typically you should do you 251 Linus directly, so typically you should do your best to -avoid-
254 sending him e-mail. 252 sending him e-mail.
255 253
256 If you have a patch that fixes an exploitable 254 If you have a patch that fixes an exploitable security bug, send that patch
257 to security@kernel.org. For severe bugs, a sh 255 to security@kernel.org. For severe bugs, a short embargo may be considered
258 to allow distributors to get the patch out to 256 to allow distributors to get the patch out to users; in such cases,
259 obviously, the patch should not be sent to any 257 obviously, the patch should not be sent to any public lists. See also
260 Documentation/process/security-bugs.rst. !! 258 Documentation/admin-guide/security-bugs.rst.
261 259
262 Patches that fix a severe bug in a released ke 260 Patches that fix a severe bug in a released kernel should be directed
263 toward the stable maintainers by putting a lin 261 toward the stable maintainers by putting a line like this::
264 262
265 Cc: stable@vger.kernel.org 263 Cc: stable@vger.kernel.org
266 264
267 into the sign-off area of your patch (note, NO 265 into the sign-off area of your patch (note, NOT an email recipient). You
268 should also read Documentation/process/stable- 266 should also read Documentation/process/stable-kernel-rules.rst
269 in addition to this document. 267 in addition to this document.
270 268
271 If changes affect userland-kernel interfaces, 269 If changes affect userland-kernel interfaces, please send the MAN-PAGES
272 maintainer (as listed in the MAINTAINERS file) 270 maintainer (as listed in the MAINTAINERS file) a man-pages patch, or at
273 least a notification of the change, so that so 271 least a notification of the change, so that some information makes its way
274 into the manual pages. User-space API changes 272 into the manual pages. User-space API changes should also be copied to
275 linux-api@vger.kernel.org. 273 linux-api@vger.kernel.org.
276 274
277 275
278 No MIME, no links, no compression, no attachme 276 No MIME, no links, no compression, no attachments. Just plain text
279 ---------------------------------------------- 277 -------------------------------------------------------------------
280 278
281 Linus and other kernel developers need to be a 279 Linus and other kernel developers need to be able to read and comment
282 on the changes you are submitting. It is impo 280 on the changes you are submitting. It is important for a kernel
283 developer to be able to "quote" your changes, 281 developer to be able to "quote" your changes, using standard e-mail
284 tools, so that they may comment on specific po 282 tools, so that they may comment on specific portions of your code.
285 283
286 For this reason, all patches should be submitt 284 For this reason, all patches should be submitted by e-mail "inline". The
287 easiest way to do this is with ``git send-emai 285 easiest way to do this is with ``git send-email``, which is strongly
288 recommended. An interactive tutorial for ``gi 286 recommended. An interactive tutorial for ``git send-email`` is available at
289 https://git-send-email.io. 287 https://git-send-email.io.
290 288
291 If you choose not to use ``git send-email``: 289 If you choose not to use ``git send-email``:
292 290
293 .. warning:: 291 .. warning::
294 292
295 Be wary of your editor's word-wrap corruptin 293 Be wary of your editor's word-wrap corrupting your patch,
296 if you choose to cut-n-paste your patch. 294 if you choose to cut-n-paste your patch.
297 295
298 Do not attach the patch as a MIME attachment, 296 Do not attach the patch as a MIME attachment, compressed or not.
299 Many popular e-mail applications will not alwa 297 Many popular e-mail applications will not always transmit a MIME
300 attachment as plain text, making it impossible 298 attachment as plain text, making it impossible to comment on your
301 code. A MIME attachment also takes Linus a bi 299 code. A MIME attachment also takes Linus a bit more time to process,
302 decreasing the likelihood of your MIME-attache 300 decreasing the likelihood of your MIME-attached change being accepted.
303 301
304 Exception: If your mailer is mangling patches 302 Exception: If your mailer is mangling patches then someone may ask
305 you to re-send them using MIME. 303 you to re-send them using MIME.
306 304
307 See Documentation/process/email-clients.rst fo 305 See Documentation/process/email-clients.rst for hints about configuring
308 your e-mail client so that it sends your patch 306 your e-mail client so that it sends your patches untouched.
309 307
310 Respond to review comments 308 Respond to review comments
311 -------------------------- 309 --------------------------
312 310
313 Your patch will almost certainly get comments 311 Your patch will almost certainly get comments from reviewers on ways in
314 which the patch can be improved, in the form o 312 which the patch can be improved, in the form of a reply to your email. You must
315 respond to those comments; ignoring reviewers 313 respond to those comments; ignoring reviewers is a good way to get ignored in
316 return. You can simply reply to their emails t 314 return. You can simply reply to their emails to answer their comments. Review
317 comments or questions that do not lead to a co 315 comments or questions that do not lead to a code change should almost certainly
318 bring about a comment or changelog entry so th 316 bring about a comment or changelog entry so that the next reviewer better
319 understands what is going on. 317 understands what is going on.
320 318
321 Be sure to tell the reviewers what changes you 319 Be sure to tell the reviewers what changes you are making and to thank them
322 for their time. Code review is a tiring and t 320 for their time. Code review is a tiring and time-consuming process, and
323 reviewers sometimes get grumpy. Even in that 321 reviewers sometimes get grumpy. Even in that case, though, respond
324 politely and address the problems they have po 322 politely and address the problems they have pointed out. When sending a next
325 version, add a ``patch changelog`` to the cove 323 version, add a ``patch changelog`` to the cover letter or to individual patches
326 explaining difference against previous submiss !! 324 explaining difference aganst previous submission (see
327 :ref:`the_canonical_patch_format`). 325 :ref:`the_canonical_patch_format`).
328 Notify people that commented on your patch abo <<
329 the patches CC list. <<
330 326
331 See Documentation/process/email-clients.rst fo 327 See Documentation/process/email-clients.rst for recommendations on email
332 clients and mailing list etiquette. 328 clients and mailing list etiquette.
333 329
334 .. _interleaved_replies: <<
335 <<
336 Use trimmed interleaved replies in email discu <<
337 ---------------------------------------------- <<
338 Top-posting is strongly discouraged in Linux k <<
339 discussions. Interleaved (or "inline") replies <<
340 easier to follow. For more details see: <<
341 https://en.wikipedia.org/wiki/Posting_style#In <<
342 <<
343 As is frequently quoted on the mailing list:: <<
344 <<
345 A: http://en.wikipedia.org/wiki/Top_post <<
346 Q: Were do I find info about this thing call <<
347 A: Because it messes up the order in which p <<
348 Q: Why is top-posting such a bad thing? <<
349 A: Top-posting. <<
350 Q: What is the most annoying thing in e-mail <<
351 <<
352 Similarly, please trim all unneeded quotations <<
353 to your reply. This makes responses easier to <<
354 space. For more details see: http://daringfire <<
355 <<
356 A: No. <<
357 Q: Should I include quotations after my repl <<
358 <<
359 .. _resend_reminders: 330 .. _resend_reminders:
360 331
361 Don't get discouraged - or impatient 332 Don't get discouraged - or impatient
362 ------------------------------------ 333 ------------------------------------
363 334
364 After you have submitted your change, be patie 335 After you have submitted your change, be patient and wait. Reviewers are
365 busy people and may not get to your patch righ 336 busy people and may not get to your patch right away.
366 337
367 Once upon a time, patches used to disappear in 338 Once upon a time, patches used to disappear into the void without comment,
368 but the development process works more smoothl 339 but the development process works more smoothly than that now. You should
369 receive comments within a few weeks (typically !! 340 receive comments within a week or so; if that does not happen, make sure
370 happen, make sure that you have sent your patc !! 341 that you have sent your patches to the right place. Wait for a minimum of
371 Wait for a minimum of one week before resubmit !! 342 one week before resubmitting or pinging reviewers - possibly longer during
372 - possibly longer during busy times like merge !! 343 busy times like merge windows.
373 344
374 It's also ok to resend the patch or the patch 345 It's also ok to resend the patch or the patch series after a couple of
375 weeks with the word "RESEND" added to the subj 346 weeks with the word "RESEND" added to the subject line::
376 347
377 [PATCH Vx RESEND] sub/sys: Condensed patch 348 [PATCH Vx RESEND] sub/sys: Condensed patch summary
378 349
379 Don't add "RESEND" when you are submitting a m 350 Don't add "RESEND" when you are submitting a modified version of your
380 patch or patch series - "RESEND" only applies 351 patch or patch series - "RESEND" only applies to resubmission of a
381 patch or patch series which have not been modi 352 patch or patch series which have not been modified in any way from the
382 previous submission. 353 previous submission.
383 354
384 355
385 Include PATCH in the subject 356 Include PATCH in the subject
386 ----------------------------- 357 -----------------------------
387 358
388 Due to high e-mail traffic to Linus, and to li 359 Due to high e-mail traffic to Linus, and to linux-kernel, it is common
389 convention to prefix your subject line with [P 360 convention to prefix your subject line with [PATCH]. This lets Linus
390 and other kernel developers more easily distin 361 and other kernel developers more easily distinguish patches from other
391 e-mail discussions. 362 e-mail discussions.
392 363
393 ``git send-email`` will do this for you automa 364 ``git send-email`` will do this for you automatically.
394 365
395 366
396 Sign your work - the Developer's Certificate o 367 Sign your work - the Developer's Certificate of Origin
397 ---------------------------------------------- 368 ------------------------------------------------------
398 369
399 To improve tracking of who did what, especiall 370 To improve tracking of who did what, especially with patches that can
400 percolate to their final resting place in the 371 percolate to their final resting place in the kernel through several
401 layers of maintainers, we've introduced a "sig 372 layers of maintainers, we've introduced a "sign-off" procedure on
402 patches that are being emailed around. 373 patches that are being emailed around.
403 374
404 The sign-off is a simple line at the end of th 375 The sign-off is a simple line at the end of the explanation for the
405 patch, which certifies that you wrote it or ot 376 patch, which certifies that you wrote it or otherwise have the right to
406 pass it on as an open-source patch. The rules 377 pass it on as an open-source patch. The rules are pretty simple: if you
407 can certify the below: 378 can certify the below:
408 379
409 Developer's Certificate of Origin 1.1 380 Developer's Certificate of Origin 1.1
410 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 381 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
411 382
412 By making a contribution to this project, I ce 383 By making a contribution to this project, I certify that:
413 384
414 (a) The contribution was created in wh 385 (a) The contribution was created in whole or in part by me and I
415 have the right to submit it under 386 have the right to submit it under the open source license
416 indicated in the file; or 387 indicated in the file; or
417 388
418 (b) The contribution is based upon pre 389 (b) The contribution is based upon previous work that, to the best
419 of my knowledge, is covered under 390 of my knowledge, is covered under an appropriate open source
420 license and I have the right under 391 license and I have the right under that license to submit that
421 work with modifications, whether c 392 work with modifications, whether created in whole or in part
422 by me, under the same open source 393 by me, under the same open source license (unless I am
423 permitted to submit under a differ 394 permitted to submit under a different license), as indicated
424 in the file; or 395 in the file; or
425 396
426 (c) The contribution was provided dire 397 (c) The contribution was provided directly to me by some other
427 person who certified (a), (b) or ( 398 person who certified (a), (b) or (c) and I have not modified
428 it. 399 it.
429 400
430 (d) I understand and agree that this p 401 (d) I understand and agree that this project and the contribution
431 are public and that a record of th 402 are public and that a record of the contribution (including all
432 personal information I submit with 403 personal information I submit with it, including my sign-off) is
433 maintained indefinitely and may be 404 maintained indefinitely and may be redistributed consistent with
434 this project or the open source li 405 this project or the open source license(s) involved.
435 406
436 then you just add a line saying:: 407 then you just add a line saying::
437 408
438 Signed-off-by: Random J Developer <rand 409 Signed-off-by: Random J Developer <random@developer.example.org>
439 410
440 using a known identity (sorry, no anonymous co !! 411 using your real name (sorry, no pseudonyms or anonymous contributions.)
441 This will be done for you automatically if you 412 This will be done for you automatically if you use ``git commit -s``.
442 Reverts should also include "Signed-off-by". ` 413 Reverts should also include "Signed-off-by". ``git revert -s`` does that
443 for you. 414 for you.
444 415
445 Some people also put extra tags at the end. T 416 Some people also put extra tags at the end. They'll just be ignored for
446 now, but you can do this to mark internal comp 417 now, but you can do this to mark internal company procedures or just
447 point out some special detail about the sign-o 418 point out some special detail about the sign-off.
448 419
449 Any further SoBs (Signed-off-by:'s) following 420 Any further SoBs (Signed-off-by:'s) following the author's SoB are from
450 people handling and transporting the patch, bu 421 people handling and transporting the patch, but were not involved in its
451 development. SoB chains should reflect the **r 422 development. SoB chains should reflect the **real** route a patch took
452 as it was propagated to the maintainers and ul 423 as it was propagated to the maintainers and ultimately to Linus, with
453 the first SoB entry signalling primary authors 424 the first SoB entry signalling primary authorship of a single author.
454 425
455 426
456 When to use Acked-by:, Cc:, and Co-developed-b 427 When to use Acked-by:, Cc:, and Co-developed-by:
457 ---------------------------------------------- 428 ------------------------------------------------
458 429
459 The Signed-off-by: tag indicates that the sign 430 The Signed-off-by: tag indicates that the signer was involved in the
460 development of the patch, or that he/she was i 431 development of the patch, or that he/she was in the patch's delivery path.
461 432
462 If a person was not directly involved in the p 433 If a person was not directly involved in the preparation or handling of a
463 patch but wishes to signify and record their a 434 patch but wishes to signify and record their approval of it then they can
464 ask to have an Acked-by: line added to the pat 435 ask to have an Acked-by: line added to the patch's changelog.
465 436
466 Acked-by: is often used by the maintainer of t 437 Acked-by: is often used by the maintainer of the affected code when that
467 maintainer neither contributed to nor forwarde 438 maintainer neither contributed to nor forwarded the patch.
468 439
469 Acked-by: is not as formal as Signed-off-by:. 440 Acked-by: is not as formal as Signed-off-by:. It is a record that the acker
470 has at least reviewed the patch and has indica 441 has at least reviewed the patch and has indicated acceptance. Hence patch
471 mergers will sometimes manually convert an ack 442 mergers will sometimes manually convert an acker's "yep, looks good to me"
472 into an Acked-by: (but note that it is usually 443 into an Acked-by: (but note that it is usually better to ask for an
473 explicit ack). 444 explicit ack).
474 445
475 Acked-by: does not necessarily indicate acknow 446 Acked-by: does not necessarily indicate acknowledgement of the entire patch.
476 For example, if a patch affects multiple subsy 447 For example, if a patch affects multiple subsystems and has an Acked-by: from
477 one subsystem maintainer then this usually ind 448 one subsystem maintainer then this usually indicates acknowledgement of just
478 the part which affects that maintainer's code. 449 the part which affects that maintainer's code. Judgement should be used here.
479 When in doubt people should refer to the origi 450 When in doubt people should refer to the original discussion in the mailing
480 list archives. 451 list archives.
481 452
482 If a person has had the opportunity to comment 453 If a person has had the opportunity to comment on a patch, but has not
483 provided such comments, you may optionally add 454 provided such comments, you may optionally add a ``Cc:`` tag to the patch.
484 This is the only tag which might be added with 455 This is the only tag which might be added without an explicit action by the
485 person it names - but it should indicate that 456 person it names - but it should indicate that this person was copied on the
486 patch. This tag documents that potentially in 457 patch. This tag documents that potentially interested parties
487 have been included in the discussion. 458 have been included in the discussion.
488 459
489 Co-developed-by: states that the patch was co- 460 Co-developed-by: states that the patch was co-created by multiple developers;
490 it is used to give attribution to co-authors ( 461 it is used to give attribution to co-authors (in addition to the author
491 attributed by the From: tag) when several peop 462 attributed by the From: tag) when several people work on a single patch. Since
492 Co-developed-by: denotes authorship, every Co- 463 Co-developed-by: denotes authorship, every Co-developed-by: must be immediately
493 followed by a Signed-off-by: of the associated 464 followed by a Signed-off-by: of the associated co-author. Standard sign-off
494 procedure applies, i.e. the ordering of Signed 465 procedure applies, i.e. the ordering of Signed-off-by: tags should reflect the
495 chronological history of the patch insofar as 466 chronological history of the patch insofar as possible, regardless of whether
496 the author is attributed via From: or Co-devel 467 the author is attributed via From: or Co-developed-by:. Notably, the last
497 Signed-off-by: must always be that of the deve 468 Signed-off-by: must always be that of the developer submitting the patch.
498 469
499 Note, the From: tag is optional when the From: 470 Note, the From: tag is optional when the From: author is also the person (and
500 email) listed in the From: line of the email h 471 email) listed in the From: line of the email header.
501 472
502 Example of a patch submitted by the From: auth 473 Example of a patch submitted by the From: author::
503 474
504 <changelog> 475 <changelog>
505 476
506 Co-developed-by: First Co-Author <first 477 Co-developed-by: First Co-Author <first@coauthor.example.org>
507 Signed-off-by: First Co-Author <first@c 478 Signed-off-by: First Co-Author <first@coauthor.example.org>
508 Co-developed-by: Second Co-Author <seco 479 Co-developed-by: Second Co-Author <second@coauthor.example.org>
509 Signed-off-by: Second Co-Author <second 480 Signed-off-by: Second Co-Author <second@coauthor.example.org>
510 Signed-off-by: From Author <from@author 481 Signed-off-by: From Author <from@author.example.org>
511 482
512 Example of a patch submitted by a Co-developed 483 Example of a patch submitted by a Co-developed-by: author::
513 484
514 From: From Author <from@author.example. 485 From: From Author <from@author.example.org>
515 486
516 <changelog> 487 <changelog>
517 488
518 Co-developed-by: Random Co-Author <rand 489 Co-developed-by: Random Co-Author <random@coauthor.example.org>
519 Signed-off-by: Random Co-Author <random 490 Signed-off-by: Random Co-Author <random@coauthor.example.org>
520 Signed-off-by: From Author <from@author 491 Signed-off-by: From Author <from@author.example.org>
521 Co-developed-by: Submitting Co-Author < 492 Co-developed-by: Submitting Co-Author <sub@coauthor.example.org>
522 Signed-off-by: Submitting Co-Author <su 493 Signed-off-by: Submitting Co-Author <sub@coauthor.example.org>
523 494
524 495
525 Using Reported-by:, Tested-by:, Reviewed-by:, 496 Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:
526 ---------------------------------------------- 497 ----------------------------------------------------------------------
527 498
528 The Reported-by tag gives credit to people who 499 The Reported-by tag gives credit to people who find bugs and report them and it
529 hopefully inspires them to help us again in th !! 500 hopefully inspires them to help us again in the future. Please note that if
530 bugs; please do not use it to credit feature r !! 501 the bug was reported in private, then ask for permission first before using the
531 followed by a Closes: tag pointing to the repo !! 502 Reported-by tag. The tag is intended for bugs; please do not use it to credit
532 available on the web. The Link: tag can be use !! 503 feature requests.
533 fixes a part of the issue(s) being reported. P <<
534 reported in private, then ask for permission f <<
535 tag. <<
536 504
537 A Tested-by: tag indicates that the patch has 505 A Tested-by: tag indicates that the patch has been successfully tested (in
538 some environment) by the person named. This t 506 some environment) by the person named. This tag informs maintainers that
539 some testing has been performed, provides a me 507 some testing has been performed, provides a means to locate testers for
540 future patches, and ensures credit for the tes 508 future patches, and ensures credit for the testers.
541 509
542 Reviewed-by:, instead, indicates that the patc 510 Reviewed-by:, instead, indicates that the patch has been reviewed and found
543 acceptable according to the Reviewer's Stateme 511 acceptable according to the Reviewer's Statement:
544 512
545 Reviewer's statement of oversight 513 Reviewer's statement of oversight
546 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 514 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
547 515
548 By offering my Reviewed-by: tag, I state that: 516 By offering my Reviewed-by: tag, I state that:
549 517
550 (a) I have carried out a technical re 518 (a) I have carried out a technical review of this patch to
551 evaluate its appropriateness and 519 evaluate its appropriateness and readiness for inclusion into
552 the mainline kernel. 520 the mainline kernel.
553 521
554 (b) Any problems, concerns, or questi 522 (b) Any problems, concerns, or questions relating to the patch
555 have been communicated back to th 523 have been communicated back to the submitter. I am satisfied
556 with the submitter's response to 524 with the submitter's response to my comments.
557 525
558 (c) While there may be things that co 526 (c) While there may be things that could be improved with this
559 submission, I believe that it is, 527 submission, I believe that it is, at this time, (1) a
560 worthwhile modification to the ke 528 worthwhile modification to the kernel, and (2) free of known
561 issues which would argue against 529 issues which would argue against its inclusion.
562 530
563 (d) While I have reviewed the patch a 531 (d) While I have reviewed the patch and believe it to be sound, I
564 do not (unless explicitly stated 532 do not (unless explicitly stated elsewhere) make any
565 warranties or guarantees that it 533 warranties or guarantees that it will achieve its stated
566 purpose or function properly in a 534 purpose or function properly in any given situation.
567 535
568 A Reviewed-by tag is a statement of opinion th 536 A Reviewed-by tag is a statement of opinion that the patch is an
569 appropriate modification of the kernel without 537 appropriate modification of the kernel without any remaining serious
570 technical issues. Any interested reviewer (wh 538 technical issues. Any interested reviewer (who has done the work) can
571 offer a Reviewed-by tag for a patch. This tag 539 offer a Reviewed-by tag for a patch. This tag serves to give credit to
572 reviewers and to inform maintainers of the deg 540 reviewers and to inform maintainers of the degree of review which has been
573 done on the patch. Reviewed-by: tags, when su 541 done on the patch. Reviewed-by: tags, when supplied by reviewers known to
574 understand the subject area and to perform tho 542 understand the subject area and to perform thorough reviews, will normally
575 increase the likelihood of your patch getting 543 increase the likelihood of your patch getting into the kernel.
576 544
577 Both Tested-by and Reviewed-by tags, once rece 545 Both Tested-by and Reviewed-by tags, once received on mailing list from tester
578 or reviewer, should be added by author to the 546 or reviewer, should be added by author to the applicable patches when sending
579 next versions. However if the patch has chang 547 next versions. However if the patch has changed substantially in following
580 version, these tags might not be applicable an 548 version, these tags might not be applicable anymore and thus should be removed.
581 Usually removal of someone's Tested-by or Revi 549 Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned
582 in the patch changelog (after the '---' separa 550 in the patch changelog (after the '---' separator).
583 551
584 A Suggested-by: tag indicates that the patch i 552 A Suggested-by: tag indicates that the patch idea is suggested by the person
585 named and ensures credit to the person for the 553 named and ensures credit to the person for the idea. Please note that this
586 tag should not be added without the reporter's 554 tag should not be added without the reporter's permission, especially if the
587 idea was not posted in a public forum. That sa 555 idea was not posted in a public forum. That said, if we diligently credit our
588 idea reporters, they will, hopefully, be inspi 556 idea reporters, they will, hopefully, be inspired to help us again in the
589 future. 557 future.
590 558
591 A Fixes: tag indicates that the patch fixes an 559 A Fixes: tag indicates that the patch fixes an issue in a previous commit. It
592 is used to make it easy to determine where a b 560 is used to make it easy to determine where a bug originated, which can help
593 review a bug fix. This tag also assists the st 561 review a bug fix. This tag also assists the stable kernel team in determining
594 which stable kernel versions should receive yo 562 which stable kernel versions should receive your fix. This is the preferred
595 method for indicating a bug fixed by the patch 563 method for indicating a bug fixed by the patch. See :ref:`describe_changes`
596 for more details. 564 for more details.
597 565
598 Note: Attaching a Fixes: tag does not subvert 566 Note: Attaching a Fixes: tag does not subvert the stable kernel rules
599 process nor the requirement to Cc: stable@vger 567 process nor the requirement to Cc: stable@vger.kernel.org on all stable
600 patch candidates. For more information, please 568 patch candidates. For more information, please read
601 Documentation/process/stable-kernel-rules.rst. 569 Documentation/process/stable-kernel-rules.rst.
602 570
603 .. _the_canonical_patch_format: 571 .. _the_canonical_patch_format:
604 572
605 The canonical patch format 573 The canonical patch format
606 -------------------------- 574 --------------------------
607 575
608 This section describes how the patch itself sh 576 This section describes how the patch itself should be formatted. Note
609 that, if you have your patches stored in a ``g 577 that, if you have your patches stored in a ``git`` repository, proper patch
610 formatting can be had with ``git format-patch` 578 formatting can be had with ``git format-patch``. The tools cannot create
611 the necessary text, though, so read the instru 579 the necessary text, though, so read the instructions below anyway.
612 580
613 The canonical patch subject line is:: 581 The canonical patch subject line is::
614 582
615 Subject: [PATCH 001/123] subsystem: summar 583 Subject: [PATCH 001/123] subsystem: summary phrase
616 584
617 The canonical patch message body contains the 585 The canonical patch message body contains the following:
618 586
619 - A ``from`` line specifying the patch autho 587 - A ``from`` line specifying the patch author, followed by an empty
620 line (only needed if the person sending th 588 line (only needed if the person sending the patch is not the author).
621 589
622 - The body of the explanation, line wrapped 590 - The body of the explanation, line wrapped at 75 columns, which will
623 be copied to the permanent changelog to de 591 be copied to the permanent changelog to describe this patch.
624 592
625 - An empty line. 593 - An empty line.
626 594
627 - The ``Signed-off-by:`` lines, described ab 595 - The ``Signed-off-by:`` lines, described above, which will
628 also go in the changelog. 596 also go in the changelog.
629 597
630 - A marker line containing simply ``---``. 598 - A marker line containing simply ``---``.
631 599
632 - Any additional comments not suitable for t 600 - Any additional comments not suitable for the changelog.
633 601
634 - The actual patch (``diff`` output). 602 - The actual patch (``diff`` output).
635 603
636 The Subject line format makes it very easy to 604 The Subject line format makes it very easy to sort the emails
637 alphabetically by subject line - pretty much a 605 alphabetically by subject line - pretty much any email reader will
638 support that - since because the sequence numb 606 support that - since because the sequence number is zero-padded,
639 the numerical and alphabetic sort is the same. 607 the numerical and alphabetic sort is the same.
640 608
641 The ``subsystem`` in the email's Subject shoul 609 The ``subsystem`` in the email's Subject should identify which
642 area or subsystem of the kernel is being patch 610 area or subsystem of the kernel is being patched.
643 611
644 The ``summary phrase`` in the email's Subject 612 The ``summary phrase`` in the email's Subject should concisely
645 describe the patch which that email contains. 613 describe the patch which that email contains. The ``summary
646 phrase`` should not be a filename. Do not use 614 phrase`` should not be a filename. Do not use the same ``summary
647 phrase`` for every patch in a whole patch seri 615 phrase`` for every patch in a whole patch series (where a ``patch
648 series`` is an ordered sequence of multiple, r 616 series`` is an ordered sequence of multiple, related patches).
649 617
650 Bear in mind that the ``summary phrase`` of yo 618 Bear in mind that the ``summary phrase`` of your email becomes a
651 globally-unique identifier for that patch. It 619 globally-unique identifier for that patch. It propagates all the way
652 into the ``git`` changelog. The ``summary phr 620 into the ``git`` changelog. The ``summary phrase`` may later be used in
653 developer discussions which refer to the patch 621 developer discussions which refer to the patch. People will want to
654 google for the ``summary phrase`` to read disc 622 google for the ``summary phrase`` to read discussion regarding that
655 patch. It will also be the only thing that pe 623 patch. It will also be the only thing that people may quickly see
656 when, two or three months later, they are goin 624 when, two or three months later, they are going through perhaps
657 thousands of patches using tools such as ``git 625 thousands of patches using tools such as ``gitk`` or ``git log
658 --oneline``. 626 --oneline``.
659 627
660 For these reasons, the ``summary`` must be no 628 For these reasons, the ``summary`` must be no more than 70-75
661 characters, and it must describe both what the 629 characters, and it must describe both what the patch changes, as well
662 as why the patch might be necessary. It is ch 630 as why the patch might be necessary. It is challenging to be both
663 succinct and descriptive, but that is what a w 631 succinct and descriptive, but that is what a well-written summary
664 should do. 632 should do.
665 633
666 The ``summary phrase`` may be prefixed by tags 634 The ``summary phrase`` may be prefixed by tags enclosed in square
667 brackets: "Subject: [PATCH <tag>...] <summary 635 brackets: "Subject: [PATCH <tag>...] <summary phrase>". The tags are
668 not considered part of the summary phrase, but 636 not considered part of the summary phrase, but describe how the patch
669 should be treated. Common tags might include 637 should be treated. Common tags might include a version descriptor if
670 the multiple versions of the patch have been s 638 the multiple versions of the patch have been sent out in response to
671 comments (i.e., "v1, v2, v3"), or "RFC" to ind 639 comments (i.e., "v1, v2, v3"), or "RFC" to indicate a request for
672 comments. 640 comments.
673 641
674 If there are four patches in a patch series th 642 If there are four patches in a patch series the individual patches may
675 be numbered like this: 1/4, 2/4, 3/4, 4/4. Thi 643 be numbered like this: 1/4, 2/4, 3/4, 4/4. This assures that developers
676 understand the order in which the patches shou 644 understand the order in which the patches should be applied and that
677 they have reviewed or applied all of the patch 645 they have reviewed or applied all of the patches in the patch series.
678 646
679 Here are some good example Subjects:: 647 Here are some good example Subjects::
680 648
681 Subject: [PATCH 2/5] ext2: improve scalabi 649 Subject: [PATCH 2/5] ext2: improve scalability of bitmap searching
682 Subject: [PATCH v2 01/27] x86: fix eflags 650 Subject: [PATCH v2 01/27] x86: fix eflags tracking
683 Subject: [PATCH v2] sub/sys: Condensed pat 651 Subject: [PATCH v2] sub/sys: Condensed patch summary
684 Subject: [PATCH v2 M/N] sub/sys: Condensed 652 Subject: [PATCH v2 M/N] sub/sys: Condensed patch summary
685 653
686 The ``from`` line must be the very first line 654 The ``from`` line must be the very first line in the message body,
687 and has the form: 655 and has the form:
688 656
689 From: Patch Author <author@example.com> 657 From: Patch Author <author@example.com>
690 658
691 The ``from`` line specifies who will be credit 659 The ``from`` line specifies who will be credited as the author of the
692 patch in the permanent changelog. If the ``fr 660 patch in the permanent changelog. If the ``from`` line is missing,
693 then the ``From:`` line from the email header 661 then the ``From:`` line from the email header will be used to determine
694 the patch author in the changelog. 662 the patch author in the changelog.
695 663
696 The explanation body will be committed to the 664 The explanation body will be committed to the permanent source
697 changelog, so should make sense to a competent 665 changelog, so should make sense to a competent reader who has long since
698 forgotten the immediate details of the discuss 666 forgotten the immediate details of the discussion that might have led to
699 this patch. Including symptoms of the failure 667 this patch. Including symptoms of the failure which the patch addresses
700 (kernel log messages, oops messages, etc.) are 668 (kernel log messages, oops messages, etc.) are especially useful for
701 people who might be searching the commit logs 669 people who might be searching the commit logs looking for the applicable
702 patch. The text should be written in such deta 670 patch. The text should be written in such detail so that when read
703 weeks, months or even years later, it can give 671 weeks, months or even years later, it can give the reader the needed
704 details to grasp the reasoning for **why** the 672 details to grasp the reasoning for **why** the patch was created.
705 673
706 If a patch fixes a compile failure, it may not 674 If a patch fixes a compile failure, it may not be necessary to include
707 _all_ of the compile failures; just enough tha 675 _all_ of the compile failures; just enough that it is likely that
708 someone searching for the patch can find it. A 676 someone searching for the patch can find it. As in the ``summary
709 phrase``, it is important to be both succinct 677 phrase``, it is important to be both succinct as well as descriptive.
710 678
711 The ``---`` marker line serves the essential p 679 The ``---`` marker line serves the essential purpose of marking for
712 patch handling tools where the changelog messa 680 patch handling tools where the changelog message ends.
713 681
714 One good use for the additional comments after 682 One good use for the additional comments after the ``---`` marker is
715 for a ``diffstat``, to show what files have ch 683 for a ``diffstat``, to show what files have changed, and the number of
716 inserted and deleted lines per file. A ``diffs 684 inserted and deleted lines per file. A ``diffstat`` is especially useful
717 on bigger patches. If you are going to include 685 on bigger patches. If you are going to include a ``diffstat`` after the
718 ``---`` marker, please use ``diffstat`` option 686 ``---`` marker, please use ``diffstat`` options ``-p 1 -w 70`` so that
719 filenames are listed from the top of the kerne 687 filenames are listed from the top of the kernel source tree and don't
720 use too much horizontal space (easily fit in 8 688 use too much horizontal space (easily fit in 80 columns, maybe with some
721 indentation). (``git`` generates appropriate d 689 indentation). (``git`` generates appropriate diffstats by default.)
722 690
723 Other comments relevant only to the moment or 691 Other comments relevant only to the moment or the maintainer, not
724 suitable for the permanent changelog, should a 692 suitable for the permanent changelog, should also go here. A good
725 example of such comments might be ``patch chan 693 example of such comments might be ``patch changelogs`` which describe
726 what has changed between the v1 and v2 version 694 what has changed between the v1 and v2 version of the patch.
727 695
728 Please put this information **after** the ``-- 696 Please put this information **after** the ``---`` line which separates
729 the changelog from the rest of the patch. The 697 the changelog from the rest of the patch. The version information is
730 not part of the changelog which gets committed 698 not part of the changelog which gets committed to the git tree. It is
731 additional information for the reviewers. If i 699 additional information for the reviewers. If it's placed above the
732 commit tags, it needs manual interaction to re 700 commit tags, it needs manual interaction to remove it. If it is below
733 the separator line, it gets automatically stri 701 the separator line, it gets automatically stripped off when applying the
734 patch:: 702 patch::
735 703
736 <commit message> 704 <commit message>
737 ... 705 ...
738 Signed-off-by: Author <author@mail> 706 Signed-off-by: Author <author@mail>
739 --- 707 ---
740 V2 -> V3: Removed redundant helper function 708 V2 -> V3: Removed redundant helper function
741 V1 -> V2: Cleaned up coding style and addres 709 V1 -> V2: Cleaned up coding style and addressed review comments
742 710
743 path/to/file | 5+++-- 711 path/to/file | 5+++--
744 ... 712 ...
745 713
746 See more details on the proper patch format in 714 See more details on the proper patch format in the following
747 references. 715 references.
748 716
749 .. _backtraces: 717 .. _backtraces:
750 718
751 Backtraces in commit messages !! 719 Backtraces in commit mesages
752 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ !! 720 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
753 721
754 Backtraces help document the call chain leadin 722 Backtraces help document the call chain leading to a problem. However,
755 not all backtraces are helpful. For example, e 723 not all backtraces are helpful. For example, early boot call chains are
756 unique and obvious. Copying the full dmesg out 724 unique and obvious. Copying the full dmesg output verbatim, however,
757 adds distracting information like timestamps, 725 adds distracting information like timestamps, module lists, register and
758 stack dumps. 726 stack dumps.
759 727
760 Therefore, the most useful backtraces should d 728 Therefore, the most useful backtraces should distill the relevant
761 information from the dump, which makes it easi 729 information from the dump, which makes it easier to focus on the real
762 issue. Here is an example of a well-trimmed ba 730 issue. Here is an example of a well-trimmed backtrace::
763 731
764 unchecked MSR access error: WRMSR to 0xd51 ( 732 unchecked MSR access error: WRMSR to 0xd51 (tried to write 0x0000000000000064)
765 at rIP: 0xffffffffae059994 (native_write_msr 733 at rIP: 0xffffffffae059994 (native_write_msr+0x4/0x20)
766 Call Trace: 734 Call Trace:
767 mba_wrmsr 735 mba_wrmsr
768 update_domains 736 update_domains
769 rdtgroup_mkdir 737 rdtgroup_mkdir
770 738
771 .. _explicit_in_reply_to: 739 .. _explicit_in_reply_to:
772 740
773 Explicit In-Reply-To headers 741 Explicit In-Reply-To headers
774 ---------------------------- 742 ----------------------------
775 743
776 It can be helpful to manually add In-Reply-To: 744 It can be helpful to manually add In-Reply-To: headers to a patch
777 (e.g., when using ``git send-email``) to assoc 745 (e.g., when using ``git send-email``) to associate the patch with
778 previous relevant discussion, e.g. to link a b 746 previous relevant discussion, e.g. to link a bug fix to the email with
779 the bug report. However, for a multi-patch se 747 the bug report. However, for a multi-patch series, it is generally
780 best to avoid using In-Reply-To: to link to ol 748 best to avoid using In-Reply-To: to link to older versions of the
781 series. This way multiple versions of the pat 749 series. This way multiple versions of the patch don't become an
782 unmanageable forest of references in email cli 750 unmanageable forest of references in email clients. If a link is
783 helpful, you can use the https://lore.kernel.o 751 helpful, you can use the https://lore.kernel.org/ redirector (e.g., in
784 the cover email text) to link to an earlier ve 752 the cover email text) to link to an earlier version of the patch series.
785 753
786 754
787 Providing base tree information 755 Providing base tree information
788 ------------------------------- 756 -------------------------------
789 757
790 When other developers receive your patches and 758 When other developers receive your patches and start the review process,
791 it is absolutely necessary for them to know wh !! 759 it is often useful for them to know where in the tree history they
792 commit/branch your work applies on, considerin !! 760 should place your work. This is particularly useful for automated CI
793 maintainer trees present nowadays. Note again !! 761 processes that attempt to run a series of tests in order to establish
794 MAINTAINERS file explained above. !! 762 the quality of your submission before the maintainer starts the review.
795 <<
796 This is even more important for automated CI p <<
797 run a series of tests in order to establish th <<
798 submission before the maintainer starts the re <<
799 763
800 If you are using ``git format-patch`` to gener 764 If you are using ``git format-patch`` to generate your patches, you can
801 automatically include the base tree informatio 765 automatically include the base tree information in your submission by
802 using the ``--base`` flag. The easiest and mos 766 using the ``--base`` flag. The easiest and most convenient way to use
803 this option is with topical branches:: 767 this option is with topical branches::
804 768
805 $ git checkout -t -b my-topical-branch mas 769 $ git checkout -t -b my-topical-branch master
806 Branch 'my-topical-branch' set up to track 770 Branch 'my-topical-branch' set up to track local branch 'master'.
807 Switched to a new branch 'my-topical-branc 771 Switched to a new branch 'my-topical-branch'
808 772
809 [perform your edits and commits] 773 [perform your edits and commits]
810 774
811 $ git format-patch --base=auto --cover-let 775 $ git format-patch --base=auto --cover-letter -o outgoing/ master
812 outgoing/0000-cover-letter.patch 776 outgoing/0000-cover-letter.patch
813 outgoing/0001-First-Commit.patch 777 outgoing/0001-First-Commit.patch
814 outgoing/... 778 outgoing/...
815 779
816 When you open ``outgoing/0000-cover-letter.pat 780 When you open ``outgoing/0000-cover-letter.patch`` for editing, you will
817 notice that it will have the ``base-commit:`` 781 notice that it will have the ``base-commit:`` trailer at the very
818 bottom, which provides the reviewer and the CI 782 bottom, which provides the reviewer and the CI tools enough information
819 to properly perform ``git am`` without worryin 783 to properly perform ``git am`` without worrying about conflicts::
820 784
821 $ git checkout -b patch-review [base-commi 785 $ git checkout -b patch-review [base-commit-id]
822 Switched to a new branch 'patch-review' 786 Switched to a new branch 'patch-review'
823 $ git am patches.mbox 787 $ git am patches.mbox
824 Applying: First Commit 788 Applying: First Commit
825 Applying: ... 789 Applying: ...
826 790
827 Please see ``man git-format-patch`` for more i 791 Please see ``man git-format-patch`` for more information about this
828 option. 792 option.
829 793
830 .. note:: 794 .. note::
831 795
832 The ``--base`` feature was introduced in g 796 The ``--base`` feature was introduced in git version 2.9.0.
833 797
834 If you are not using git to format your patche 798 If you are not using git to format your patches, you can still include
835 the same ``base-commit`` trailer to indicate t 799 the same ``base-commit`` trailer to indicate the commit hash of the tree
836 on which your work is based. You should add it 800 on which your work is based. You should add it either in the cover
837 letter or in the first patch of the series and 801 letter or in the first patch of the series and it should be placed
838 either below the ``---`` line or at the very b 802 either below the ``---`` line or at the very bottom of all other
839 content, right before your email signature. 803 content, right before your email signature.
840 804
841 Make sure that base commit is in an official m <<
842 and not in some internal, accessible only to y <<
843 would be worthless. <<
844 <<
845 Tooling <<
846 ------- <<
847 <<
848 Many of the technical aspects of this process <<
849 b4, documented at <https://b4.docs.kernel.org/ <<
850 help with things like tracking dependencies, r <<
851 with formatting and sending mails. <<
852 805
853 References 806 References
854 ---------- 807 ----------
855 808
856 Andrew Morton, "The perfect patch" (tpp). 809 Andrew Morton, "The perfect patch" (tpp).
857 <https://www.ozlabs.org/~akpm/stuff/tpp.txt> 810 <https://www.ozlabs.org/~akpm/stuff/tpp.txt>
858 811
859 Jeff Garzik, "Linux kernel patch submission fo 812 Jeff Garzik, "Linux kernel patch submission format".
860 <https://web.archive.org/web/20180829112450/ 813 <https://web.archive.org/web/20180829112450/http://linux.yyz.us/patch-format.html>
861 814
862 Greg Kroah-Hartman, "How to piss off a kernel 815 Greg Kroah-Hartman, "How to piss off a kernel subsystem maintainer".
863 <http://www.kroah.com/log/linux/maintainer.h 816 <http://www.kroah.com/log/linux/maintainer.html>
864 817
865 <http://www.kroah.com/log/linux/maintainer-0 818 <http://www.kroah.com/log/linux/maintainer-02.html>
866 819
867 <http://www.kroah.com/log/linux/maintainer-0 820 <http://www.kroah.com/log/linux/maintainer-03.html>
868 821
869 <http://www.kroah.com/log/linux/maintainer-0 822 <http://www.kroah.com/log/linux/maintainer-04.html>
870 823
871 <http://www.kroah.com/log/linux/maintainer-0 824 <http://www.kroah.com/log/linux/maintainer-05.html>
872 825
873 <http://www.kroah.com/log/linux/maintainer-0 826 <http://www.kroah.com/log/linux/maintainer-06.html>
>> 827
>> 828 NO!!!! No more huge patch bombs to linux-kernel@vger.kernel.org people!
>> 829 <https://lore.kernel.org/r/20050711.125305.08322243.davem@davemloft.net">https://lore.kernel.org/r/20050711.125305.08322243.davem@davemloft.net>
874 830
875 Kernel Documentation/process/coding-style.rst 831 Kernel Documentation/process/coding-style.rst
876 832
877 Linus Torvalds's mail on the canonical patch f 833 Linus Torvalds's mail on the canonical patch format:
878 <https://lore.kernel.org/r/Pine.LNX.4.58.0504 834 <https://lore.kernel.org/r/Pine.LNX.4.58.0504071023190.28951@ppc970.osdl.org">https://lore.kernel.org/r/Pine.LNX.4.58.0504071023190.28951@ppc970.osdl.org>
879 835
880 Andi Kleen, "On submitting kernel patches" 836 Andi Kleen, "On submitting kernel patches"
881 Some strategies to get difficult or controve 837 Some strategies to get difficult or controversial changes in.
882 838
883 http://halobates.de/on-submitting-patches.pd 839 http://halobates.de/on-submitting-patches.pdf
Linux® is a registered trademark of Linus Torvalds in the United States and other countries.
TOMOYO® is a registered trademark of NTT DATA CORPORATION.