1 .. SPDX-License-Identifier: GPL-2.0 1 .. SPDX-License-Identifier: GPL-2.0
2 2
3 ================= 3 =================
4 KVM Lock Overview 4 KVM Lock Overview
5 ================= 5 =================
6 6
7 1. Acquisition Orders 7 1. Acquisition Orders
8 --------------------- 8 ---------------------
9 9
10 The acquisition orders for mutexes are as foll 10 The acquisition orders for mutexes are as follows:
11 11
12 - cpus_read_lock() is taken outside kvm_lock <<
13 <<
14 - kvm_usage_lock is taken outside cpus_read_lo <<
15 <<
16 - kvm->lock is taken outside vcpu->mutex 12 - kvm->lock is taken outside vcpu->mutex
17 13
18 - kvm->lock is taken outside kvm->slots_lock a 14 - kvm->lock is taken outside kvm->slots_lock and kvm->irq_lock
19 15
20 - kvm->slots_lock is taken outside kvm->irq_lo 16 - kvm->slots_lock is taken outside kvm->irq_lock, though acquiring
21 them together is quite rare. 17 them together is quite rare.
22 18
23 - kvm->mn_active_invalidate_count ensures that !! 19 - Unlike kvm->slots_lock, kvm->slots_arch_lock is released before
24 invalidate_range_start() and invalidate_rang !! 20 synchronize_srcu(&kvm->srcu). Therefore kvm->slots_arch_lock
25 use the same memslots array. kvm->slots_loc !! 21 can be taken inside a kvm->srcu read-side critical section,
26 are taken on the waiting side when modifying !! 22 while kvm->slots_lock cannot.
27 must not take either kvm->slots_lock or kvm- <<
28 <<
29 cpus_read_lock() vs kvm_lock: <<
30 <<
31 - Taking cpus_read_lock() outside of kvm_lock <<
32 being the official ordering, as it is quite <<
33 cpus_read_lock() while holding kvm_lock. Us <<
34 e.g. avoid complex operations when possible. <<
35 <<
36 For SRCU: <<
37 <<
38 - ``synchronize_srcu(&kvm->srcu)`` is called i <<
39 for kvm->lock, vcpu->mutex and kvm->slots_lo <<
40 be taken inside a kvm->srcu read-side critic <<
41 following is broken:: <<
42 <<
43 srcu_read_lock(&kvm->srcu); <<
44 mutex_lock(&kvm->slots_lock); <<
45 <<
46 - kvm->slots_arch_lock instead is released bef <<
47 ``synchronize_srcu()``. It _can_ therefore <<
48 kvm->srcu read-side critical section, for ex <<
49 a vmexit. <<
50 23
51 On x86: 24 On x86:
52 25
53 - vcpu->mutex is taken outside kvm->arch.hyper !! 26 - vcpu->mutex is taken outside kvm->arch.hyperv.hv_lock
54 27
55 - kvm->arch.mmu_lock is an rwlock; critical se !! 28 - kvm->arch.mmu_lock is an rwlock. kvm->arch.tdp_mmu_pages_lock and
56 kvm->arch.tdp_mmu_pages_lock and kvm->arch.m !! 29 kvm->arch.mmu_unsync_pages_lock are taken inside kvm->arch.mmu_lock, and
57 also take kvm->arch.mmu_lock !! 30 cannot be taken without already holding kvm->arch.mmu_lock (typically with
>> 31 ``read_lock`` for the TDP MMU, thus the need for additional spinlocks).
58 32
59 Everything else is a leaf: no other lock is ta 33 Everything else is a leaf: no other lock is taken inside the critical
60 sections. 34 sections.
61 35
62 2. Exception 36 2. Exception
63 ------------ 37 ------------
64 38
65 Fast page fault: 39 Fast page fault:
66 40
67 Fast page fault is the fast path which fixes t 41 Fast page fault is the fast path which fixes the guest page fault out of
68 the mmu-lock on x86. Currently, the page fault 42 the mmu-lock on x86. Currently, the page fault can be fast in one of the
69 following two cases: 43 following two cases:
70 44
71 1. Access Tracking: The SPTE is not present, b 45 1. Access Tracking: The SPTE is not present, but it is marked for access
72 tracking. That means we need to restore the 46 tracking. That means we need to restore the saved R/X bits. This is
73 described in more detail later below. 47 described in more detail later below.
74 48
75 2. Write-Protection: The SPTE is present and t 49 2. Write-Protection: The SPTE is present and the fault is caused by
76 write-protect. That means we just need to c 50 write-protect. That means we just need to change the W bit of the spte.
77 51
78 What we use to avoid all the races is the Host !! 52 What we use to avoid all the race is the Host-writable bit and MMU-writable bit
79 on the spte: 53 on the spte:
80 54
81 - Host-writable means the gfn is writable in t 55 - Host-writable means the gfn is writable in the host kernel page tables and in
82 its KVM memslot. 56 its KVM memslot.
83 - MMU-writable means the gfn is writable in th 57 - MMU-writable means the gfn is writable in the guest's mmu and it is not
84 write-protected by shadow page write-protect 58 write-protected by shadow page write-protection.
85 59
86 On fast page fault path, we will use cmpxchg t 60 On fast page fault path, we will use cmpxchg to atomically set the spte W
87 bit if spte.HOST_WRITEABLE = 1 and spte.WRITE_ 61 bit if spte.HOST_WRITEABLE = 1 and spte.WRITE_PROTECT = 1, to restore the saved
88 R/X bits if for an access-traced spte, or both 62 R/X bits if for an access-traced spte, or both. This is safe because whenever
89 changing these bits can be detected by cmpxchg 63 changing these bits can be detected by cmpxchg.
90 64
91 But we need carefully check these cases: 65 But we need carefully check these cases:
92 66
93 1) The mapping from gfn to pfn 67 1) The mapping from gfn to pfn
94 68
95 The mapping from gfn to pfn may be changed sin 69 The mapping from gfn to pfn may be changed since we can only ensure the pfn
96 is not changed during cmpxchg. This is a ABA p 70 is not changed during cmpxchg. This is a ABA problem, for example, below case
97 will happen: 71 will happen:
98 72
99 +--------------------------------------------- 73 +------------------------------------------------------------------------+
100 | At the beginning:: 74 | At the beginning:: |
101 | 75 | |
102 | gpte = gfn1 76 | gpte = gfn1 |
103 | gfn1 is mapped to pfn1 on host 77 | gfn1 is mapped to pfn1 on host |
104 | spte is the shadow page table entry co 78 | spte is the shadow page table entry corresponding with gpte and |
105 | spte = pfn1 79 | spte = pfn1 |
106 +--------------------------------------------- 80 +------------------------------------------------------------------------+
107 | On fast page fault path: 81 | On fast page fault path: |
108 +------------------------------------+-------- 82 +------------------------------------+-----------------------------------+
109 | CPU 0: | CPU 1: 83 | CPU 0: | CPU 1: |
110 +------------------------------------+-------- 84 +------------------------------------+-----------------------------------+
111 | :: | 85 | :: | |
112 | | 86 | | |
113 | old_spte = *spte; | 87 | old_spte = *spte; | |
114 +------------------------------------+-------- 88 +------------------------------------+-----------------------------------+
115 | | pfn1 is 89 | | pfn1 is swapped out:: |
116 | | 90 | | |
117 | | spte 91 | | spte = 0; |
118 | | 92 | | |
119 | | pfn1 is 93 | | pfn1 is re-alloced for gfn2. |
120 | | 94 | | |
121 | | gpte is 95 | | gpte is changed to point to |
122 | | gfn2 by 96 | | gfn2 by the guest:: |
123 | | 97 | | |
124 | | spte 98 | | spte = pfn1; |
125 +------------------------------------+-------- 99 +------------------------------------+-----------------------------------+
126 | :: 100 | :: |
127 | 101 | |
128 | if (cmpxchg(spte, old_spte, old_spte+W) 102 | if (cmpxchg(spte, old_spte, old_spte+W) |
129 | mark_page_dirty(vcpu->kvm, gfn1) 103 | mark_page_dirty(vcpu->kvm, gfn1) |
130 | OOPS!!! 104 | OOPS!!! |
131 +--------------------------------------------- 105 +------------------------------------------------------------------------+
132 106
133 We dirty-log for gfn1, that means gfn2 is lost 107 We dirty-log for gfn1, that means gfn2 is lost in dirty-bitmap.
134 108
135 For direct sp, we can easily avoid it since th 109 For direct sp, we can easily avoid it since the spte of direct sp is fixed
136 to gfn. For indirect sp, we disabled fast pag 110 to gfn. For indirect sp, we disabled fast page fault for simplicity.
137 111
138 A solution for indirect sp could be to pin the 112 A solution for indirect sp could be to pin the gfn, for example via
139 gfn_to_pfn_memslot_atomic, before the cmpxchg. !! 113 kvm_vcpu_gfn_to_pfn_atomic, before the cmpxchg. After the pinning:
140 114
141 - We have held the refcount of pfn; that means !! 115 - We have held the refcount of pfn that means the pfn can not be freed and
142 be reused for another gfn. 116 be reused for another gfn.
143 - The pfn is writable and therefore it cannot 117 - The pfn is writable and therefore it cannot be shared between different gfns
144 by KSM. 118 by KSM.
145 119
146 Then, we can ensure the dirty bitmaps is corre 120 Then, we can ensure the dirty bitmaps is correctly set for a gfn.
147 121
148 2) Dirty bit tracking 122 2) Dirty bit tracking
149 123
150 In the origin code, the spte can be fast updat 124 In the origin code, the spte can be fast updated (non-atomically) if the
151 spte is read-only and the Accessed bit has alr 125 spte is read-only and the Accessed bit has already been set since the
152 Accessed bit and Dirty bit can not be lost. 126 Accessed bit and Dirty bit can not be lost.
153 127
154 But it is not true after fast page fault since 128 But it is not true after fast page fault since the spte can be marked
155 writable between reading spte and updating spt 129 writable between reading spte and updating spte. Like below case:
156 130
157 +--------------------------------------------- 131 +------------------------------------------------------------------------+
158 | At the beginning:: 132 | At the beginning:: |
159 | 133 | |
160 | spte.W = 0 134 | spte.W = 0 |
161 | spte.Accessed = 1 135 | spte.Accessed = 1 |
162 +------------------------------------+-------- 136 +------------------------------------+-----------------------------------+
163 | CPU 0: | CPU 1: 137 | CPU 0: | CPU 1: |
164 +------------------------------------+-------- 138 +------------------------------------+-----------------------------------+
165 | In mmu_spte_clear_track_bits():: | 139 | In mmu_spte_clear_track_bits():: | |
166 | | 140 | | |
167 | old_spte = *spte; | 141 | old_spte = *spte; | |
168 | | 142 | | |
169 | | 143 | | |
170 | /* 'if' condition is satisfied. */| 144 | /* 'if' condition is satisfied. */| |
171 | if (old_spte.Accessed == 1 && | 145 | if (old_spte.Accessed == 1 && | |
172 | old_spte.W == 0) | 146 | old_spte.W == 0) | |
173 | spte = 0ull; | 147 | spte = 0ull; | |
174 +------------------------------------+-------- 148 +------------------------------------+-----------------------------------+
175 | | on fast 149 | | on fast page fault path:: |
176 | | 150 | | |
177 | | spte 151 | | spte.W = 1 |
178 | | 152 | | |
179 | | memory 153 | | memory write on the spte:: |
180 | | 154 | | |
181 | | spte 155 | | spte.Dirty = 1 |
182 +------------------------------------+-------- 156 +------------------------------------+-----------------------------------+
183 | :: | 157 | :: | |
184 | | 158 | | |
185 | else | 159 | else | |
186 | old_spte = xchg(spte, 0ull) | 160 | old_spte = xchg(spte, 0ull) | |
187 | if (old_spte.Accessed == 1) | 161 | if (old_spte.Accessed == 1) | |
188 | kvm_set_pfn_accessed(spte.pfn);| 162 | kvm_set_pfn_accessed(spte.pfn);| |
189 | if (old_spte.Dirty == 1) | 163 | if (old_spte.Dirty == 1) | |
190 | kvm_set_pfn_dirty(spte.pfn); | 164 | kvm_set_pfn_dirty(spte.pfn); | |
191 | OOPS!!! | 165 | OOPS!!! | |
192 +------------------------------------+-------- 166 +------------------------------------+-----------------------------------+
193 167
194 The Dirty bit is lost in this case. 168 The Dirty bit is lost in this case.
195 169
196 In order to avoid this kind of issue, we alway 170 In order to avoid this kind of issue, we always treat the spte as "volatile"
197 if it can be updated out of mmu-lock [see spte !! 171 if it can be updated out of mmu-lock, see spte_has_volatile_bits(), it means,
198 the spte is always atomically updated in this 172 the spte is always atomically updated in this case.
199 173
200 3) flush tlbs due to spte updated 174 3) flush tlbs due to spte updated
201 175
202 If the spte is updated from writable to read-o !! 176 If the spte is updated from writable to readonly, we should flush all TLBs,
203 otherwise rmap_write_protect will find a read- 177 otherwise rmap_write_protect will find a read-only spte, even though the
204 writable spte might be cached on a CPU's TLB. 178 writable spte might be cached on a CPU's TLB.
205 179
206 As mentioned before, the spte can be updated t 180 As mentioned before, the spte can be updated to writable out of mmu-lock on
207 fast page fault path. In order to easily audit !! 181 fast page fault path, in order to easily audit the path, we see if TLBs need
208 to be flushed caused this reason in mmu_spte_u !! 182 be flushed caused by this reason in mmu_spte_update() since this is a common
209 function to update spte (present -> present). 183 function to update spte (present -> present).
210 184
211 Since the spte is "volatile" if it can be upda 185 Since the spte is "volatile" if it can be updated out of mmu-lock, we always
212 atomically update the spte and the race caused !! 186 atomically update the spte, the race caused by fast page fault can be avoided,
213 See the comments in spte_has_volatile_bits() a 187 See the comments in spte_has_volatile_bits() and mmu_spte_update().
214 188
215 Lockless Access Tracking: 189 Lockless Access Tracking:
216 190
217 This is used for Intel CPUs that are using EPT 191 This is used for Intel CPUs that are using EPT but do not support the EPT A/D
218 bits. In this case, PTEs are tagged as A/D dis 192 bits. In this case, PTEs are tagged as A/D disabled (using ignored bits), and
219 when the KVM MMU notifier is called to track a 193 when the KVM MMU notifier is called to track accesses to a page (via
220 kvm_mmu_notifier_clear_flush_young), it marks 194 kvm_mmu_notifier_clear_flush_young), it marks the PTE not-present in hardware
221 by clearing the RWX bits in the PTE and storin 195 by clearing the RWX bits in the PTE and storing the original R & X bits in more
222 unused/ignored bits. When the VM tries to acce 196 unused/ignored bits. When the VM tries to access the page later on, a fault is
223 generated and the fast page fault mechanism de 197 generated and the fast page fault mechanism described above is used to
224 atomically restore the PTE to a Present state. 198 atomically restore the PTE to a Present state. The W bit is not saved when the
225 PTE is marked for access tracking and during r 199 PTE is marked for access tracking and during restoration to the Present state,
226 the W bit is set depending on whether or not i 200 the W bit is set depending on whether or not it was a write access. If it
227 wasn't, then the W bit will remain clear until 201 wasn't, then the W bit will remain clear until a write access happens, at which
228 time it will be set using the Dirty tracking m 202 time it will be set using the Dirty tracking mechanism described above.
229 203
230 3. Reference 204 3. Reference
231 ------------ 205 ------------
232 206
233 ``kvm_lock`` !! 207 :Name: kvm_lock
234 ^^^^^^^^^^^^ <<
235 <<
236 :Type: mutex 208 :Type: mutex
237 :Arch: any 209 :Arch: any
238 :Protects: - vm_list 210 :Protects: - vm_list
239 211
240 ``kvm_usage_lock`` !! 212 :Name: kvm_count_lock
241 ^^^^^^^^^^^^^^^^^^ !! 213 :Type: raw_spinlock_t
242 <<
243 :Type: mutex <<
244 :Arch: any 214 :Arch: any
245 :Protects: - kvm_usage_count !! 215 :Protects: - hardware virtualization enable/disable
246 - hardware virtualization enab !! 216 :Comment: 'raw' because hardware enabling/disabling must be atomic /wrt
247 :Comment: Exists to allow taking cpus_re !! 217 migration.
248 protected, which simplifies th <<
249 <<
250 ``kvm->mn_invalidate_lock`` <<
251 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ <<
252 <<
253 :Type: spinlock_t <<
254 :Arch: any <<
255 :Protects: mn_active_invalidate_count, mn <<
256 <<
257 ``kvm_arch::tsc_write_lock`` <<
258 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ <<
259 218
260 :Type: raw_spinlock_t !! 219 :Name: kvm_arch::tsc_write_lock
>> 220 :Type: raw_spinlock
261 :Arch: x86 221 :Arch: x86
262 :Protects: - kvm_arch::{last_tsc_write,la 222 :Protects: - kvm_arch::{last_tsc_write,last_tsc_nsec,last_tsc_offset}
263 - tsc offset in vmcb 223 - tsc offset in vmcb
264 :Comment: 'raw' because updating the tsc 224 :Comment: 'raw' because updating the tsc offsets must not be preempted.
265 225
266 ``kvm->mmu_lock`` !! 226 :Name: kvm->mmu_lock
267 ^^^^^^^^^^^^^^^^^ !! 227 :Type: spinlock_t
268 :Type: spinlock_t or rwlock_t <<
269 :Arch: any 228 :Arch: any
270 :Protects: -shadow page/shadow tlb entry 229 :Protects: -shadow page/shadow tlb entry
271 :Comment: it is a spinlock since it is u 230 :Comment: it is a spinlock since it is used in mmu notifier.
272 231
273 ``kvm->srcu`` !! 232 :Name: kvm->srcu
274 ^^^^^^^^^^^^^ <<
275 :Type: srcu lock 233 :Type: srcu lock
276 :Arch: any 234 :Arch: any
277 :Protects: - kvm->memslots 235 :Protects: - kvm->memslots
278 - kvm->buses 236 - kvm->buses
279 :Comment: The srcu read lock must be hel 237 :Comment: The srcu read lock must be held while accessing memslots (e.g.
280 when using gfn_to_* functions) 238 when using gfn_to_* functions) and while accessing in-kernel
281 MMIO/PIO address->device struc 239 MMIO/PIO address->device structure mapping (kvm->buses).
282 The srcu index can be stored i 240 The srcu index can be stored in kvm_vcpu->srcu_idx per vcpu
283 if it is needed by multiple fu 241 if it is needed by multiple functions.
284 242
285 ``kvm->slots_arch_lock`` !! 243 :Name: blocked_vcpu_on_cpu_lock
286 ^^^^^^^^^^^^^^^^^^^^^^^^ <<
287 :Type: mutex <<
288 :Arch: any (only needed on x86 though <<
289 :Protects: any arch-specific fields of me <<
290 in a ``kvm->srcu`` read-side c <<
291 :Comment: must be held before reading th <<
292 until after all changes to the <<
293 <<
294 ``wakeup_vcpus_on_cpu_lock`` <<
295 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ <<
296 :Type: spinlock_t 244 :Type: spinlock_t
297 :Arch: x86 245 :Arch: x86
298 :Protects: wakeup_vcpus_on_cpu !! 246 :Protects: blocked_vcpu_on_cpu
299 :Comment: This is a per-CPU lock and it 247 :Comment: This is a per-CPU lock and it is used for VT-d posted-interrupts.
300 When VT-d posted-interrupts ar !! 248 When VT-d posted-interrupts is supported and the VM has assigned
301 devices, we put the blocked vC 249 devices, we put the blocked vCPU on the list blocked_vcpu_on_cpu
302 protected by blocked_vcpu_on_c !! 250 protected by blocked_vcpu_on_cpu_lock, when VT-d hardware issues
303 wakeup notification event sinc 251 wakeup notification event since external interrupts from the
304 assigned devices happens, we w 252 assigned devices happens, we will find the vCPU on the list to
305 wakeup. 253 wakeup.
306 <<
307 ``vendor_module_lock`` <<
308 ^^^^^^^^^^^^^^^^^^^^^^ <<
309 :Type: mutex <<
310 :Arch: x86 <<
311 :Protects: loading a vendor module (kvm_a <<
312 :Comment: Exists because using kvm_lock <<
313 in notifiers, e.g. __kvmclock_cpufreq_noti <<
314 cpu_hotplug_lock is held, e.g. from cpufre <<
315 operations need to take cpu_hotplug_lock w <<
316 updating static calls. <<
Linux® is a registered trademark of Linus Torvalds in the United States and other countries.
TOMOYO® is a registered trademark of NTT DATA CORPORATION.