1 .. SPDX-License-Identifier: GPL-2.0 1 .. SPDX-License-Identifier: GPL-2.0
2 2
3 ================= 3 =================
4 KVM Lock Overview 4 KVM Lock Overview
5 ================= 5 =================
6 6
7 1. Acquisition Orders 7 1. Acquisition Orders
8 --------------------- 8 ---------------------
9 9
10 The acquisition orders for mutexes are as foll 10 The acquisition orders for mutexes are as follows:
11 11
12 - cpus_read_lock() is taken outside kvm_lock <<
13 <<
14 - kvm_usage_lock is taken outside cpus_read_lo <<
15 <<
16 - kvm->lock is taken outside vcpu->mutex 12 - kvm->lock is taken outside vcpu->mutex
17 13
18 - kvm->lock is taken outside kvm->slots_lock a 14 - kvm->lock is taken outside kvm->slots_lock and kvm->irq_lock
19 15
20 - kvm->slots_lock is taken outside kvm->irq_lo 16 - kvm->slots_lock is taken outside kvm->irq_lock, though acquiring
21 them together is quite rare. 17 them together is quite rare.
22 18
>> 19 - Unlike kvm->slots_lock, kvm->slots_arch_lock is released before
>> 20 synchronize_srcu(&kvm->srcu). Therefore kvm->slots_arch_lock
>> 21 can be taken inside a kvm->srcu read-side critical section,
>> 22 while kvm->slots_lock cannot.
>> 23
23 - kvm->mn_active_invalidate_count ensures that 24 - kvm->mn_active_invalidate_count ensures that pairs of
24 invalidate_range_start() and invalidate_rang 25 invalidate_range_start() and invalidate_range_end() callbacks
25 use the same memslots array. kvm->slots_loc 26 use the same memslots array. kvm->slots_lock and kvm->slots_arch_lock
26 are taken on the waiting side when modifying !! 27 are taken on the waiting side in install_new_memslots, so MMU notifiers
27 must not take either kvm->slots_lock or kvm- 28 must not take either kvm->slots_lock or kvm->slots_arch_lock.
28 29
29 cpus_read_lock() vs kvm_lock: <<
30 <<
31 - Taking cpus_read_lock() outside of kvm_lock <<
32 being the official ordering, as it is quite <<
33 cpus_read_lock() while holding kvm_lock. Us <<
34 e.g. avoid complex operations when possible. <<
35 <<
36 For SRCU: <<
37 <<
38 - ``synchronize_srcu(&kvm->srcu)`` is called i <<
39 for kvm->lock, vcpu->mutex and kvm->slots_lo <<
40 be taken inside a kvm->srcu read-side critic <<
41 following is broken:: <<
42 <<
43 srcu_read_lock(&kvm->srcu); <<
44 mutex_lock(&kvm->slots_lock); <<
45 <<
46 - kvm->slots_arch_lock instead is released bef <<
47 ``synchronize_srcu()``. It _can_ therefore <<
48 kvm->srcu read-side critical section, for ex <<
49 a vmexit. <<
50 <<
51 On x86: 30 On x86:
52 31
53 - vcpu->mutex is taken outside kvm->arch.hyper !! 32 - vcpu->mutex is taken outside kvm->arch.hyperv.hv_lock
54 33
55 - kvm->arch.mmu_lock is an rwlock; critical se !! 34 - kvm->arch.mmu_lock is an rwlock. kvm->arch.tdp_mmu_pages_lock and
56 kvm->arch.tdp_mmu_pages_lock and kvm->arch.m !! 35 kvm->arch.mmu_unsync_pages_lock are taken inside kvm->arch.mmu_lock, and
57 also take kvm->arch.mmu_lock !! 36 cannot be taken without already holding kvm->arch.mmu_lock (typically with
>> 37 ``read_lock`` for the TDP MMU, thus the need for additional spinlocks).
58 38
59 Everything else is a leaf: no other lock is ta 39 Everything else is a leaf: no other lock is taken inside the critical
60 sections. 40 sections.
61 41
62 2. Exception 42 2. Exception
63 ------------ 43 ------------
64 44
65 Fast page fault: 45 Fast page fault:
66 46
67 Fast page fault is the fast path which fixes t 47 Fast page fault is the fast path which fixes the guest page fault out of
68 the mmu-lock on x86. Currently, the page fault 48 the mmu-lock on x86. Currently, the page fault can be fast in one of the
69 following two cases: 49 following two cases:
70 50
71 1. Access Tracking: The SPTE is not present, b 51 1. Access Tracking: The SPTE is not present, but it is marked for access
72 tracking. That means we need to restore the 52 tracking. That means we need to restore the saved R/X bits. This is
73 described in more detail later below. 53 described in more detail later below.
74 54
75 2. Write-Protection: The SPTE is present and t 55 2. Write-Protection: The SPTE is present and the fault is caused by
76 write-protect. That means we just need to c 56 write-protect. That means we just need to change the W bit of the spte.
77 57
78 What we use to avoid all the races is the Host !! 58 What we use to avoid all the race is the Host-writable bit and MMU-writable bit
79 on the spte: 59 on the spte:
80 60
81 - Host-writable means the gfn is writable in t 61 - Host-writable means the gfn is writable in the host kernel page tables and in
82 its KVM memslot. 62 its KVM memslot.
83 - MMU-writable means the gfn is writable in th 63 - MMU-writable means the gfn is writable in the guest's mmu and it is not
84 write-protected by shadow page write-protect 64 write-protected by shadow page write-protection.
85 65
86 On fast page fault path, we will use cmpxchg t 66 On fast page fault path, we will use cmpxchg to atomically set the spte W
87 bit if spte.HOST_WRITEABLE = 1 and spte.WRITE_ 67 bit if spte.HOST_WRITEABLE = 1 and spte.WRITE_PROTECT = 1, to restore the saved
88 R/X bits if for an access-traced spte, or both 68 R/X bits if for an access-traced spte, or both. This is safe because whenever
89 changing these bits can be detected by cmpxchg 69 changing these bits can be detected by cmpxchg.
90 70
91 But we need carefully check these cases: 71 But we need carefully check these cases:
92 72
93 1) The mapping from gfn to pfn 73 1) The mapping from gfn to pfn
94 74
95 The mapping from gfn to pfn may be changed sin 75 The mapping from gfn to pfn may be changed since we can only ensure the pfn
96 is not changed during cmpxchg. This is a ABA p 76 is not changed during cmpxchg. This is a ABA problem, for example, below case
97 will happen: 77 will happen:
98 78
99 +--------------------------------------------- 79 +------------------------------------------------------------------------+
100 | At the beginning:: 80 | At the beginning:: |
101 | 81 | |
102 | gpte = gfn1 82 | gpte = gfn1 |
103 | gfn1 is mapped to pfn1 on host 83 | gfn1 is mapped to pfn1 on host |
104 | spte is the shadow page table entry co 84 | spte is the shadow page table entry corresponding with gpte and |
105 | spte = pfn1 85 | spte = pfn1 |
106 +--------------------------------------------- 86 +------------------------------------------------------------------------+
107 | On fast page fault path: 87 | On fast page fault path: |
108 +------------------------------------+-------- 88 +------------------------------------+-----------------------------------+
109 | CPU 0: | CPU 1: 89 | CPU 0: | CPU 1: |
110 +------------------------------------+-------- 90 +------------------------------------+-----------------------------------+
111 | :: | 91 | :: | |
112 | | 92 | | |
113 | old_spte = *spte; | 93 | old_spte = *spte; | |
114 +------------------------------------+-------- 94 +------------------------------------+-----------------------------------+
115 | | pfn1 is 95 | | pfn1 is swapped out:: |
116 | | 96 | | |
117 | | spte 97 | | spte = 0; |
118 | | 98 | | |
119 | | pfn1 is 99 | | pfn1 is re-alloced for gfn2. |
120 | | 100 | | |
121 | | gpte is 101 | | gpte is changed to point to |
122 | | gfn2 by 102 | | gfn2 by the guest:: |
123 | | 103 | | |
124 | | spte 104 | | spte = pfn1; |
125 +------------------------------------+-------- 105 +------------------------------------+-----------------------------------+
126 | :: 106 | :: |
127 | 107 | |
128 | if (cmpxchg(spte, old_spte, old_spte+W) 108 | if (cmpxchg(spte, old_spte, old_spte+W) |
129 | mark_page_dirty(vcpu->kvm, gfn1) 109 | mark_page_dirty(vcpu->kvm, gfn1) |
130 | OOPS!!! 110 | OOPS!!! |
131 +--------------------------------------------- 111 +------------------------------------------------------------------------+
132 112
133 We dirty-log for gfn1, that means gfn2 is lost 113 We dirty-log for gfn1, that means gfn2 is lost in dirty-bitmap.
134 114
135 For direct sp, we can easily avoid it since th 115 For direct sp, we can easily avoid it since the spte of direct sp is fixed
136 to gfn. For indirect sp, we disabled fast pag 116 to gfn. For indirect sp, we disabled fast page fault for simplicity.
137 117
138 A solution for indirect sp could be to pin the 118 A solution for indirect sp could be to pin the gfn, for example via
139 gfn_to_pfn_memslot_atomic, before the cmpxchg. !! 119 kvm_vcpu_gfn_to_pfn_atomic, before the cmpxchg. After the pinning:
140 120
141 - We have held the refcount of pfn; that means !! 121 - We have held the refcount of pfn that means the pfn can not be freed and
142 be reused for another gfn. 122 be reused for another gfn.
143 - The pfn is writable and therefore it cannot 123 - The pfn is writable and therefore it cannot be shared between different gfns
144 by KSM. 124 by KSM.
145 125
146 Then, we can ensure the dirty bitmaps is corre 126 Then, we can ensure the dirty bitmaps is correctly set for a gfn.
147 127
148 2) Dirty bit tracking 128 2) Dirty bit tracking
149 129
150 In the origin code, the spte can be fast updat 130 In the origin code, the spte can be fast updated (non-atomically) if the
151 spte is read-only and the Accessed bit has alr 131 spte is read-only and the Accessed bit has already been set since the
152 Accessed bit and Dirty bit can not be lost. 132 Accessed bit and Dirty bit can not be lost.
153 133
154 But it is not true after fast page fault since 134 But it is not true after fast page fault since the spte can be marked
155 writable between reading spte and updating spt 135 writable between reading spte and updating spte. Like below case:
156 136
157 +--------------------------------------------- 137 +------------------------------------------------------------------------+
158 | At the beginning:: 138 | At the beginning:: |
159 | 139 | |
160 | spte.W = 0 140 | spte.W = 0 |
161 | spte.Accessed = 1 141 | spte.Accessed = 1 |
162 +------------------------------------+-------- 142 +------------------------------------+-----------------------------------+
163 | CPU 0: | CPU 1: 143 | CPU 0: | CPU 1: |
164 +------------------------------------+-------- 144 +------------------------------------+-----------------------------------+
165 | In mmu_spte_clear_track_bits():: | 145 | In mmu_spte_clear_track_bits():: | |
166 | | 146 | | |
167 | old_spte = *spte; | 147 | old_spte = *spte; | |
168 | | 148 | | |
169 | | 149 | | |
170 | /* 'if' condition is satisfied. */| 150 | /* 'if' condition is satisfied. */| |
171 | if (old_spte.Accessed == 1 && | 151 | if (old_spte.Accessed == 1 && | |
172 | old_spte.W == 0) | 152 | old_spte.W == 0) | |
173 | spte = 0ull; | 153 | spte = 0ull; | |
174 +------------------------------------+-------- 154 +------------------------------------+-----------------------------------+
175 | | on fast 155 | | on fast page fault path:: |
176 | | 156 | | |
177 | | spte 157 | | spte.W = 1 |
178 | | 158 | | |
179 | | memory 159 | | memory write on the spte:: |
180 | | 160 | | |
181 | | spte 161 | | spte.Dirty = 1 |
182 +------------------------------------+-------- 162 +------------------------------------+-----------------------------------+
183 | :: | 163 | :: | |
184 | | 164 | | |
185 | else | 165 | else | |
186 | old_spte = xchg(spte, 0ull) | 166 | old_spte = xchg(spte, 0ull) | |
187 | if (old_spte.Accessed == 1) | 167 | if (old_spte.Accessed == 1) | |
188 | kvm_set_pfn_accessed(spte.pfn);| 168 | kvm_set_pfn_accessed(spte.pfn);| |
189 | if (old_spte.Dirty == 1) | 169 | if (old_spte.Dirty == 1) | |
190 | kvm_set_pfn_dirty(spte.pfn); | 170 | kvm_set_pfn_dirty(spte.pfn); | |
191 | OOPS!!! | 171 | OOPS!!! | |
192 +------------------------------------+-------- 172 +------------------------------------+-----------------------------------+
193 173
194 The Dirty bit is lost in this case. 174 The Dirty bit is lost in this case.
195 175
196 In order to avoid this kind of issue, we alway 176 In order to avoid this kind of issue, we always treat the spte as "volatile"
197 if it can be updated out of mmu-lock [see spte !! 177 if it can be updated out of mmu-lock, see spte_has_volatile_bits(), it means,
198 the spte is always atomically updated in this 178 the spte is always atomically updated in this case.
199 179
200 3) flush tlbs due to spte updated 180 3) flush tlbs due to spte updated
201 181
202 If the spte is updated from writable to read-o !! 182 If the spte is updated from writable to readonly, we should flush all TLBs,
203 otherwise rmap_write_protect will find a read- 183 otherwise rmap_write_protect will find a read-only spte, even though the
204 writable spte might be cached on a CPU's TLB. 184 writable spte might be cached on a CPU's TLB.
205 185
206 As mentioned before, the spte can be updated t 186 As mentioned before, the spte can be updated to writable out of mmu-lock on
207 fast page fault path. In order to easily audit !! 187 fast page fault path, in order to easily audit the path, we see if TLBs need
208 to be flushed caused this reason in mmu_spte_u !! 188 be flushed caused by this reason in mmu_spte_update() since this is a common
209 function to update spte (present -> present). 189 function to update spte (present -> present).
210 190
211 Since the spte is "volatile" if it can be upda 191 Since the spte is "volatile" if it can be updated out of mmu-lock, we always
212 atomically update the spte and the race caused !! 192 atomically update the spte, the race caused by fast page fault can be avoided,
213 See the comments in spte_has_volatile_bits() a 193 See the comments in spte_has_volatile_bits() and mmu_spte_update().
214 194
215 Lockless Access Tracking: 195 Lockless Access Tracking:
216 196
217 This is used for Intel CPUs that are using EPT 197 This is used for Intel CPUs that are using EPT but do not support the EPT A/D
218 bits. In this case, PTEs are tagged as A/D dis 198 bits. In this case, PTEs are tagged as A/D disabled (using ignored bits), and
219 when the KVM MMU notifier is called to track a 199 when the KVM MMU notifier is called to track accesses to a page (via
220 kvm_mmu_notifier_clear_flush_young), it marks 200 kvm_mmu_notifier_clear_flush_young), it marks the PTE not-present in hardware
221 by clearing the RWX bits in the PTE and storin 201 by clearing the RWX bits in the PTE and storing the original R & X bits in more
222 unused/ignored bits. When the VM tries to acce 202 unused/ignored bits. When the VM tries to access the page later on, a fault is
223 generated and the fast page fault mechanism de 203 generated and the fast page fault mechanism described above is used to
224 atomically restore the PTE to a Present state. 204 atomically restore the PTE to a Present state. The W bit is not saved when the
225 PTE is marked for access tracking and during r 205 PTE is marked for access tracking and during restoration to the Present state,
226 the W bit is set depending on whether or not i 206 the W bit is set depending on whether or not it was a write access. If it
227 wasn't, then the W bit will remain clear until 207 wasn't, then the W bit will remain clear until a write access happens, at which
228 time it will be set using the Dirty tracking m 208 time it will be set using the Dirty tracking mechanism described above.
229 209
230 3. Reference 210 3. Reference
231 ------------ 211 ------------
232 212
233 ``kvm_lock`` 213 ``kvm_lock``
234 ^^^^^^^^^^^^ 214 ^^^^^^^^^^^^
235 215
236 :Type: mutex 216 :Type: mutex
237 :Arch: any 217 :Arch: any
238 :Protects: - vm_list 218 :Protects: - vm_list
239 219
240 ``kvm_usage_lock`` !! 220 ``kvm_count_lock``
241 ^^^^^^^^^^^^^^^^^^ 221 ^^^^^^^^^^^^^^^^^^
242 222
243 :Type: mutex !! 223 :Type: raw_spinlock_t
244 :Arch: any 224 :Arch: any
245 :Protects: - kvm_usage_count !! 225 :Protects: - hardware virtualization enable/disable
246 - hardware virtualization enab !! 226 :Comment: 'raw' because hardware enabling/disabling must be atomic /wrt
247 :Comment: Exists to allow taking cpus_re !! 227 migration.
248 protected, which simplifies th <<
249 228
250 ``kvm->mn_invalidate_lock`` 229 ``kvm->mn_invalidate_lock``
251 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ 230 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
252 231
253 :Type: spinlock_t 232 :Type: spinlock_t
254 :Arch: any 233 :Arch: any
255 :Protects: mn_active_invalidate_count, mn 234 :Protects: mn_active_invalidate_count, mn_memslots_update_rcuwait
256 235
257 ``kvm_arch::tsc_write_lock`` 236 ``kvm_arch::tsc_write_lock``
258 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 237 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
259 238
260 :Type: raw_spinlock_t 239 :Type: raw_spinlock_t
261 :Arch: x86 240 :Arch: x86
262 :Protects: - kvm_arch::{last_tsc_write,la 241 :Protects: - kvm_arch::{last_tsc_write,last_tsc_nsec,last_tsc_offset}
263 - tsc offset in vmcb 242 - tsc offset in vmcb
264 :Comment: 'raw' because updating the tsc 243 :Comment: 'raw' because updating the tsc offsets must not be preempted.
265 244
266 ``kvm->mmu_lock`` 245 ``kvm->mmu_lock``
267 ^^^^^^^^^^^^^^^^^ 246 ^^^^^^^^^^^^^^^^^
268 :Type: spinlock_t or rwlock_t 247 :Type: spinlock_t or rwlock_t
269 :Arch: any 248 :Arch: any
270 :Protects: -shadow page/shadow tlb entry 249 :Protects: -shadow page/shadow tlb entry
271 :Comment: it is a spinlock since it is u 250 :Comment: it is a spinlock since it is used in mmu notifier.
272 251
273 ``kvm->srcu`` 252 ``kvm->srcu``
274 ^^^^^^^^^^^^^ 253 ^^^^^^^^^^^^^
275 :Type: srcu lock 254 :Type: srcu lock
276 :Arch: any 255 :Arch: any
277 :Protects: - kvm->memslots 256 :Protects: - kvm->memslots
278 - kvm->buses 257 - kvm->buses
279 :Comment: The srcu read lock must be hel 258 :Comment: The srcu read lock must be held while accessing memslots (e.g.
280 when using gfn_to_* functions) 259 when using gfn_to_* functions) and while accessing in-kernel
281 MMIO/PIO address->device struc 260 MMIO/PIO address->device structure mapping (kvm->buses).
282 The srcu index can be stored i 261 The srcu index can be stored in kvm_vcpu->srcu_idx per vcpu
283 if it is needed by multiple fu 262 if it is needed by multiple functions.
284 263
285 ``kvm->slots_arch_lock`` 264 ``kvm->slots_arch_lock``
286 ^^^^^^^^^^^^^^^^^^^^^^^^ 265 ^^^^^^^^^^^^^^^^^^^^^^^^
287 :Type: mutex 266 :Type: mutex
288 :Arch: any (only needed on x86 though 267 :Arch: any (only needed on x86 though)
289 :Protects: any arch-specific fields of me 268 :Protects: any arch-specific fields of memslots that have to be modified
290 in a ``kvm->srcu`` read-side c 269 in a ``kvm->srcu`` read-side critical section.
291 :Comment: must be held before reading th 270 :Comment: must be held before reading the pointer to the current memslots,
292 until after all changes to the 271 until after all changes to the memslots are complete
293 272
294 ``wakeup_vcpus_on_cpu_lock`` 273 ``wakeup_vcpus_on_cpu_lock``
295 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 274 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
296 :Type: spinlock_t 275 :Type: spinlock_t
297 :Arch: x86 276 :Arch: x86
298 :Protects: wakeup_vcpus_on_cpu 277 :Protects: wakeup_vcpus_on_cpu
299 :Comment: This is a per-CPU lock and it 278 :Comment: This is a per-CPU lock and it is used for VT-d posted-interrupts.
300 When VT-d posted-interrupts ar !! 279 When VT-d posted-interrupts is supported and the VM has assigned
301 devices, we put the blocked vC 280 devices, we put the blocked vCPU on the list blocked_vcpu_on_cpu
302 protected by blocked_vcpu_on_c !! 281 protected by blocked_vcpu_on_cpu_lock, when VT-d hardware issues
303 wakeup notification event sinc 282 wakeup notification event since external interrupts from the
304 assigned devices happens, we w 283 assigned devices happens, we will find the vCPU on the list to
305 wakeup. 284 wakeup.
306 <<
307 ``vendor_module_lock`` <<
308 ^^^^^^^^^^^^^^^^^^^^^^ <<
309 :Type: mutex <<
310 :Arch: x86 <<
311 :Protects: loading a vendor module (kvm_a <<
312 :Comment: Exists because using kvm_lock <<
313 in notifiers, e.g. __kvmclock_cpufreq_noti <<
314 cpu_hotplug_lock is held, e.g. from cpufre <<
315 operations need to take cpu_hotplug_lock w <<
316 updating static calls. <<
Linux® is a registered trademark of Linus Torvalds in the United States and other countries.
TOMOYO® is a registered trademark of NTT DATA CORPORATION.