1 // SPDX-License-Identifier: GPL-2.0-or-later 1 // SPDX-License-Identifier: GPL-2.0-or-later
2 /* Filesystem parameter parser. 2 /* Filesystem parameter parser.
3 * 3 *
4 * Copyright (C) 2018 Red Hat, Inc. All Rights 4 * Copyright (C) 2018 Red Hat, Inc. All Rights Reserved.
5 * Written by David Howells (dhowells@redhat.c 5 * Written by David Howells (dhowells@redhat.com)
6 */ 6 */
7 7
8 #include <linux/export.h> 8 #include <linux/export.h>
9 #include <linux/fs_context.h> 9 #include <linux/fs_context.h>
10 #include <linux/fs_parser.h> 10 #include <linux/fs_parser.h>
11 #include <linux/slab.h> 11 #include <linux/slab.h>
12 #include <linux/security.h> 12 #include <linux/security.h>
13 #include <linux/namei.h> 13 #include <linux/namei.h>
14 #include "internal.h" 14 #include "internal.h"
15 15
16 static const struct constant_table bool_names[ 16 static const struct constant_table bool_names[] = {
17 { "", false }, 17 { "", false },
18 { "1", true }, 18 { "1", true },
19 { "false", false }, 19 { "false", false },
20 { "no", false }, 20 { "no", false },
21 { "true", true }, 21 { "true", true },
22 { "yes", true }, 22 { "yes", true },
23 { }, 23 { },
24 }; 24 };
25 25
26 static const struct constant_table * 26 static const struct constant_table *
27 __lookup_constant(const struct constant_table 27 __lookup_constant(const struct constant_table *tbl, const char *name)
28 { 28 {
29 for ( ; tbl->name; tbl++) 29 for ( ; tbl->name; tbl++)
30 if (strcmp(name, tbl->name) == 30 if (strcmp(name, tbl->name) == 0)
31 return tbl; 31 return tbl;
32 return NULL; 32 return NULL;
33 } 33 }
34 34
35 /** 35 /**
36 * lookup_constant - Look up a constant by nam 36 * lookup_constant - Look up a constant by name in an ordered table
37 * @tbl: The table of constants to search. 37 * @tbl: The table of constants to search.
38 * @name: The name to look up. 38 * @name: The name to look up.
39 * @not_found: The value to return if the name 39 * @not_found: The value to return if the name is not found.
40 */ 40 */
41 int lookup_constant(const struct constant_tabl 41 int lookup_constant(const struct constant_table *tbl, const char *name, int not_found)
42 { 42 {
43 const struct constant_table *p = __loo 43 const struct constant_table *p = __lookup_constant(tbl, name);
44 44
45 return p ? p->value : not_found; 45 return p ? p->value : not_found;
46 } 46 }
47 EXPORT_SYMBOL(lookup_constant); 47 EXPORT_SYMBOL(lookup_constant);
48 48
49 static inline bool is_flag(const struct fs_par 49 static inline bool is_flag(const struct fs_parameter_spec *p)
50 { 50 {
51 return p->type == NULL; 51 return p->type == NULL;
52 } 52 }
53 53
54 static const struct fs_parameter_spec *fs_look 54 static const struct fs_parameter_spec *fs_lookup_key(
55 const struct fs_parameter_spec *desc, 55 const struct fs_parameter_spec *desc,
56 struct fs_parameter *param, bool *nega 56 struct fs_parameter *param, bool *negated)
57 { 57 {
58 const struct fs_parameter_spec *p, *ot 58 const struct fs_parameter_spec *p, *other = NULL;
59 const char *name = param->key; 59 const char *name = param->key;
60 bool want_flag = param->type == fs_val 60 bool want_flag = param->type == fs_value_is_flag;
61 61
62 *negated = false; 62 *negated = false;
63 for (p = desc; p->name; p++) { 63 for (p = desc; p->name; p++) {
64 if (strcmp(p->name, name) != 0 64 if (strcmp(p->name, name) != 0)
65 continue; 65 continue;
66 if (likely(is_flag(p) == want_ 66 if (likely(is_flag(p) == want_flag))
67 return p; 67 return p;
68 other = p; 68 other = p;
69 } 69 }
70 if (want_flag) { 70 if (want_flag) {
71 if (name[0] == 'n' && name[1] 71 if (name[0] == 'n' && name[1] == 'o' && name[2]) {
72 for (p = desc; p->name 72 for (p = desc; p->name; p++) {
73 if (strcmp(p-> 73 if (strcmp(p->name, name + 2) != 0)
74 contin 74 continue;
75 if (!(p->flags 75 if (!(p->flags & fs_param_neg_with_no))
76 contin 76 continue;
77 *negated = tru 77 *negated = true;
78 return p; 78 return p;
79 } 79 }
80 } 80 }
81 } 81 }
82 return other; 82 return other;
83 } 83 }
84 84
85 /* 85 /*
86 * __fs_parse - Parse a filesystem configurati !! 86 * fs_parse - Parse a filesystem configuration parameter
87 * @log: The filesystem context to log errors !! 87 * @fc: The filesystem context to log errors through.
88 * @desc: The parameter description to use. 88 * @desc: The parameter description to use.
89 * @param: The parameter. 89 * @param: The parameter.
90 * @result: Where to place the result of the p 90 * @result: Where to place the result of the parse
91 * 91 *
92 * Parse a filesystem configuration parameter 92 * Parse a filesystem configuration parameter and attempt a conversion for a
93 * simple parameter for which this is requeste 93 * simple parameter for which this is requested. If successful, the determined
94 * parameter ID is placed into @result->key, t 94 * parameter ID is placed into @result->key, the desired type is indicated in
95 * @result->t and any converted value is place 95 * @result->t and any converted value is placed into an appropriate member of
96 * the union in @result. 96 * the union in @result.
97 * 97 *
98 * The function returns the parameter number i 98 * The function returns the parameter number if the parameter was matched,
99 * -ENOPARAM if it wasn't matched and @desc->i 99 * -ENOPARAM if it wasn't matched and @desc->ignore_unknown indicated that
100 * unknown parameters are okay and -EINVAL if 100 * unknown parameters are okay and -EINVAL if there was a conversion issue or
101 * the parameter wasn't recognised and unknown 101 * the parameter wasn't recognised and unknowns aren't okay.
102 */ 102 */
103 int __fs_parse(struct p_log *log, 103 int __fs_parse(struct p_log *log,
104 const struct fs_parameter_spec *d 104 const struct fs_parameter_spec *desc,
105 struct fs_parameter *param, 105 struct fs_parameter *param,
106 struct fs_parse_result *result) 106 struct fs_parse_result *result)
107 { 107 {
108 const struct fs_parameter_spec *p; 108 const struct fs_parameter_spec *p;
109 109
110 result->uint_64 = 0; 110 result->uint_64 = 0;
111 111
112 p = fs_lookup_key(desc, param, &result 112 p = fs_lookup_key(desc, param, &result->negated);
113 if (!p) 113 if (!p)
114 return -ENOPARAM; 114 return -ENOPARAM;
115 115
116 if (p->flags & fs_param_deprecated) 116 if (p->flags & fs_param_deprecated)
117 warn_plog(log, "Deprecated par 117 warn_plog(log, "Deprecated parameter '%s'", param->key);
118 118
119 /* Try to turn the type we were given 119 /* Try to turn the type we were given into the type desired by the
120 * parameter and give an error if we c 120 * parameter and give an error if we can't.
121 */ 121 */
122 if (is_flag(p)) { 122 if (is_flag(p)) {
123 if (param->type != fs_value_is 123 if (param->type != fs_value_is_flag)
124 return inval_plog(log, 124 return inval_plog(log, "Unexpected value for '%s'",
125 param->k 125 param->key);
126 result->boolean = !result->neg 126 result->boolean = !result->negated;
127 } else { 127 } else {
128 int ret = p->type(log, p, para 128 int ret = p->type(log, p, param, result);
129 if (ret) 129 if (ret)
130 return ret; 130 return ret;
131 } 131 }
132 return p->opt; 132 return p->opt;
133 } 133 }
134 EXPORT_SYMBOL(__fs_parse); 134 EXPORT_SYMBOL(__fs_parse);
135 135
136 /** 136 /**
137 * fs_lookup_param - Look up a path referred t 137 * fs_lookup_param - Look up a path referred to by a parameter
138 * @fc: The filesystem context to log errors t 138 * @fc: The filesystem context to log errors through.
139 * @param: The parameter. 139 * @param: The parameter.
140 * @want_bdev: T if want a blockdev 140 * @want_bdev: T if want a blockdev
141 * @flags: Pathwalk flags passed to filename_l 141 * @flags: Pathwalk flags passed to filename_lookup()
142 * @_path: The result of the lookup 142 * @_path: The result of the lookup
143 */ 143 */
144 int fs_lookup_param(struct fs_context *fc, 144 int fs_lookup_param(struct fs_context *fc,
145 struct fs_parameter *param 145 struct fs_parameter *param,
146 bool want_bdev, 146 bool want_bdev,
147 unsigned int flags, 147 unsigned int flags,
148 struct path *_path) 148 struct path *_path)
149 { 149 {
150 struct filename *f; 150 struct filename *f;
151 bool put_f; 151 bool put_f;
152 int ret; 152 int ret;
153 153
154 switch (param->type) { 154 switch (param->type) {
155 case fs_value_is_string: 155 case fs_value_is_string:
156 f = getname_kernel(param->stri 156 f = getname_kernel(param->string);
157 if (IS_ERR(f)) 157 if (IS_ERR(f))
158 return PTR_ERR(f); 158 return PTR_ERR(f);
159 put_f = true; 159 put_f = true;
160 break; 160 break;
161 case fs_value_is_filename: 161 case fs_value_is_filename:
162 f = param->name; 162 f = param->name;
163 put_f = false; 163 put_f = false;
164 break; 164 break;
165 default: 165 default:
166 return invalf(fc, "%s: not usa 166 return invalf(fc, "%s: not usable as path", param->key);
167 } 167 }
168 168
169 ret = filename_lookup(param->dirfd, f, 169 ret = filename_lookup(param->dirfd, f, flags, _path, NULL);
170 if (ret < 0) { 170 if (ret < 0) {
171 errorf(fc, "%s: Lookup failure 171 errorf(fc, "%s: Lookup failure for '%s'", param->key, f->name);
172 goto out; 172 goto out;
173 } 173 }
174 174
175 if (want_bdev && 175 if (want_bdev &&
176 !S_ISBLK(d_backing_inode(_path->de 176 !S_ISBLK(d_backing_inode(_path->dentry)->i_mode)) {
177 path_put(_path); 177 path_put(_path);
178 _path->dentry = NULL; 178 _path->dentry = NULL;
179 _path->mnt = NULL; 179 _path->mnt = NULL;
180 errorf(fc, "%s: Non-blockdev p 180 errorf(fc, "%s: Non-blockdev passed as '%s'",
181 param->key, f->name); 181 param->key, f->name);
182 ret = -ENOTBLK; 182 ret = -ENOTBLK;
183 } 183 }
184 184
185 out: 185 out:
186 if (put_f) 186 if (put_f)
187 putname(f); 187 putname(f);
188 return ret; 188 return ret;
189 } 189 }
190 EXPORT_SYMBOL(fs_lookup_param); 190 EXPORT_SYMBOL(fs_lookup_param);
191 191
192 static int fs_param_bad_value(struct p_log *lo 192 static int fs_param_bad_value(struct p_log *log, struct fs_parameter *param)
193 { 193 {
194 return inval_plog(log, "Bad value for 194 return inval_plog(log, "Bad value for '%s'", param->key);
195 } 195 }
196 196
197 int fs_param_is_bool(struct p_log *log, const 197 int fs_param_is_bool(struct p_log *log, const struct fs_parameter_spec *p,
198 struct fs_parameter *para 198 struct fs_parameter *param, struct fs_parse_result *result)
199 { 199 {
200 int b; 200 int b;
201 if (param->type != fs_value_is_string) 201 if (param->type != fs_value_is_string)
202 return fs_param_bad_value(log, 202 return fs_param_bad_value(log, param);
203 if (!*param->string && (p->flags & fs_ 203 if (!*param->string && (p->flags & fs_param_can_be_empty))
204 return 0; 204 return 0;
205 b = lookup_constant(bool_names, param- 205 b = lookup_constant(bool_names, param->string, -1);
206 if (b == -1) 206 if (b == -1)
207 return fs_param_bad_value(log, 207 return fs_param_bad_value(log, param);
208 result->boolean = b; 208 result->boolean = b;
209 return 0; 209 return 0;
210 } 210 }
211 EXPORT_SYMBOL(fs_param_is_bool); 211 EXPORT_SYMBOL(fs_param_is_bool);
212 212
213 int fs_param_is_u32(struct p_log *log, const s 213 int fs_param_is_u32(struct p_log *log, const struct fs_parameter_spec *p,
214 struct fs_parameter *param 214 struct fs_parameter *param, struct fs_parse_result *result)
215 { 215 {
216 int base = (unsigned long)p->data; 216 int base = (unsigned long)p->data;
217 if (param->type != fs_value_is_string) 217 if (param->type != fs_value_is_string)
218 return fs_param_bad_value(log, 218 return fs_param_bad_value(log, param);
219 if (!*param->string && (p->flags & fs_ 219 if (!*param->string && (p->flags & fs_param_can_be_empty))
220 return 0; 220 return 0;
221 if (kstrtouint(param->string, base, &r 221 if (kstrtouint(param->string, base, &result->uint_32) < 0)
222 return fs_param_bad_value(log, 222 return fs_param_bad_value(log, param);
223 return 0; 223 return 0;
224 } 224 }
225 EXPORT_SYMBOL(fs_param_is_u32); 225 EXPORT_SYMBOL(fs_param_is_u32);
226 226
227 int fs_param_is_s32(struct p_log *log, const s 227 int fs_param_is_s32(struct p_log *log, const struct fs_parameter_spec *p,
228 struct fs_parameter *param 228 struct fs_parameter *param, struct fs_parse_result *result)
229 { 229 {
230 if (param->type != fs_value_is_string) 230 if (param->type != fs_value_is_string)
231 return fs_param_bad_value(log, 231 return fs_param_bad_value(log, param);
232 if (!*param->string && (p->flags & fs_ 232 if (!*param->string && (p->flags & fs_param_can_be_empty))
233 return 0; 233 return 0;
234 if (kstrtoint(param->string, 0, &resul 234 if (kstrtoint(param->string, 0, &result->int_32) < 0)
235 return fs_param_bad_value(log, 235 return fs_param_bad_value(log, param);
236 return 0; 236 return 0;
237 } 237 }
238 EXPORT_SYMBOL(fs_param_is_s32); 238 EXPORT_SYMBOL(fs_param_is_s32);
239 239
240 int fs_param_is_u64(struct p_log *log, const s 240 int fs_param_is_u64(struct p_log *log, const struct fs_parameter_spec *p,
241 struct fs_parameter *param 241 struct fs_parameter *param, struct fs_parse_result *result)
242 { 242 {
243 if (param->type != fs_value_is_string) 243 if (param->type != fs_value_is_string)
244 return fs_param_bad_value(log, 244 return fs_param_bad_value(log, param);
245 if (!*param->string && (p->flags & fs_ 245 if (!*param->string && (p->flags & fs_param_can_be_empty))
246 return 0; 246 return 0;
247 if (kstrtoull(param->string, 0, &resul 247 if (kstrtoull(param->string, 0, &result->uint_64) < 0)
248 return fs_param_bad_value(log, 248 return fs_param_bad_value(log, param);
249 return 0; 249 return 0;
250 } 250 }
251 EXPORT_SYMBOL(fs_param_is_u64); 251 EXPORT_SYMBOL(fs_param_is_u64);
252 252
253 int fs_param_is_enum(struct p_log *log, const 253 int fs_param_is_enum(struct p_log *log, const struct fs_parameter_spec *p,
254 struct fs_parameter *para 254 struct fs_parameter *param, struct fs_parse_result *result)
255 { 255 {
256 const struct constant_table *c; 256 const struct constant_table *c;
257 if (param->type != fs_value_is_string) 257 if (param->type != fs_value_is_string)
258 return fs_param_bad_value(log, 258 return fs_param_bad_value(log, param);
259 if (!*param->string && (p->flags & fs_ 259 if (!*param->string && (p->flags & fs_param_can_be_empty))
260 return 0; 260 return 0;
261 c = __lookup_constant(p->data, param-> 261 c = __lookup_constant(p->data, param->string);
262 if (!c) 262 if (!c)
263 return fs_param_bad_value(log, 263 return fs_param_bad_value(log, param);
264 result->uint_32 = c->value; 264 result->uint_32 = c->value;
265 return 0; 265 return 0;
266 } 266 }
267 EXPORT_SYMBOL(fs_param_is_enum); 267 EXPORT_SYMBOL(fs_param_is_enum);
268 268
269 int fs_param_is_string(struct p_log *log, cons 269 int fs_param_is_string(struct p_log *log, const struct fs_parameter_spec *p,
270 struct fs_parameter *pa 270 struct fs_parameter *param, struct fs_parse_result *result)
271 { 271 {
272 if (param->type != fs_value_is_string 272 if (param->type != fs_value_is_string ||
273 (!*param->string && !(p->flags & f 273 (!*param->string && !(p->flags & fs_param_can_be_empty)))
274 return fs_param_bad_value(log, 274 return fs_param_bad_value(log, param);
275 return 0; 275 return 0;
276 } 276 }
277 EXPORT_SYMBOL(fs_param_is_string); 277 EXPORT_SYMBOL(fs_param_is_string);
278 278
279 int fs_param_is_blob(struct p_log *log, const 279 int fs_param_is_blob(struct p_log *log, const struct fs_parameter_spec *p,
280 struct fs_parameter *para 280 struct fs_parameter *param, struct fs_parse_result *result)
281 { 281 {
282 if (param->type != fs_value_is_blob) 282 if (param->type != fs_value_is_blob)
283 return fs_param_bad_value(log, 283 return fs_param_bad_value(log, param);
284 return 0; 284 return 0;
285 } 285 }
286 EXPORT_SYMBOL(fs_param_is_blob); 286 EXPORT_SYMBOL(fs_param_is_blob);
287 287
288 int fs_param_is_fd(struct p_log *log, const st 288 int fs_param_is_fd(struct p_log *log, const struct fs_parameter_spec *p,
289 struct fs_parameter *param, 289 struct fs_parameter *param, struct fs_parse_result *result)
290 { 290 {
291 switch (param->type) { 291 switch (param->type) {
292 case fs_value_is_string: 292 case fs_value_is_string:
293 if ((!*param->string && !(p->f 293 if ((!*param->string && !(p->flags & fs_param_can_be_empty)) ||
294 kstrtouint(param->string, 294 kstrtouint(param->string, 0, &result->uint_32) < 0)
295 break; 295 break;
296 if (result->uint_32 <= INT_MAX 296 if (result->uint_32 <= INT_MAX)
297 return 0; 297 return 0;
298 break; 298 break;
299 case fs_value_is_file: 299 case fs_value_is_file:
300 result->uint_32 = param->dirfd 300 result->uint_32 = param->dirfd;
301 if (result->uint_32 <= INT_MAX 301 if (result->uint_32 <= INT_MAX)
302 return 0; 302 return 0;
303 break; 303 break;
304 default: 304 default:
305 break; 305 break;
306 } 306 }
307 return fs_param_bad_value(log, param); 307 return fs_param_bad_value(log, param);
308 } 308 }
309 EXPORT_SYMBOL(fs_param_is_fd); 309 EXPORT_SYMBOL(fs_param_is_fd);
310 <<
311 int fs_param_is_uid(struct p_log *log, const s <<
312 struct fs_parameter *param <<
313 { <<
314 kuid_t uid; <<
315 <<
316 if (fs_param_is_u32(log, p, param, res <<
317 return fs_param_bad_value(log, <<
318 <<
319 uid = make_kuid(current_user_ns(), res <<
320 if (!uid_valid(uid)) <<
321 return inval_plog(log, "Invali <<
322 <<
323 result->uid = uid; <<
324 return 0; <<
325 } <<
326 EXPORT_SYMBOL(fs_param_is_uid); <<
327 <<
328 int fs_param_is_gid(struct p_log *log, const s <<
329 struct fs_parameter *param <<
330 { <<
331 kgid_t gid; <<
332 <<
333 if (fs_param_is_u32(log, p, param, res <<
334 return fs_param_bad_value(log, <<
335 <<
336 gid = make_kgid(current_user_ns(), res <<
337 if (!gid_valid(gid)) <<
338 return inval_plog(log, "Invali <<
339 <<
340 result->gid = gid; <<
341 return 0; <<
342 } <<
343 EXPORT_SYMBOL(fs_param_is_gid); <<
344 310
345 int fs_param_is_blockdev(struct p_log *log, co 311 int fs_param_is_blockdev(struct p_log *log, const struct fs_parameter_spec *p,
346 struct fs_parameter *param, 312 struct fs_parameter *param, struct fs_parse_result *result)
347 { 313 {
348 return 0; 314 return 0;
349 } 315 }
350 EXPORT_SYMBOL(fs_param_is_blockdev); 316 EXPORT_SYMBOL(fs_param_is_blockdev);
351 317
352 int fs_param_is_path(struct p_log *log, const 318 int fs_param_is_path(struct p_log *log, const struct fs_parameter_spec *p,
353 struct fs_parameter *para 319 struct fs_parameter *param, struct fs_parse_result *result)
354 { 320 {
355 return 0; 321 return 0;
356 } 322 }
357 EXPORT_SYMBOL(fs_param_is_path); 323 EXPORT_SYMBOL(fs_param_is_path);
358 324
359 #ifdef CONFIG_VALIDATE_FS_PARSER 325 #ifdef CONFIG_VALIDATE_FS_PARSER
360 /** 326 /**
361 * validate_constant_table - Validate a consta 327 * validate_constant_table - Validate a constant table
362 * @tbl: The constant table to validate. 328 * @tbl: The constant table to validate.
363 * @tbl_size: The size of the table. 329 * @tbl_size: The size of the table.
364 * @low: The lowest permissible value. 330 * @low: The lowest permissible value.
365 * @high: The highest permissible value. 331 * @high: The highest permissible value.
366 * @special: One special permissible value out 332 * @special: One special permissible value outside of the range.
367 */ 333 */
368 bool validate_constant_table(const struct cons 334 bool validate_constant_table(const struct constant_table *tbl, size_t tbl_size,
369 int low, int high 335 int low, int high, int special)
370 { 336 {
371 size_t i; 337 size_t i;
372 bool good = true; 338 bool good = true;
373 339
374 if (tbl_size == 0) { 340 if (tbl_size == 0) {
375 pr_warn("VALIDATE C-TBL: Empty 341 pr_warn("VALIDATE C-TBL: Empty\n");
376 return true; 342 return true;
377 } 343 }
378 344
379 for (i = 0; i < tbl_size; i++) { 345 for (i = 0; i < tbl_size; i++) {
380 if (!tbl[i].name) { 346 if (!tbl[i].name) {
381 pr_err("VALIDATE C-TBL 347 pr_err("VALIDATE C-TBL[%zu]: Null\n", i);
382 good = false; 348 good = false;
383 } else if (i > 0 && tbl[i - 1] 349 } else if (i > 0 && tbl[i - 1].name) {
384 int c = strcmp(tbl[i-1 350 int c = strcmp(tbl[i-1].name, tbl[i].name);
385 351
386 if (c == 0) { 352 if (c == 0) {
387 pr_err("VALIDA 353 pr_err("VALIDATE C-TBL[%zu]: Duplicate %s\n",
388 i, tbl[ 354 i, tbl[i].name);
389 good = false; 355 good = false;
390 } 356 }
391 if (c > 0) { 357 if (c > 0) {
392 pr_err("VALIDA 358 pr_err("VALIDATE C-TBL[%zu]: Missorted %s>=%s\n",
393 i, tbl[ 359 i, tbl[i-1].name, tbl[i].name);
394 good = false; 360 good = false;
395 } 361 }
396 } 362 }
397 363
398 if (tbl[i].value != special && 364 if (tbl[i].value != special &&
399 (tbl[i].value < low || tbl 365 (tbl[i].value < low || tbl[i].value > high)) {
400 pr_err("VALIDATE C-TBL 366 pr_err("VALIDATE C-TBL[%zu]: %s->%d const out of range (%d-%d)\n",
401 i, tbl[i].name, 367 i, tbl[i].name, tbl[i].value, low, high);
402 good = false; 368 good = false;
403 } 369 }
404 } 370 }
405 371
406 return good; 372 return good;
407 } 373 }
408 374
409 /** 375 /**
410 * fs_validate_description - Validate a parame 376 * fs_validate_description - Validate a parameter description
411 * @name: The parameter name to search for. 377 * @name: The parameter name to search for.
412 * @desc: The parameter description to validat 378 * @desc: The parameter description to validate.
413 */ 379 */
414 bool fs_validate_description(const char *name, 380 bool fs_validate_description(const char *name,
415 const struct fs_parameter_spec *desc) 381 const struct fs_parameter_spec *desc)
416 { 382 {
417 const struct fs_parameter_spec *param, 383 const struct fs_parameter_spec *param, *p2;
418 bool good = true; 384 bool good = true;
419 385
420 for (param = desc; param->name; param+ 386 for (param = desc; param->name; param++) {
421 /* Check for duplicate paramet 387 /* Check for duplicate parameter names */
422 for (p2 = desc; p2 < param; p2 388 for (p2 = desc; p2 < param; p2++) {
423 if (strcmp(param->name 389 if (strcmp(param->name, p2->name) == 0) {
424 if (is_flag(pa 390 if (is_flag(param) != is_flag(p2))
425 contin 391 continue;
426 pr_err("VALIDA 392 pr_err("VALIDATE %s: PARAM[%s]: Duplicate\n",
427 name, p 393 name, param->name);
428 good = false; 394 good = false;
429 } 395 }
430 } 396 }
431 } 397 }
432 return good; 398 return good;
433 } 399 }
434 #endif /* CONFIG_VALIDATE_FS_PARSER */ 400 #endif /* CONFIG_VALIDATE_FS_PARSER */
435 401
Linux® is a registered trademark of Linus Torvalds in the United States and other countries.
TOMOYO® is a registered trademark of NTT DATA CORPORATION.