1 // SPDX-License-Identifier: GPL-2.0-only 1 // SPDX-License-Identifier: GPL-2.0-only
2 /* 2 /*
3 * Persistent Storage - ramfs parts. 3 * Persistent Storage - ramfs parts.
4 * 4 *
5 * Copyright (C) 2010 Intel Corporation <tony. 5 * Copyright (C) 2010 Intel Corporation <tony.luck@intel.com>
6 */ 6 */
7 7
8 #include <linux/module.h> 8 #include <linux/module.h>
9 #include <linux/fs.h> 9 #include <linux/fs.h>
10 #include <linux/fsnotify.h> 10 #include <linux/fsnotify.h>
11 #include <linux/pagemap.h> 11 #include <linux/pagemap.h>
12 #include <linux/highmem.h> 12 #include <linux/highmem.h>
13 #include <linux/time.h> 13 #include <linux/time.h>
14 #include <linux/init.h> 14 #include <linux/init.h>
15 #include <linux/list.h> 15 #include <linux/list.h>
16 #include <linux/string.h> 16 #include <linux/string.h>
17 #include <linux/mount.h> 17 #include <linux/mount.h>
18 #include <linux/seq_file.h> 18 #include <linux/seq_file.h>
19 #include <linux/ramfs.h> 19 #include <linux/ramfs.h>
20 #include <linux/parser.h> 20 #include <linux/parser.h>
21 #include <linux/sched.h> 21 #include <linux/sched.h>
22 #include <linux/magic.h> 22 #include <linux/magic.h>
23 #include <linux/pstore.h> 23 #include <linux/pstore.h>
24 #include <linux/slab.h> 24 #include <linux/slab.h>
25 #include <linux/uaccess.h> 25 #include <linux/uaccess.h>
26 #include <linux/cleanup.h> <<
27 26
28 #include "internal.h" 27 #include "internal.h"
29 28
30 #define PSTORE_NAMELEN 64 29 #define PSTORE_NAMELEN 64
31 30
32 static DEFINE_MUTEX(records_list_lock); 31 static DEFINE_MUTEX(records_list_lock);
33 static LIST_HEAD(records_list); 32 static LIST_HEAD(records_list);
34 33
35 static DEFINE_MUTEX(pstore_sb_lock); 34 static DEFINE_MUTEX(pstore_sb_lock);
36 static struct super_block *pstore_sb; 35 static struct super_block *pstore_sb;
37 36
38 DEFINE_FREE(pstore_iput, struct inode *, if (_ <<
39 <<
40 struct pstore_private { 37 struct pstore_private {
41 struct list_head list; 38 struct list_head list;
42 struct dentry *dentry; 39 struct dentry *dentry;
43 struct pstore_record *record; 40 struct pstore_record *record;
44 size_t total_size; 41 size_t total_size;
45 }; 42 };
46 43
47 struct pstore_ftrace_seq_data { 44 struct pstore_ftrace_seq_data {
48 const void *ptr; 45 const void *ptr;
49 size_t off; 46 size_t off;
50 size_t size; 47 size_t size;
51 }; 48 };
52 49
53 #define REC_SIZE sizeof(struct pstore_ftrace_r 50 #define REC_SIZE sizeof(struct pstore_ftrace_record)
54 51
55 static void free_pstore_private(struct pstore_ 52 static void free_pstore_private(struct pstore_private *private)
56 { 53 {
57 if (!private) 54 if (!private)
58 return; 55 return;
59 if (private->record) { 56 if (private->record) {
60 kvfree(private->record->buf); !! 57 kfree(private->record->buf);
61 kfree(private->record->priv); 58 kfree(private->record->priv);
62 kfree(private->record); 59 kfree(private->record);
63 } 60 }
64 kfree(private); 61 kfree(private);
65 } 62 }
66 DEFINE_FREE(pstore_private, struct pstore_priv <<
67 63
68 static void *pstore_ftrace_seq_start(struct se 64 static void *pstore_ftrace_seq_start(struct seq_file *s, loff_t *pos)
69 { 65 {
70 struct pstore_private *ps = s->private 66 struct pstore_private *ps = s->private;
71 struct pstore_ftrace_seq_data *data __ !! 67 struct pstore_ftrace_seq_data *data;
72 68
73 data = kzalloc(sizeof(*data), GFP_KERN 69 data = kzalloc(sizeof(*data), GFP_KERNEL);
74 if (!data) 70 if (!data)
75 return NULL; 71 return NULL;
76 72
77 data->off = ps->total_size % REC_SIZE; 73 data->off = ps->total_size % REC_SIZE;
78 data->off += *pos * REC_SIZE; 74 data->off += *pos * REC_SIZE;
79 if (data->off + REC_SIZE > ps->total_s !! 75 if (data->off + REC_SIZE > ps->total_size) {
>> 76 kfree(data);
80 return NULL; 77 return NULL;
>> 78 }
>> 79
>> 80 return data;
81 81
82 return_ptr(data); <<
83 } 82 }
84 83
85 static void pstore_ftrace_seq_stop(struct seq_ 84 static void pstore_ftrace_seq_stop(struct seq_file *s, void *v)
86 { 85 {
87 kfree(v); 86 kfree(v);
88 } 87 }
89 88
90 static void *pstore_ftrace_seq_next(struct seq 89 static void *pstore_ftrace_seq_next(struct seq_file *s, void *v, loff_t *pos)
91 { 90 {
92 struct pstore_private *ps = s->private 91 struct pstore_private *ps = s->private;
93 struct pstore_ftrace_seq_data *data = 92 struct pstore_ftrace_seq_data *data = v;
94 93
95 (*pos)++; 94 (*pos)++;
96 data->off += REC_SIZE; 95 data->off += REC_SIZE;
97 if (data->off + REC_SIZE > ps->total_s 96 if (data->off + REC_SIZE > ps->total_size)
98 return NULL; 97 return NULL;
99 98
100 return data; 99 return data;
101 } 100 }
102 101
103 static int pstore_ftrace_seq_show(struct seq_f 102 static int pstore_ftrace_seq_show(struct seq_file *s, void *v)
104 { 103 {
105 struct pstore_private *ps = s->private 104 struct pstore_private *ps = s->private;
106 struct pstore_ftrace_seq_data *data = 105 struct pstore_ftrace_seq_data *data = v;
107 struct pstore_ftrace_record *rec; 106 struct pstore_ftrace_record *rec;
108 107
109 if (!data) 108 if (!data)
110 return 0; 109 return 0;
111 110
112 rec = (struct pstore_ftrace_record *)( 111 rec = (struct pstore_ftrace_record *)(ps->record->buf + data->off);
113 112
114 seq_printf(s, "CPU:%d ts:%llu %08lx % 113 seq_printf(s, "CPU:%d ts:%llu %08lx %08lx %ps <- %pS\n",
115 pstore_ftrace_decode_cpu(re 114 pstore_ftrace_decode_cpu(rec),
116 pstore_ftrace_read_timestam 115 pstore_ftrace_read_timestamp(rec),
117 rec->ip, rec->parent_ip, (v 116 rec->ip, rec->parent_ip, (void *)rec->ip,
118 (void *)rec->parent_ip); 117 (void *)rec->parent_ip);
119 118
120 return 0; 119 return 0;
121 } 120 }
122 121
123 static const struct seq_operations pstore_ftra 122 static const struct seq_operations pstore_ftrace_seq_ops = {
124 .start = pstore_ftrace_seq_start, 123 .start = pstore_ftrace_seq_start,
125 .next = pstore_ftrace_seq_next, 124 .next = pstore_ftrace_seq_next,
126 .stop = pstore_ftrace_seq_stop, 125 .stop = pstore_ftrace_seq_stop,
127 .show = pstore_ftrace_seq_show, 126 .show = pstore_ftrace_seq_show,
128 }; 127 };
129 128
130 static ssize_t pstore_file_read(struct file *f 129 static ssize_t pstore_file_read(struct file *file, char __user *userbuf,
131 130 size_t count, loff_t *ppos)
132 { 131 {
133 struct seq_file *sf = file->private_da 132 struct seq_file *sf = file->private_data;
134 struct pstore_private *ps = sf->privat 133 struct pstore_private *ps = sf->private;
135 134
136 if (ps->record->type == PSTORE_TYPE_FT 135 if (ps->record->type == PSTORE_TYPE_FTRACE)
137 return seq_read(file, userbuf, 136 return seq_read(file, userbuf, count, ppos);
138 return simple_read_from_buffer(userbuf 137 return simple_read_from_buffer(userbuf, count, ppos,
139 ps->rec 138 ps->record->buf, ps->total_size);
140 } 139 }
141 140
142 static int pstore_file_open(struct inode *inod 141 static int pstore_file_open(struct inode *inode, struct file *file)
143 { 142 {
144 struct pstore_private *ps = inode->i_p 143 struct pstore_private *ps = inode->i_private;
145 struct seq_file *sf; 144 struct seq_file *sf;
146 int err; 145 int err;
147 const struct seq_operations *sops = NU 146 const struct seq_operations *sops = NULL;
148 147
149 if (ps->record->type == PSTORE_TYPE_FT 148 if (ps->record->type == PSTORE_TYPE_FTRACE)
150 sops = &pstore_ftrace_seq_ops; 149 sops = &pstore_ftrace_seq_ops;
151 150
152 err = seq_open(file, sops); 151 err = seq_open(file, sops);
153 if (err < 0) 152 if (err < 0)
154 return err; 153 return err;
155 154
156 sf = file->private_data; 155 sf = file->private_data;
157 sf->private = ps; 156 sf->private = ps;
158 157
159 return 0; 158 return 0;
160 } 159 }
161 160
162 static loff_t pstore_file_llseek(struct file * 161 static loff_t pstore_file_llseek(struct file *file, loff_t off, int whence)
163 { 162 {
164 struct seq_file *sf = file->private_da 163 struct seq_file *sf = file->private_data;
165 164
166 if (sf->op) 165 if (sf->op)
167 return seq_lseek(file, off, wh 166 return seq_lseek(file, off, whence);
168 return default_llseek(file, off, whenc 167 return default_llseek(file, off, whence);
169 } 168 }
170 169
171 static const struct file_operations pstore_fil 170 static const struct file_operations pstore_file_operations = {
172 .open = pstore_file_open, 171 .open = pstore_file_open,
173 .read = pstore_file_read, 172 .read = pstore_file_read,
174 .llseek = pstore_file_llseek, 173 .llseek = pstore_file_llseek,
175 .release = seq_release, 174 .release = seq_release,
176 }; 175 };
177 176
178 /* 177 /*
179 * When a file is unlinked from our file syste 178 * When a file is unlinked from our file system we call the
180 * platform driver to erase the record from pe 179 * platform driver to erase the record from persistent store.
181 */ 180 */
182 static int pstore_unlink(struct inode *dir, st 181 static int pstore_unlink(struct inode *dir, struct dentry *dentry)
183 { 182 {
184 struct pstore_private *p = d_inode(den 183 struct pstore_private *p = d_inode(dentry)->i_private;
185 struct pstore_record *record = p->reco 184 struct pstore_record *record = p->record;
>> 185 int rc = 0;
186 186
187 if (!record->psi->erase) 187 if (!record->psi->erase)
188 return -EPERM; 188 return -EPERM;
189 189
190 /* Make sure we can't race while remov 190 /* Make sure we can't race while removing this file. */
191 scoped_guard(mutex, &records_list_lock !! 191 mutex_lock(&records_list_lock);
192 if (!list_empty(&p->list)) !! 192 if (!list_empty(&p->list))
193 list_del_init(&p->list !! 193 list_del_init(&p->list);
194 else !! 194 else
195 return -ENOENT; !! 195 rc = -ENOENT;
196 p->dentry = NULL; !! 196 p->dentry = NULL;
197 } !! 197 mutex_unlock(&records_list_lock);
198 !! 198 if (rc)
199 scoped_guard(mutex, &record->psi->read !! 199 return rc;
200 record->psi->erase(record); !! 200
>> 201 mutex_lock(&record->psi->read_mutex);
>> 202 record->psi->erase(record);
>> 203 mutex_unlock(&record->psi->read_mutex);
201 204
202 return simple_unlink(dir, dentry); 205 return simple_unlink(dir, dentry);
203 } 206 }
204 207
205 static void pstore_evict_inode(struct inode *i 208 static void pstore_evict_inode(struct inode *inode)
206 { 209 {
207 struct pstore_private *p = inode->i_ 210 struct pstore_private *p = inode->i_private;
208 211
209 clear_inode(inode); 212 clear_inode(inode);
210 free_pstore_private(p); 213 free_pstore_private(p);
211 } 214 }
212 215
213 static const struct inode_operations pstore_di 216 static const struct inode_operations pstore_dir_inode_operations = {
214 .lookup = simple_lookup, 217 .lookup = simple_lookup,
215 .unlink = pstore_unlink, 218 .unlink = pstore_unlink,
216 }; 219 };
217 220
218 static struct inode *pstore_get_inode(struct s 221 static struct inode *pstore_get_inode(struct super_block *sb)
219 { 222 {
220 struct inode *inode = new_inode(sb); 223 struct inode *inode = new_inode(sb);
221 if (inode) { 224 if (inode) {
222 inode->i_ino = get_next_ino(); 225 inode->i_ino = get_next_ino();
223 simple_inode_init_ts(inode); !! 226 inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode);
224 } 227 }
225 return inode; 228 return inode;
226 } 229 }
227 230
228 enum { 231 enum {
229 Opt_kmsg_bytes, Opt_err 232 Opt_kmsg_bytes, Opt_err
230 }; 233 };
231 234
232 static const match_table_t tokens = { 235 static const match_table_t tokens = {
233 {Opt_kmsg_bytes, "kmsg_bytes=%u"}, 236 {Opt_kmsg_bytes, "kmsg_bytes=%u"},
234 {Opt_err, NULL} 237 {Opt_err, NULL}
235 }; 238 };
236 239
237 static void parse_options(char *options) 240 static void parse_options(char *options)
238 { 241 {
239 char *p; 242 char *p;
240 substring_t args[MAX_OPT_ARGS]; 243 substring_t args[MAX_OPT_ARGS];
241 int option; 244 int option;
242 245
243 if (!options) 246 if (!options)
244 return; 247 return;
245 248
246 while ((p = strsep(&options, ",")) != 249 while ((p = strsep(&options, ",")) != NULL) {
247 int token; 250 int token;
248 251
249 if (!*p) 252 if (!*p)
250 continue; 253 continue;
251 254
252 token = match_token(p, tokens, 255 token = match_token(p, tokens, args);
253 switch (token) { 256 switch (token) {
254 case Opt_kmsg_bytes: 257 case Opt_kmsg_bytes:
255 if (!match_int(&args[0 258 if (!match_int(&args[0], &option))
256 pstore_set_kms 259 pstore_set_kmsg_bytes(option);
257 break; 260 break;
258 } 261 }
259 } 262 }
260 } 263 }
261 264
262 /* 265 /*
263 * Display the mount options in /proc/mounts. 266 * Display the mount options in /proc/mounts.
264 */ 267 */
265 static int pstore_show_options(struct seq_file 268 static int pstore_show_options(struct seq_file *m, struct dentry *root)
266 { 269 {
267 if (kmsg_bytes != CONFIG_PSTORE_DEFAUL 270 if (kmsg_bytes != CONFIG_PSTORE_DEFAULT_KMSG_BYTES)
268 seq_printf(m, ",kmsg_bytes=%lu 271 seq_printf(m, ",kmsg_bytes=%lu", kmsg_bytes);
269 return 0; 272 return 0;
270 } 273 }
271 274
272 static int pstore_remount(struct super_block * 275 static int pstore_remount(struct super_block *sb, int *flags, char *data)
273 { 276 {
274 sync_filesystem(sb); 277 sync_filesystem(sb);
275 parse_options(data); 278 parse_options(data);
276 279
277 return 0; 280 return 0;
278 } 281 }
279 282
280 static const struct super_operations pstore_op 283 static const struct super_operations pstore_ops = {
281 .statfs = simple_statfs, 284 .statfs = simple_statfs,
282 .drop_inode = generic_delete_inode 285 .drop_inode = generic_delete_inode,
283 .evict_inode = pstore_evict_inode, 286 .evict_inode = pstore_evict_inode,
284 .remount_fs = pstore_remount, 287 .remount_fs = pstore_remount,
285 .show_options = pstore_show_options, 288 .show_options = pstore_show_options,
286 }; 289 };
287 290
288 static struct dentry *psinfo_lock_root(void) 291 static struct dentry *psinfo_lock_root(void)
289 { 292 {
290 struct dentry *root; 293 struct dentry *root;
291 294
292 guard(mutex)(&pstore_sb_lock); !! 295 mutex_lock(&pstore_sb_lock);
293 /* 296 /*
294 * Having no backend is fine -- no rec 297 * Having no backend is fine -- no records appear.
295 * Not being mounted is fine -- nothin 298 * Not being mounted is fine -- nothing to do.
296 */ 299 */
297 if (!psinfo || !pstore_sb) !! 300 if (!psinfo || !pstore_sb) {
>> 301 mutex_unlock(&pstore_sb_lock);
298 return NULL; 302 return NULL;
>> 303 }
299 304
300 root = pstore_sb->s_root; 305 root = pstore_sb->s_root;
301 inode_lock(d_inode(root)); 306 inode_lock(d_inode(root));
>> 307 mutex_unlock(&pstore_sb_lock);
302 308
303 return root; 309 return root;
304 } 310 }
305 311
306 int pstore_put_backend_records(struct pstore_i 312 int pstore_put_backend_records(struct pstore_info *psi)
307 { 313 {
308 struct pstore_private *pos, *tmp; 314 struct pstore_private *pos, *tmp;
309 struct dentry *root; 315 struct dentry *root;
>> 316 int rc = 0;
310 317
311 root = psinfo_lock_root(); 318 root = psinfo_lock_root();
312 if (!root) 319 if (!root)
313 return 0; 320 return 0;
314 321
315 scoped_guard(mutex, &records_list_lock !! 322 mutex_lock(&records_list_lock);
316 list_for_each_entry_safe(pos, !! 323 list_for_each_entry_safe(pos, tmp, &records_list, list) {
317 if (pos->record->psi = !! 324 if (pos->record->psi == psi) {
318 list_del_init( !! 325 list_del_init(&pos->list);
319 d_invalidate(p !! 326 rc = simple_unlink(d_inode(root), pos->dentry);
320 simple_unlink( !! 327 if (WARN_ON(rc))
321 pos->dentry = !! 328 break;
322 } !! 329 d_drop(pos->dentry);
>> 330 dput(pos->dentry);
>> 331 pos->dentry = NULL;
323 } 332 }
324 } 333 }
>> 334 mutex_unlock(&records_list_lock);
325 335
326 inode_unlock(d_inode(root)); 336 inode_unlock(d_inode(root));
327 337
328 return 0; !! 338 return rc;
329 } 339 }
330 340
331 /* 341 /*
332 * Make a regular file in the root directory o 342 * Make a regular file in the root directory of our file system.
333 * Load it up with "size" bytes of data from " 343 * Load it up with "size" bytes of data from "buf".
334 * Set the mtime & ctime to the date that this 344 * Set the mtime & ctime to the date that this record was originally stored.
335 */ 345 */
336 int pstore_mkfile(struct dentry *root, struct 346 int pstore_mkfile(struct dentry *root, struct pstore_record *record)
337 { 347 {
338 struct dentry *dentry; 348 struct dentry *dentry;
339 struct inode *inode __free( !! 349 struct inode *inode;
>> 350 int rc = 0;
340 char name[PSTORE_NA 351 char name[PSTORE_NAMELEN];
341 struct pstore_private *private __fre !! 352 struct pstore_private *private, *pos;
342 size_t size = record- 353 size_t size = record->size + record->ecc_notice_size;
343 354
344 if (WARN_ON(!inode_is_locked(d_inode(r 355 if (WARN_ON(!inode_is_locked(d_inode(root))))
345 return -EINVAL; 356 return -EINVAL;
346 357
347 guard(mutex)(&records_list_lock); !! 358 rc = -EEXIST;
348 <<
349 /* Skip records that are already prese 359 /* Skip records that are already present in the filesystem. */
>> 360 mutex_lock(&records_list_lock);
350 list_for_each_entry(pos, &records_list 361 list_for_each_entry(pos, &records_list, list) {
351 if (pos->record->type == recor 362 if (pos->record->type == record->type &&
352 pos->record->id == record- 363 pos->record->id == record->id &&
353 pos->record->psi == record 364 pos->record->psi == record->psi)
354 return -EEXIST; !! 365 goto fail;
355 } 366 }
356 367
>> 368 rc = -ENOMEM;
357 inode = pstore_get_inode(root->d_sb); 369 inode = pstore_get_inode(root->d_sb);
358 if (!inode) 370 if (!inode)
359 return -ENOMEM; !! 371 goto fail;
360 inode->i_mode = S_IFREG | 0444; 372 inode->i_mode = S_IFREG | 0444;
361 inode->i_fop = &pstore_file_operations 373 inode->i_fop = &pstore_file_operations;
362 scnprintf(name, sizeof(name), "%s-%s-% 374 scnprintf(name, sizeof(name), "%s-%s-%llu%s",
363 pstore_type_to_name(re 375 pstore_type_to_name(record->type),
364 record->psi->name, rec 376 record->psi->name, record->id,
365 record->compressed ? " 377 record->compressed ? ".enc.z" : "");
366 378
367 private = kzalloc(sizeof(*private), GF 379 private = kzalloc(sizeof(*private), GFP_KERNEL);
368 if (!private) 380 if (!private)
369 return -ENOMEM; !! 381 goto fail_inode;
370 382
371 dentry = d_alloc_name(root, name); 383 dentry = d_alloc_name(root, name);
372 if (!dentry) 384 if (!dentry)
373 return -ENOMEM; !! 385 goto fail_private;
374 386
375 private->dentry = dentry; 387 private->dentry = dentry;
376 private->record = record; 388 private->record = record;
377 inode->i_size = private->total_size = 389 inode->i_size = private->total_size = size;
378 inode->i_private = private; 390 inode->i_private = private;
379 391
380 if (record->time.tv_sec) 392 if (record->time.tv_sec)
381 inode_set_mtime_to_ts(inode, !! 393 inode->i_mtime = inode->i_ctime = record->time;
382 inode_se <<
383 394
384 d_add(dentry, no_free_ptr(inode)); !! 395 d_add(dentry, inode);
385 396
386 list_add(&(no_free_ptr(private))->list !! 397 list_add(&private->list, &records_list);
>> 398 mutex_unlock(&records_list_lock);
387 399
388 return 0; 400 return 0;
>> 401
>> 402 fail_private:
>> 403 free_pstore_private(private);
>> 404 fail_inode:
>> 405 iput(inode);
>> 406 fail:
>> 407 mutex_unlock(&records_list_lock);
>> 408 return rc;
389 } 409 }
390 410
391 /* 411 /*
392 * Read all the records from the persistent st 412 * Read all the records from the persistent store. Create
393 * files in our filesystem. Don't warn about 413 * files in our filesystem. Don't warn about -EEXIST errors
394 * when we are re-scanning the backing store l 414 * when we are re-scanning the backing store looking to add new
395 * error records. 415 * error records.
396 */ 416 */
397 void pstore_get_records(int quiet) 417 void pstore_get_records(int quiet)
398 { 418 {
399 struct dentry *root; 419 struct dentry *root;
400 420
401 root = psinfo_lock_root(); 421 root = psinfo_lock_root();
402 if (!root) 422 if (!root)
403 return; 423 return;
404 424
405 pstore_get_backend_records(psinfo, roo 425 pstore_get_backend_records(psinfo, root, quiet);
406 inode_unlock(d_inode(root)); 426 inode_unlock(d_inode(root));
407 } 427 }
408 428
409 static int pstore_fill_super(struct super_bloc 429 static int pstore_fill_super(struct super_block *sb, void *data, int silent)
410 { 430 {
411 struct inode *inode; 431 struct inode *inode;
412 432
413 sb->s_maxbytes = MAX_LFS_FILE 433 sb->s_maxbytes = MAX_LFS_FILESIZE;
414 sb->s_blocksize = PAGE_SIZE; 434 sb->s_blocksize = PAGE_SIZE;
415 sb->s_blocksize_bits = PAGE_SHIFT; 435 sb->s_blocksize_bits = PAGE_SHIFT;
416 sb->s_magic = PSTOREFS_MAG 436 sb->s_magic = PSTOREFS_MAGIC;
417 sb->s_op = &pstore_ops; 437 sb->s_op = &pstore_ops;
418 sb->s_time_gran = 1; 438 sb->s_time_gran = 1;
419 439
420 parse_options(data); 440 parse_options(data);
421 441
422 inode = pstore_get_inode(sb); 442 inode = pstore_get_inode(sb);
423 if (inode) { 443 if (inode) {
424 inode->i_mode = S_IFDIR | 0750 444 inode->i_mode = S_IFDIR | 0750;
425 inode->i_op = &pstore_dir_inod 445 inode->i_op = &pstore_dir_inode_operations;
426 inode->i_fop = &simple_dir_ope 446 inode->i_fop = &simple_dir_operations;
427 inc_nlink(inode); 447 inc_nlink(inode);
428 } 448 }
429 sb->s_root = d_make_root(inode); 449 sb->s_root = d_make_root(inode);
430 if (!sb->s_root) 450 if (!sb->s_root)
431 return -ENOMEM; 451 return -ENOMEM;
432 452
433 scoped_guard(mutex, &pstore_sb_lock) !! 453 mutex_lock(&pstore_sb_lock);
434 pstore_sb = sb; !! 454 pstore_sb = sb;
>> 455 mutex_unlock(&pstore_sb_lock);
435 456
436 pstore_get_records(0); 457 pstore_get_records(0);
437 458
438 return 0; 459 return 0;
439 } 460 }
440 461
441 static struct dentry *pstore_mount(struct file 462 static struct dentry *pstore_mount(struct file_system_type *fs_type,
442 int flags, const char *dev_name, void 463 int flags, const char *dev_name, void *data)
443 { 464 {
444 return mount_single(fs_type, flags, da 465 return mount_single(fs_type, flags, data, pstore_fill_super);
445 } 466 }
446 467
447 static void pstore_kill_sb(struct super_block 468 static void pstore_kill_sb(struct super_block *sb)
448 { 469 {
449 guard(mutex)(&pstore_sb_lock); !! 470 mutex_lock(&pstore_sb_lock);
450 WARN_ON(pstore_sb && pstore_sb != sb); 471 WARN_ON(pstore_sb && pstore_sb != sb);
451 472
452 kill_litter_super(sb); 473 kill_litter_super(sb);
453 pstore_sb = NULL; 474 pstore_sb = NULL;
454 475
455 guard(mutex)(&records_list_lock); !! 476 mutex_lock(&records_list_lock);
456 INIT_LIST_HEAD(&records_list); 477 INIT_LIST_HEAD(&records_list);
>> 478 mutex_unlock(&records_list_lock);
>> 479
>> 480 mutex_unlock(&pstore_sb_lock);
457 } 481 }
458 482
459 static struct file_system_type pstore_fs_type 483 static struct file_system_type pstore_fs_type = {
460 .owner = THIS_MODULE, 484 .owner = THIS_MODULE,
461 .name = "pstore", 485 .name = "pstore",
462 .mount = pstore_mount, 486 .mount = pstore_mount,
463 .kill_sb = pstore_kill_sb, 487 .kill_sb = pstore_kill_sb,
464 }; 488 };
465 489
466 int __init pstore_init_fs(void) 490 int __init pstore_init_fs(void)
467 { 491 {
468 int err; 492 int err;
469 493
470 /* Create a convenient mount point for 494 /* Create a convenient mount point for people to access pstore */
471 err = sysfs_create_mount_point(fs_kobj 495 err = sysfs_create_mount_point(fs_kobj, "pstore");
472 if (err) 496 if (err)
473 goto out; 497 goto out;
474 498
475 err = register_filesystem(&pstore_fs_t 499 err = register_filesystem(&pstore_fs_type);
476 if (err < 0) 500 if (err < 0)
477 sysfs_remove_mount_point(fs_ko 501 sysfs_remove_mount_point(fs_kobj, "pstore");
478 502
479 out: 503 out:
480 return err; 504 return err;
481 } 505 }
482 506
483 void __exit pstore_exit_fs(void) 507 void __exit pstore_exit_fs(void)
484 { 508 {
485 unregister_filesystem(&pstore_fs_type) 509 unregister_filesystem(&pstore_fs_type);
486 sysfs_remove_mount_point(fs_kobj, "pst 510 sysfs_remove_mount_point(fs_kobj, "pstore");
487 } 511 }
488 512
Linux® is a registered trademark of Linus Torvalds in the United States and other countries.
TOMOYO® is a registered trademark of NTT DATA CORPORATION.