1 // SPDX-License-Identifier: GPL-2.0-or-later 1 // SPDX-License-Identifier: GPL-2.0-or-later
2 /* 2 /*
3 * Sysfs attributes of bridge ports 3 * Sysfs attributes of bridge ports
4 * Linux ethernet bridge 4 * Linux ethernet bridge
5 * 5 *
6 * Authors: 6 * Authors:
7 * Stephen Hemminger <shemm 7 * Stephen Hemminger <shemminger@osdl.org>
8 */ 8 */
9 9
10 #include <linux/capability.h> 10 #include <linux/capability.h>
11 #include <linux/kernel.h> 11 #include <linux/kernel.h>
12 #include <linux/netdevice.h> 12 #include <linux/netdevice.h>
13 #include <linux/if_bridge.h> 13 #include <linux/if_bridge.h>
14 #include <linux/rtnetlink.h> 14 #include <linux/rtnetlink.h>
15 #include <linux/spinlock.h> 15 #include <linux/spinlock.h>
16 #include <linux/sched/signal.h> 16 #include <linux/sched/signal.h>
17 17
18 #include "br_private.h" 18 #include "br_private.h"
19 19
20 /* IMPORTANT: new bridge port options must be <<
21 * please do not add new sysfs entr <<
22 */ <<
23 <<
24 struct brport_attribute { 20 struct brport_attribute {
25 struct attribute attr; 21 struct attribute attr;
26 ssize_t (*show)(struct net_bridge_port 22 ssize_t (*show)(struct net_bridge_port *, char *);
27 int (*store)(struct net_bridge_port *, 23 int (*store)(struct net_bridge_port *, unsigned long);
28 int (*store_raw)(struct net_bridge_por 24 int (*store_raw)(struct net_bridge_port *, char *);
29 }; 25 };
30 26
31 #define BRPORT_ATTR_RAW(_name, _mode, _show, _ 27 #define BRPORT_ATTR_RAW(_name, _mode, _show, _store) \
32 const struct brport_attribute brport_attr_##_n 28 const struct brport_attribute brport_attr_##_name = { \
33 .attr = {.name = __stringify 29 .attr = {.name = __stringify(_name), \
34 .mode = _mode }, 30 .mode = _mode }, \
35 .show = _show, 31 .show = _show, \
36 .store_raw = _store, 32 .store_raw = _store, \
37 }; 33 };
38 34
39 #define BRPORT_ATTR(_name, _mode, _show, _stor 35 #define BRPORT_ATTR(_name, _mode, _show, _store) \
40 const struct brport_attribute brport_attr_##_n 36 const struct brport_attribute brport_attr_##_name = { \
41 .attr = {.name = __stringify(_name), 37 .attr = {.name = __stringify(_name), \
42 .mode = _mode }, 38 .mode = _mode }, \
43 .show = _show, 39 .show = _show, \
44 .store = _store, 40 .store = _store, \
45 }; 41 };
46 42
47 #define BRPORT_ATTR_FLAG(_name, _mask) 43 #define BRPORT_ATTR_FLAG(_name, _mask) \
48 static ssize_t show_##_name(struct net_bridge_ 44 static ssize_t show_##_name(struct net_bridge_port *p, char *buf) \
49 { 45 { \
50 return sprintf(buf, "%d\n", !!(p->flag 46 return sprintf(buf, "%d\n", !!(p->flags & _mask)); \
51 } 47 } \
52 static int store_##_name(struct net_bridge_por 48 static int store_##_name(struct net_bridge_port *p, unsigned long v) \
53 { 49 { \
54 return store_flag(p, v, _mask); 50 return store_flag(p, v, _mask); \
55 } 51 } \
56 static BRPORT_ATTR(_name, 0644, 52 static BRPORT_ATTR(_name, 0644, \
57 show_##_name, store_##_name 53 show_##_name, store_##_name)
58 54
59 static int store_flag(struct net_bridge_port * 55 static int store_flag(struct net_bridge_port *p, unsigned long v,
60 unsigned long mask) 56 unsigned long mask)
61 { 57 {
62 struct netlink_ext_ack extack = {0}; <<
63 unsigned long flags = p->flags; 58 unsigned long flags = p->flags;
64 int err; 59 int err;
65 60
66 if (v) 61 if (v)
67 flags |= mask; 62 flags |= mask;
68 else 63 else
69 flags &= ~mask; 64 flags &= ~mask;
70 65
71 if (flags != p->flags) { 66 if (flags != p->flags) {
72 err = br_switchdev_set_port_fl !! 67 err = br_switchdev_set_port_flag(p, flags, mask);
73 if (err) { !! 68 if (err)
74 netdev_err(p->dev, "%s <<
75 return err; 69 return err;
76 } <<
77 70
78 p->flags = flags; 71 p->flags = flags;
79 br_port_flags_change(p, mask); 72 br_port_flags_change(p, mask);
80 } 73 }
81 return 0; 74 return 0;
82 } 75 }
83 76
84 static ssize_t show_path_cost(struct net_bridg 77 static ssize_t show_path_cost(struct net_bridge_port *p, char *buf)
85 { 78 {
86 return sprintf(buf, "%d\n", p->path_co 79 return sprintf(buf, "%d\n", p->path_cost);
87 } 80 }
88 81
89 static BRPORT_ATTR(path_cost, 0644, 82 static BRPORT_ATTR(path_cost, 0644,
90 show_path_cost, br_stp_set_ 83 show_path_cost, br_stp_set_path_cost);
91 84
92 static ssize_t show_priority(struct net_bridge 85 static ssize_t show_priority(struct net_bridge_port *p, char *buf)
93 { 86 {
94 return sprintf(buf, "%d\n", p->priorit 87 return sprintf(buf, "%d\n", p->priority);
95 } 88 }
96 89
97 static BRPORT_ATTR(priority, 0644, 90 static BRPORT_ATTR(priority, 0644,
98 show_priority, br_stp 91 show_priority, br_stp_set_port_priority);
99 92
100 static ssize_t show_designated_root(struct net 93 static ssize_t show_designated_root(struct net_bridge_port *p, char *buf)
101 { 94 {
102 return br_show_bridge_id(buf, &p->desi 95 return br_show_bridge_id(buf, &p->designated_root);
103 } 96 }
104 static BRPORT_ATTR(designated_root, 0444, show 97 static BRPORT_ATTR(designated_root, 0444, show_designated_root, NULL);
105 98
106 static ssize_t show_designated_bridge(struct n 99 static ssize_t show_designated_bridge(struct net_bridge_port *p, char *buf)
107 { 100 {
108 return br_show_bridge_id(buf, &p->desi 101 return br_show_bridge_id(buf, &p->designated_bridge);
109 } 102 }
110 static BRPORT_ATTR(designated_bridge, 0444, sh 103 static BRPORT_ATTR(designated_bridge, 0444, show_designated_bridge, NULL);
111 104
112 static ssize_t show_designated_port(struct net 105 static ssize_t show_designated_port(struct net_bridge_port *p, char *buf)
113 { 106 {
114 return sprintf(buf, "%d\n", p->designa 107 return sprintf(buf, "%d\n", p->designated_port);
115 } 108 }
116 static BRPORT_ATTR(designated_port, 0444, show 109 static BRPORT_ATTR(designated_port, 0444, show_designated_port, NULL);
117 110
118 static ssize_t show_designated_cost(struct net 111 static ssize_t show_designated_cost(struct net_bridge_port *p, char *buf)
119 { 112 {
120 return sprintf(buf, "%d\n", p->designa 113 return sprintf(buf, "%d\n", p->designated_cost);
121 } 114 }
122 static BRPORT_ATTR(designated_cost, 0444, show 115 static BRPORT_ATTR(designated_cost, 0444, show_designated_cost, NULL);
123 116
124 static ssize_t show_port_id(struct net_bridge_ 117 static ssize_t show_port_id(struct net_bridge_port *p, char *buf)
125 { 118 {
126 return sprintf(buf, "0x%x\n", p->port_ 119 return sprintf(buf, "0x%x\n", p->port_id);
127 } 120 }
128 static BRPORT_ATTR(port_id, 0444, show_port_id 121 static BRPORT_ATTR(port_id, 0444, show_port_id, NULL);
129 122
130 static ssize_t show_port_no(struct net_bridge_ 123 static ssize_t show_port_no(struct net_bridge_port *p, char *buf)
131 { 124 {
132 return sprintf(buf, "0x%x\n", p->port_ 125 return sprintf(buf, "0x%x\n", p->port_no);
133 } 126 }
134 127
135 static BRPORT_ATTR(port_no, 0444, show_port_no 128 static BRPORT_ATTR(port_no, 0444, show_port_no, NULL);
136 129
137 static ssize_t show_change_ack(struct net_brid 130 static ssize_t show_change_ack(struct net_bridge_port *p, char *buf)
138 { 131 {
139 return sprintf(buf, "%d\n", p->topolog 132 return sprintf(buf, "%d\n", p->topology_change_ack);
140 } 133 }
141 static BRPORT_ATTR(change_ack, 0444, show_chan 134 static BRPORT_ATTR(change_ack, 0444, show_change_ack, NULL);
142 135
143 static ssize_t show_config_pending(struct net_ 136 static ssize_t show_config_pending(struct net_bridge_port *p, char *buf)
144 { 137 {
145 return sprintf(buf, "%d\n", p->config_ 138 return sprintf(buf, "%d\n", p->config_pending);
146 } 139 }
147 static BRPORT_ATTR(config_pending, 0444, show_ 140 static BRPORT_ATTR(config_pending, 0444, show_config_pending, NULL);
148 141
149 static ssize_t show_port_state(struct net_brid 142 static ssize_t show_port_state(struct net_bridge_port *p, char *buf)
150 { 143 {
151 return sprintf(buf, "%d\n", p->state); 144 return sprintf(buf, "%d\n", p->state);
152 } 145 }
153 static BRPORT_ATTR(state, 0444, show_port_stat 146 static BRPORT_ATTR(state, 0444, show_port_state, NULL);
154 147
155 static ssize_t show_message_age_timer(struct n 148 static ssize_t show_message_age_timer(struct net_bridge_port *p,
156 ch 149 char *buf)
157 { 150 {
158 return sprintf(buf, "%ld\n", br_timer_ 151 return sprintf(buf, "%ld\n", br_timer_value(&p->message_age_timer));
159 } 152 }
160 static BRPORT_ATTR(message_age_timer, 0444, sh 153 static BRPORT_ATTR(message_age_timer, 0444, show_message_age_timer, NULL);
161 154
162 static ssize_t show_forward_delay_timer(struct 155 static ssize_t show_forward_delay_timer(struct net_bridge_port *p,
163 ch 156 char *buf)
164 { 157 {
165 return sprintf(buf, "%ld\n", br_timer_ 158 return sprintf(buf, "%ld\n", br_timer_value(&p->forward_delay_timer));
166 } 159 }
167 static BRPORT_ATTR(forward_delay_timer, 0444, 160 static BRPORT_ATTR(forward_delay_timer, 0444, show_forward_delay_timer, NULL);
168 161
169 static ssize_t show_hold_timer(struct net_brid 162 static ssize_t show_hold_timer(struct net_bridge_port *p,
170 ch 163 char *buf)
171 { 164 {
172 return sprintf(buf, "%ld\n", br_timer_ 165 return sprintf(buf, "%ld\n", br_timer_value(&p->hold_timer));
173 } 166 }
174 static BRPORT_ATTR(hold_timer, 0444, show_hold 167 static BRPORT_ATTR(hold_timer, 0444, show_hold_timer, NULL);
175 168
176 static int store_flush(struct net_bridge_port 169 static int store_flush(struct net_bridge_port *p, unsigned long v)
177 { 170 {
178 br_fdb_delete_by_port(p->br, p, 0, 0); 171 br_fdb_delete_by_port(p->br, p, 0, 0); // Don't delete local entry
179 return 0; 172 return 0;
180 } 173 }
181 static BRPORT_ATTR(flush, 0200, NULL, store_fl 174 static BRPORT_ATTR(flush, 0200, NULL, store_flush);
182 175
183 static ssize_t show_group_fwd_mask(struct net_ 176 static ssize_t show_group_fwd_mask(struct net_bridge_port *p, char *buf)
184 { 177 {
185 return sprintf(buf, "%#x\n", p->group_ 178 return sprintf(buf, "%#x\n", p->group_fwd_mask);
186 } 179 }
187 180
188 static int store_group_fwd_mask(struct net_bri 181 static int store_group_fwd_mask(struct net_bridge_port *p,
189 unsigned long 182 unsigned long v)
190 { 183 {
191 if (v & BR_GROUPFWD_MACPAUSE) 184 if (v & BR_GROUPFWD_MACPAUSE)
192 return -EINVAL; 185 return -EINVAL;
193 p->group_fwd_mask = v; 186 p->group_fwd_mask = v;
194 187
195 return 0; 188 return 0;
196 } 189 }
197 static BRPORT_ATTR(group_fwd_mask, 0644, show_ 190 static BRPORT_ATTR(group_fwd_mask, 0644, show_group_fwd_mask,
198 store_group_fwd_mask); 191 store_group_fwd_mask);
199 192
200 static ssize_t show_backup_port(struct net_bri 193 static ssize_t show_backup_port(struct net_bridge_port *p, char *buf)
201 { 194 {
202 struct net_bridge_port *backup_p; 195 struct net_bridge_port *backup_p;
203 int ret = 0; 196 int ret = 0;
204 197
205 rcu_read_lock(); 198 rcu_read_lock();
206 backup_p = rcu_dereference(p->backup_p 199 backup_p = rcu_dereference(p->backup_port);
207 if (backup_p) 200 if (backup_p)
208 ret = sprintf(buf, "%s\n", bac 201 ret = sprintf(buf, "%s\n", backup_p->dev->name);
209 rcu_read_unlock(); 202 rcu_read_unlock();
210 203
211 return ret; 204 return ret;
212 } 205 }
213 206
214 static int store_backup_port(struct net_bridge 207 static int store_backup_port(struct net_bridge_port *p, char *buf)
215 { 208 {
216 struct net_device *backup_dev = NULL; 209 struct net_device *backup_dev = NULL;
217 char *nl = strchr(buf, '\n'); 210 char *nl = strchr(buf, '\n');
218 211
219 if (nl) 212 if (nl)
220 *nl = '\0'; 213 *nl = '\0';
221 214
222 if (strlen(buf) > 0) { 215 if (strlen(buf) > 0) {
223 backup_dev = __dev_get_by_name 216 backup_dev = __dev_get_by_name(dev_net(p->dev), buf);
224 if (!backup_dev) 217 if (!backup_dev)
225 return -ENOENT; 218 return -ENOENT;
226 } 219 }
227 220
228 return nbp_backup_change(p, backup_dev 221 return nbp_backup_change(p, backup_dev);
229 } 222 }
230 static BRPORT_ATTR_RAW(backup_port, 0644, show 223 static BRPORT_ATTR_RAW(backup_port, 0644, show_backup_port, store_backup_port);
231 224
232 BRPORT_ATTR_FLAG(hairpin_mode, BR_HAIRPIN_MODE 225 BRPORT_ATTR_FLAG(hairpin_mode, BR_HAIRPIN_MODE);
233 BRPORT_ATTR_FLAG(bpdu_guard, BR_BPDU_GUARD); 226 BRPORT_ATTR_FLAG(bpdu_guard, BR_BPDU_GUARD);
234 BRPORT_ATTR_FLAG(root_block, BR_ROOT_BLOCK); 227 BRPORT_ATTR_FLAG(root_block, BR_ROOT_BLOCK);
235 BRPORT_ATTR_FLAG(learning, BR_LEARNING); 228 BRPORT_ATTR_FLAG(learning, BR_LEARNING);
236 BRPORT_ATTR_FLAG(unicast_flood, BR_FLOOD); 229 BRPORT_ATTR_FLAG(unicast_flood, BR_FLOOD);
237 BRPORT_ATTR_FLAG(proxyarp, BR_PROXYARP); 230 BRPORT_ATTR_FLAG(proxyarp, BR_PROXYARP);
238 BRPORT_ATTR_FLAG(proxyarp_wifi, BR_PROXYARP_WI 231 BRPORT_ATTR_FLAG(proxyarp_wifi, BR_PROXYARP_WIFI);
239 BRPORT_ATTR_FLAG(multicast_flood, BR_MCAST_FLO 232 BRPORT_ATTR_FLAG(multicast_flood, BR_MCAST_FLOOD);
240 BRPORT_ATTR_FLAG(broadcast_flood, BR_BCAST_FLO 233 BRPORT_ATTR_FLAG(broadcast_flood, BR_BCAST_FLOOD);
241 BRPORT_ATTR_FLAG(neigh_suppress, BR_NEIGH_SUPP 234 BRPORT_ATTR_FLAG(neigh_suppress, BR_NEIGH_SUPPRESS);
242 BRPORT_ATTR_FLAG(isolated, BR_ISOLATED); 235 BRPORT_ATTR_FLAG(isolated, BR_ISOLATED);
243 236
244 #ifdef CONFIG_BRIDGE_IGMP_SNOOPING 237 #ifdef CONFIG_BRIDGE_IGMP_SNOOPING
245 static ssize_t show_multicast_router(struct ne 238 static ssize_t show_multicast_router(struct net_bridge_port *p, char *buf)
246 { 239 {
247 return sprintf(buf, "%d\n", p->multica !! 240 return sprintf(buf, "%d\n", p->multicast_router);
248 } 241 }
249 242
250 static int store_multicast_router(struct net_b 243 static int store_multicast_router(struct net_bridge_port *p,
251 unsigned 244 unsigned long v)
252 { 245 {
253 return br_multicast_set_port_router(&p !! 246 return br_multicast_set_port_router(p, v);
254 } 247 }
255 static BRPORT_ATTR(multicast_router, 0644, sho 248 static BRPORT_ATTR(multicast_router, 0644, show_multicast_router,
256 store_multicast_router); 249 store_multicast_router);
257 250
258 BRPORT_ATTR_FLAG(multicast_fast_leave, BR_MULT 251 BRPORT_ATTR_FLAG(multicast_fast_leave, BR_MULTICAST_FAST_LEAVE);
259 BRPORT_ATTR_FLAG(multicast_to_unicast, BR_MULT 252 BRPORT_ATTR_FLAG(multicast_to_unicast, BR_MULTICAST_TO_UNICAST);
260 #endif 253 #endif
261 254
262 static const struct brport_attribute *brport_a 255 static const struct brport_attribute *brport_attrs[] = {
263 &brport_attr_path_cost, 256 &brport_attr_path_cost,
264 &brport_attr_priority, 257 &brport_attr_priority,
265 &brport_attr_port_id, 258 &brport_attr_port_id,
266 &brport_attr_port_no, 259 &brport_attr_port_no,
267 &brport_attr_designated_root, 260 &brport_attr_designated_root,
268 &brport_attr_designated_bridge, 261 &brport_attr_designated_bridge,
269 &brport_attr_designated_port, 262 &brport_attr_designated_port,
270 &brport_attr_designated_cost, 263 &brport_attr_designated_cost,
271 &brport_attr_state, 264 &brport_attr_state,
272 &brport_attr_change_ack, 265 &brport_attr_change_ack,
273 &brport_attr_config_pending, 266 &brport_attr_config_pending,
274 &brport_attr_message_age_timer, 267 &brport_attr_message_age_timer,
275 &brport_attr_forward_delay_timer, 268 &brport_attr_forward_delay_timer,
276 &brport_attr_hold_timer, 269 &brport_attr_hold_timer,
277 &brport_attr_flush, 270 &brport_attr_flush,
278 &brport_attr_hairpin_mode, 271 &brport_attr_hairpin_mode,
279 &brport_attr_bpdu_guard, 272 &brport_attr_bpdu_guard,
280 &brport_attr_root_block, 273 &brport_attr_root_block,
281 &brport_attr_learning, 274 &brport_attr_learning,
282 &brport_attr_unicast_flood, 275 &brport_attr_unicast_flood,
283 #ifdef CONFIG_BRIDGE_IGMP_SNOOPING 276 #ifdef CONFIG_BRIDGE_IGMP_SNOOPING
284 &brport_attr_multicast_router, 277 &brport_attr_multicast_router,
285 &brport_attr_multicast_fast_leave, 278 &brport_attr_multicast_fast_leave,
286 &brport_attr_multicast_to_unicast, 279 &brport_attr_multicast_to_unicast,
287 #endif 280 #endif
288 &brport_attr_proxyarp, 281 &brport_attr_proxyarp,
289 &brport_attr_proxyarp_wifi, 282 &brport_attr_proxyarp_wifi,
290 &brport_attr_multicast_flood, 283 &brport_attr_multicast_flood,
291 &brport_attr_broadcast_flood, 284 &brport_attr_broadcast_flood,
292 &brport_attr_group_fwd_mask, 285 &brport_attr_group_fwd_mask,
293 &brport_attr_neigh_suppress, 286 &brport_attr_neigh_suppress,
294 &brport_attr_isolated, 287 &brport_attr_isolated,
295 &brport_attr_backup_port, 288 &brport_attr_backup_port,
296 NULL 289 NULL
297 }; 290 };
298 291
299 #define to_brport_attr(_at) container_of(_at, 292 #define to_brport_attr(_at) container_of(_at, struct brport_attribute, attr)
300 293
301 static ssize_t brport_show(struct kobject *kob 294 static ssize_t brport_show(struct kobject *kobj,
302 struct attribute *a 295 struct attribute *attr, char *buf)
303 { 296 {
304 struct brport_attribute *brport_attr = 297 struct brport_attribute *brport_attr = to_brport_attr(attr);
305 struct net_bridge_port *p = kobj_to_br 298 struct net_bridge_port *p = kobj_to_brport(kobj);
306 299
307 if (!brport_attr->show) 300 if (!brport_attr->show)
308 return -EINVAL; 301 return -EINVAL;
309 302
310 return brport_attr->show(p, buf); 303 return brport_attr->show(p, buf);
311 } 304 }
312 305
313 static ssize_t brport_store(struct kobject *ko 306 static ssize_t brport_store(struct kobject *kobj,
314 struct attribute * 307 struct attribute *attr,
315 const char *buf, s 308 const char *buf, size_t count)
316 { 309 {
317 struct brport_attribute *brport_attr = 310 struct brport_attribute *brport_attr = to_brport_attr(attr);
318 struct net_bridge_port *p = kobj_to_br 311 struct net_bridge_port *p = kobj_to_brport(kobj);
319 ssize_t ret = -EINVAL; 312 ssize_t ret = -EINVAL;
320 unsigned long val; 313 unsigned long val;
321 char *endp; 314 char *endp;
322 315
323 if (!ns_capable(dev_net(p->dev)->user_ 316 if (!ns_capable(dev_net(p->dev)->user_ns, CAP_NET_ADMIN))
324 return -EPERM; 317 return -EPERM;
325 318
326 if (!rtnl_trylock()) 319 if (!rtnl_trylock())
327 return restart_syscall(); 320 return restart_syscall();
328 321
329 if (brport_attr->store_raw) { 322 if (brport_attr->store_raw) {
330 char *buf_copy; 323 char *buf_copy;
331 324
332 buf_copy = kstrndup(buf, count 325 buf_copy = kstrndup(buf, count, GFP_KERNEL);
333 if (!buf_copy) { 326 if (!buf_copy) {
334 ret = -ENOMEM; 327 ret = -ENOMEM;
335 goto out_unlock; 328 goto out_unlock;
336 } 329 }
337 spin_lock_bh(&p->br->lock); 330 spin_lock_bh(&p->br->lock);
338 ret = brport_attr->store_raw(p 331 ret = brport_attr->store_raw(p, buf_copy);
339 spin_unlock_bh(&p->br->lock); 332 spin_unlock_bh(&p->br->lock);
340 kfree(buf_copy); 333 kfree(buf_copy);
341 } else if (brport_attr->store) { 334 } else if (brport_attr->store) {
342 val = simple_strtoul(buf, &end 335 val = simple_strtoul(buf, &endp, 0);
343 if (endp == buf) 336 if (endp == buf)
344 goto out_unlock; 337 goto out_unlock;
345 spin_lock_bh(&p->br->lock); 338 spin_lock_bh(&p->br->lock);
346 ret = brport_attr->store(p, va 339 ret = brport_attr->store(p, val);
347 spin_unlock_bh(&p->br->lock); 340 spin_unlock_bh(&p->br->lock);
348 } 341 }
349 342
350 if (!ret) { 343 if (!ret) {
351 br_ifinfo_notify(RTM_NEWLINK, 344 br_ifinfo_notify(RTM_NEWLINK, NULL, p);
352 ret = count; 345 ret = count;
353 } 346 }
354 out_unlock: 347 out_unlock:
355 rtnl_unlock(); 348 rtnl_unlock();
356 349
357 return ret; 350 return ret;
358 } 351 }
359 352
360 const struct sysfs_ops brport_sysfs_ops = { 353 const struct sysfs_ops brport_sysfs_ops = {
361 .show = brport_show, 354 .show = brport_show,
362 .store = brport_store, 355 .store = brport_store,
363 }; 356 };
364 357
365 /* 358 /*
366 * Add sysfs entries to ethernet device added 359 * Add sysfs entries to ethernet device added to a bridge.
367 * Creates a brport subdirectory with bridge a 360 * Creates a brport subdirectory with bridge attributes.
368 * Puts symlink in bridge's brif subdirectory 361 * Puts symlink in bridge's brif subdirectory
369 */ 362 */
370 int br_sysfs_addif(struct net_bridge_port *p) 363 int br_sysfs_addif(struct net_bridge_port *p)
371 { 364 {
372 struct net_bridge *br = p->br; 365 struct net_bridge *br = p->br;
373 const struct brport_attribute **a; 366 const struct brport_attribute **a;
374 int err; 367 int err;
375 368
376 err = sysfs_create_link(&p->kobj, &br- 369 err = sysfs_create_link(&p->kobj, &br->dev->dev.kobj,
377 SYSFS_BRIDGE_P 370 SYSFS_BRIDGE_PORT_LINK);
378 if (err) 371 if (err)
379 return err; 372 return err;
380 373
381 for (a = brport_attrs; *a; ++a) { 374 for (a = brport_attrs; *a; ++a) {
382 err = sysfs_create_file(&p->ko 375 err = sysfs_create_file(&p->kobj, &((*a)->attr));
383 if (err) 376 if (err)
384 return err; 377 return err;
385 } 378 }
386 379
387 strscpy(p->sysfs_name, p->dev->name, I !! 380 strlcpy(p->sysfs_name, p->dev->name, IFNAMSIZ);
388 return sysfs_create_link(br->ifobj, &p 381 return sysfs_create_link(br->ifobj, &p->kobj, p->sysfs_name);
389 } 382 }
390 383
391 /* Rename bridge's brif symlink */ 384 /* Rename bridge's brif symlink */
392 int br_sysfs_renameif(struct net_bridge_port * 385 int br_sysfs_renameif(struct net_bridge_port *p)
393 { 386 {
394 struct net_bridge *br = p->br; 387 struct net_bridge *br = p->br;
395 int err; 388 int err;
396 389
397 /* If a rename fails, the rollback wil 390 /* If a rename fails, the rollback will cause another
398 * rename call with the existing name. 391 * rename call with the existing name.
399 */ 392 */
400 if (!strncmp(p->sysfs_name, p->dev->na 393 if (!strncmp(p->sysfs_name, p->dev->name, IFNAMSIZ))
401 return 0; 394 return 0;
402 395
403 err = sysfs_rename_link(br->ifobj, &p- 396 err = sysfs_rename_link(br->ifobj, &p->kobj,
404 p->sysfs_name, 397 p->sysfs_name, p->dev->name);
405 if (err) 398 if (err)
406 netdev_notice(br->dev, "unable 399 netdev_notice(br->dev, "unable to rename link %s to %s",
407 p->sysfs_name, p 400 p->sysfs_name, p->dev->name);
408 else 401 else
409 strscpy(p->sysfs_name, p->dev- !! 402 strlcpy(p->sysfs_name, p->dev->name, IFNAMSIZ);
410 403
411 return err; 404 return err;
412 } 405 }
413 406
Linux® is a registered trademark of Linus Torvalds in the United States and other countries.
TOMOYO® is a registered trademark of NTT DATA CORPORATION.