1 // SPDX-License-Identifier: GPL-2.0 1 // SPDX-License-Identifier: GPL-2.0
2 /// Remove an open coded simple_open() functio 2 /// Remove an open coded simple_open() function
3 /// and replace file operations references to 3 /// and replace file operations references to the function
4 /// with simple_open() instead. 4 /// with simple_open() instead.
5 /// 5 ///
6 // Confidence: High 6 // Confidence: High
7 // Comments: 7 // Comments:
8 // Options: --no-includes --include-headers 8 // Options: --no-includes --include-headers
9 9
10 virtual patch 10 virtual patch
11 virtual report 11 virtual report
12 12
13 @ open depends on patch @ 13 @ open depends on patch @
14 identifier open_f != simple_open; 14 identifier open_f != simple_open;
15 identifier i, f; 15 identifier i, f;
16 @@ 16 @@
17 -int open_f(struct inode *i, struct file *f) 17 -int open_f(struct inode *i, struct file *f)
18 -{ 18 -{
19 ( 19 (
20 -if (i->i_private) 20 -if (i->i_private)
21 -f->private_data = i->i_private; 21 -f->private_data = i->i_private;
22 | 22 |
23 -f->private_data = i->i_private; 23 -f->private_data = i->i_private;
24 ) 24 )
25 -return 0; 25 -return 0;
26 -} 26 -}
27 27
28 @ has_open depends on open @ 28 @ has_open depends on open @
29 identifier fops; 29 identifier fops;
30 identifier open.open_f; 30 identifier open.open_f;
31 @@ 31 @@
32 struct file_operations fops = { 32 struct file_operations fops = {
33 ..., 33 ...,
34 -.open = open_f, 34 -.open = open_f,
35 +.open = simple_open, 35 +.open = simple_open,
36 ... 36 ...
37 }; 37 };
38 38
39 @ openr depends on report @ 39 @ openr depends on report @
40 identifier open_f != simple_open; 40 identifier open_f != simple_open;
41 identifier i, f; 41 identifier i, f;
42 position p; 42 position p;
43 @@ 43 @@
44 int open_f@p(struct inode *i, struct file *f) 44 int open_f@p(struct inode *i, struct file *f)
45 { 45 {
46 ( 46 (
47 if (i->i_private) 47 if (i->i_private)
48 f->private_data = i->i_private; 48 f->private_data = i->i_private;
49 | 49 |
50 f->private_data = i->i_private; 50 f->private_data = i->i_private;
51 ) 51 )
52 return 0; 52 return 0;
53 } 53 }
54 54
55 @ has_openr depends on openr @ 55 @ has_openr depends on openr @
56 identifier fops; 56 identifier fops;
57 identifier openr.open_f; 57 identifier openr.open_f;
58 position p; 58 position p;
59 @@ 59 @@
60 struct file_operations fops = { 60 struct file_operations fops = {
61 ..., 61 ...,
62 .open = open_f@p, 62 .open = open_f@p,
63 ... 63 ...
64 }; 64 };
65 65
66 @script:python@ 66 @script:python@
67 pf << openr.p; 67 pf << openr.p;
68 ps << has_openr.p; 68 ps << has_openr.p;
69 @@ 69 @@
70 70
71 coccilib.report.print_report(pf[0],"WARNING op 71 coccilib.report.print_report(pf[0],"WARNING opportunity for simple_open, see also structure on line %s"%(ps[0].line))
Linux® is a registered trademark of Linus Torvalds in the United States and other countries.
TOMOYO® is a registered trademark of NTT DATA CORPORATION.