1 // SPDX-License-Identifier: GPL-2.0-only 1 // SPDX-License-Identifier: GPL-2.0-only
2 /// 2 ///
3 /// Zero-length and one-element arrays are dep 3 /// Zero-length and one-element arrays are deprecated, see
4 /// Documentation/process/deprecated.rst 4 /// Documentation/process/deprecated.rst
5 /// Flexible-array members should be used inst 5 /// Flexible-array members should be used instead.
6 /// 6 ///
7 // 7 //
8 // Confidence: High 8 // Confidence: High
9 // Copyright: (C) 2020 Denis Efremov ISPRAS. 9 // Copyright: (C) 2020 Denis Efremov ISPRAS.
10 // Comments: 10 // Comments:
11 // Options: --no-includes --include-headers 11 // Options: --no-includes --include-headers
12 12
13 virtual context 13 virtual context
14 virtual report 14 virtual report
15 virtual org 15 virtual org
16 virtual patch 16 virtual patch
17 17
18 @initialize:python@ 18 @initialize:python@
19 @@ 19 @@
20 def relevant(positions): 20 def relevant(positions):
21 for p in positions: 21 for p in positions:
22 if "uapi" in p.file: 22 if "uapi" in p.file:
23 return False 23 return False
24 return True 24 return True
25 25
26 @r depends on !patch@ 26 @r depends on !patch@
27 identifier name, array; 27 identifier name, array;
28 type T; 28 type T;
29 position p : script:python() { relevant(p) }; 29 position p : script:python() { relevant(p) };
30 @@ 30 @@
31 31
32 ( 32 (
33 struct name { 33 struct name {
34 ... 34 ...
35 * T array@p[\(0\|1\)]; 35 * T array@p[\(0\|1\)];
36 }; 36 };
37 | 37 |
38 struct { 38 struct {
39 ... 39 ...
40 * T array@p[\(0\|1\)]; 40 * T array@p[\(0\|1\)];
41 }; 41 };
42 | 42 |
43 union name { 43 union name {
44 ... 44 ...
45 * T array@p[\(0\|1\)]; 45 * T array@p[\(0\|1\)];
46 }; 46 };
47 | 47 |
48 union { 48 union {
49 ... 49 ...
50 * T array@p[\(0\|1\)]; 50 * T array@p[\(0\|1\)];
51 }; 51 };
52 ) 52 )
53 53
54 @only_field depends on patch@ 54 @only_field depends on patch@
55 identifier name, array; 55 identifier name, array;
56 type T; 56 type T;
57 position q; 57 position q;
58 @@ 58 @@
59 59
60 ( 60 (
61 struct name {@q 61 struct name {@q
62 T array[0]; 62 T array[0];
63 }; 63 };
64 | 64 |
65 struct {@q 65 struct {@q
66 T array[0]; 66 T array[0];
67 }; 67 };
68 ) 68 )
69 69
70 @depends on patch@ 70 @depends on patch@
71 identifier name, array; 71 identifier name, array;
72 type T; 72 type T;
73 position p : script:python() { relevant(p) }; 73 position p : script:python() { relevant(p) };
74 // position @q with rule "only_field" simplifi 74 // position @q with rule "only_field" simplifies
75 // handling of bitfields, arrays, etc. 75 // handling of bitfields, arrays, etc.
76 position q != only_field.q; 76 position q != only_field.q;
77 @@ 77 @@
78 78
79 ( 79 (
80 struct name {@q 80 struct name {@q
81 ... 81 ...
82 T array@p[ 82 T array@p[
83 - 0 83 - 0
84 ]; 84 ];
85 }; 85 };
86 | 86 |
87 struct {@q 87 struct {@q
88 ... 88 ...
89 T array@p[ 89 T array@p[
90 - 0 90 - 0
91 ]; 91 ];
92 }; 92 };
93 ) 93 )
94 94
95 @script: python depends on report@ 95 @script: python depends on report@
96 p << r.p; 96 p << r.p;
97 @@ 97 @@
98 98
99 msg = "WARNING use flexible-array member inste 99 msg = "WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)"
100 coccilib.report.print_report(p[0], msg) 100 coccilib.report.print_report(p[0], msg)
101 101
102 @script: python depends on org@ 102 @script: python depends on org@
103 p << r.p; 103 p << r.p;
104 @@ 104 @@
105 105
106 msg = "WARNING use flexible-array member inste 106 msg = "WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)"
107 coccilib.org.print_todo(p[0], msg) 107 coccilib.org.print_todo(p[0], msg)
Linux® is a registered trademark of Linus Torvalds in the United States and other countries.
TOMOYO® is a registered trademark of NTT DATA CORPORATION.