1 // SPDX-License-Identifier: GPL-2.0 1 // SPDX-License-Identifier: GPL-2.0
2 /// Since commit 1c6c69525b40 ("genirq: Reject 2 /// Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
3 /// threaded IRQs without a primary handler ne 3 /// threaded IRQs without a primary handler need to be requested with
4 /// IRQF_ONESHOT, otherwise the request will f 4 /// IRQF_ONESHOT, otherwise the request will fail.
5 /// 5 ///
6 /// So pass the IRQF_ONESHOT flag in this case 6 /// So pass the IRQF_ONESHOT flag in this case.
7 /// 7 ///
8 // 8 //
9 // Confidence: Moderate 9 // Confidence: Moderate
10 // Comments: 10 // Comments:
11 // Options: --no-includes 11 // Options: --no-includes
12 12
13 virtual patch 13 virtual patch
14 virtual context 14 virtual context
15 virtual org 15 virtual org
16 virtual report 16 virtual report
17 17
18 @r1@ 18 @r1@
19 expression dev, irq, thread_fn; 19 expression dev, irq, thread_fn;
20 position p; 20 position p;
21 @@ 21 @@
22 ( 22 (
23 request_threaded_irq@p(irq, NULL, thread_fn, 23 request_threaded_irq@p(irq, NULL, thread_fn,
24 ( 24 (
25 IRQF_ONESHOT | ... 25 IRQF_ONESHOT | ...
26 | 26 |
27 IRQF_ONESHOT 27 IRQF_ONESHOT
28 ) 28 )
29 , ...) 29 , ...)
30 | 30 |
31 devm_request_threaded_irq@p(dev, irq, NULL, th 31 devm_request_threaded_irq@p(dev, irq, NULL, thread_fn,
32 ( 32 (
33 IRQF_ONESHOT | ... 33 IRQF_ONESHOT | ...
34 | 34 |
35 IRQF_ONESHOT 35 IRQF_ONESHOT
36 ) 36 )
37 , ...) 37 , ...)
38 ) 38 )
39 39
40 @r2@ 40 @r2@
41 expression dev, irq, thread_fn, flags, e; 41 expression dev, irq, thread_fn, flags, e;
42 position p != r1.p; 42 position p != r1.p;
43 @@ 43 @@
44 ( 44 (
45 flags = IRQF_ONESHOT | ... 45 flags = IRQF_ONESHOT | ...
46 | 46 |
47 flags |= IRQF_ONESHOT | ... 47 flags |= IRQF_ONESHOT | ...
48 ) 48 )
49 ... when != flags = e 49 ... when != flags = e
50 ( 50 (
51 request_threaded_irq@p(irq, NULL, thread_fn, f 51 request_threaded_irq@p(irq, NULL, thread_fn, flags, ...);
52 | 52 |
53 devm_request_threaded_irq@p(dev, irq, NULL, th 53 devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...);
54 ) 54 )
55 55
56 @depends on patch@ 56 @depends on patch@
57 expression dev, irq, thread_fn, flags; 57 expression dev, irq, thread_fn, flags;
58 position p != {r1.p,r2.p}; 58 position p != {r1.p,r2.p};
59 @@ 59 @@
60 ( 60 (
61 request_threaded_irq@p(irq, NULL, thread_fn, 61 request_threaded_irq@p(irq, NULL, thread_fn,
62 ( 62 (
63 -0 63 -0
64 +IRQF_ONESHOT 64 +IRQF_ONESHOT
65 | 65 |
66 -flags 66 -flags
67 +flags | IRQF_ONESHOT 67 +flags | IRQF_ONESHOT
68 ) 68 )
69 , ...) 69 , ...)
70 | 70 |
71 devm_request_threaded_irq@p(dev, irq, NULL, th 71 devm_request_threaded_irq@p(dev, irq, NULL, thread_fn,
72 ( 72 (
73 -0 73 -0
74 +IRQF_ONESHOT 74 +IRQF_ONESHOT
75 | 75 |
76 -flags 76 -flags
77 +flags | IRQF_ONESHOT 77 +flags | IRQF_ONESHOT
78 ) 78 )
79 , ...) 79 , ...)
80 ) 80 )
81 81
82 @depends on context@ 82 @depends on context@
83 expression dev, irq; 83 expression dev, irq;
84 position p != {r1.p,r2.p}; 84 position p != {r1.p,r2.p};
85 @@ 85 @@
86 ( 86 (
87 *request_threaded_irq@p(irq, NULL, ...) 87 *request_threaded_irq@p(irq, NULL, ...)
88 | 88 |
89 *devm_request_threaded_irq@p(dev, irq, NULL, . 89 *devm_request_threaded_irq@p(dev, irq, NULL, ...)
90 ) 90 )
91 91
92 92
93 @match depends on report || org@ 93 @match depends on report || org@
94 expression dev, irq; 94 expression dev, irq;
95 position p != {r1.p,r2.p}; 95 position p != {r1.p,r2.p};
96 @@ 96 @@
97 ( 97 (
98 request_threaded_irq@p(irq, NULL, ...) 98 request_threaded_irq@p(irq, NULL, ...)
99 | 99 |
100 devm_request_threaded_irq@p(dev, irq, NULL, .. 100 devm_request_threaded_irq@p(dev, irq, NULL, ...)
101 ) 101 )
102 102
103 @script:python depends on org@ 103 @script:python depends on org@
104 p << match.p; 104 p << match.p;
105 @@ 105 @@
106 msg = "WARNING: Threaded IRQ with no primary h 106 msg = "WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)"
107 coccilib.org.print_todo(p[0],msg) 107 coccilib.org.print_todo(p[0],msg)
108 108
109 @script:python depends on report@ 109 @script:python depends on report@
110 p << match.p; 110 p << match.p;
111 @@ 111 @@
112 msg = "WARNING: Threaded IRQ with no primary h 112 msg = "WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)"
113 coccilib.report.print_report(p[0],msg) 113 coccilib.report.print_report(p[0],msg)
Linux® is a registered trademark of Linus Torvalds in the United States and other countries.
TOMOYO® is a registered trademark of NTT DATA CORPORATION.