~ [ source navigation ] ~ [ diff markup ] ~ [ identifier search ] ~

TOMOYO Linux Cross Reference
Linux/scripts/coccinelle/misc/warn.cocci

Version: ~ [ linux-6.12-rc7 ] ~ [ linux-6.11.7 ] ~ [ linux-6.10.14 ] ~ [ linux-6.9.12 ] ~ [ linux-6.8.12 ] ~ [ linux-6.7.12 ] ~ [ linux-6.6.60 ] ~ [ linux-6.5.13 ] ~ [ linux-6.4.16 ] ~ [ linux-6.3.13 ] ~ [ linux-6.2.16 ] ~ [ linux-6.1.116 ] ~ [ linux-6.0.19 ] ~ [ linux-5.19.17 ] ~ [ linux-5.18.19 ] ~ [ linux-5.17.15 ] ~ [ linux-5.16.20 ] ~ [ linux-5.15.171 ] ~ [ linux-5.14.21 ] ~ [ linux-5.13.19 ] ~ [ linux-5.12.19 ] ~ [ linux-5.11.22 ] ~ [ linux-5.10.229 ] ~ [ linux-5.9.16 ] ~ [ linux-5.8.18 ] ~ [ linux-5.7.19 ] ~ [ linux-5.6.19 ] ~ [ linux-5.5.19 ] ~ [ linux-5.4.285 ] ~ [ linux-5.3.18 ] ~ [ linux-5.2.21 ] ~ [ linux-5.1.21 ] ~ [ linux-5.0.21 ] ~ [ linux-4.20.17 ] ~ [ linux-4.19.323 ] ~ [ linux-4.18.20 ] ~ [ linux-4.17.19 ] ~ [ linux-4.16.18 ] ~ [ linux-4.15.18 ] ~ [ linux-4.14.336 ] ~ [ linux-4.13.16 ] ~ [ linux-4.12.14 ] ~ [ linux-4.11.12 ] ~ [ linux-4.10.17 ] ~ [ linux-4.9.337 ] ~ [ linux-4.4.302 ] ~ [ linux-3.10.108 ] ~ [ linux-2.6.32.71 ] ~ [ linux-2.6.0 ] ~ [ linux-2.4.37.11 ] ~ [ unix-v6-master ] ~ [ ccs-tools-1.8.12 ] ~ [ policy-sample ] ~
Architecture: ~ [ i386 ] ~ [ alpha ] ~ [ m68k ] ~ [ mips ] ~ [ ppc ] ~ [ sparc ] ~ [ sparc64 ] ~

Diff markup

Differences between /scripts/coccinelle/misc/warn.cocci (Version linux-6.12-rc7) and /scripts/coccinelle/misc/warn.cocci (Version linux-5.9.16)


  1 // SPDX-License-Identifier: GPL-2.0-only            1 // SPDX-License-Identifier: GPL-2.0-only
  2 /// Use WARN(1,...) rather than printk followe      2 /// Use WARN(1,...) rather than printk followed by WARN_ON(1)
  3 ///                                                 3 ///
  4 // Confidence: High                                 4 // Confidence: High
  5 // Copyright: (C) 2012 Julia Lawall, INRIA/LIP      5 // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6.
  6 // Copyright: (C) 2012 Gilles Muller, INRIA/Li      6 // Copyright: (C) 2012 Gilles Muller, INRIA/LiP6.
  7 // URL: https://coccinelle.gitlabpages.inria.f !!   7 // URL: http://coccinelle.lip6.fr/
  8 // Comments:                                        8 // Comments:
  9 // Options: --no-includes --include-headers         9 // Options: --no-includes --include-headers
 10                                                    10 
 11 virtual patch                                      11 virtual patch
 12 virtual context                                    12 virtual context
 13 virtual org                                        13 virtual org
 14 virtual report                                     14 virtual report
 15                                                    15 
 16 @bad1@                                             16 @bad1@
 17 position p;                                        17 position p;
 18 @@                                                 18 @@
 19                                                    19 
 20 printk(...);                                       20 printk(...);
 21 printk@p(...);                                     21 printk@p(...);
 22 WARN_ON(1);                                        22 WARN_ON(1);
 23                                                    23 
 24 @r1 depends on context || report || org@           24 @r1 depends on context || report || org@
 25 position p != bad1.p;                              25 position p != bad1.p;
 26 @@                                                 26 @@
 27                                                    27 
 28  printk@p(...);                                    28  printk@p(...);
 29 *WARN_ON(1);                                       29 *WARN_ON(1);
 30                                                    30 
 31 @script:python depends on org@                     31 @script:python depends on org@
 32 p << r1.p;                                         32 p << r1.p;
 33 @@                                                 33 @@
 34                                                    34 
 35 cocci.print_main("printk + WARN_ON can be just     35 cocci.print_main("printk + WARN_ON can be just WARN",p)
 36                                                    36 
 37 @script:python depends on report@                  37 @script:python depends on report@
 38 p << r1.p;                                         38 p << r1.p;
 39 @@                                                 39 @@
 40                                                    40 
 41 msg = "SUGGESTION: printk + WARN_ON can be jus     41 msg = "SUGGESTION: printk + WARN_ON can be just WARN"
 42 coccilib.report.print_report(p[0],msg)             42 coccilib.report.print_report(p[0],msg)
 43                                                    43 
 44 @ok1 depends on patch@                             44 @ok1 depends on patch@
 45 expression list es;                                45 expression list es;
 46 position p != bad1.p;                              46 position p != bad1.p;
 47 @@                                                 47 @@
 48                                                    48 
 49 -printk@p(                                         49 -printk@p(
 50 +WARN(1,                                           50 +WARN(1,
 51   es);                                             51   es);
 52 -WARN_ON(1);                                       52 -WARN_ON(1);
 53                                                    53 
 54 @depends on patch@                                 54 @depends on patch@
 55 expression list ok1.es;                            55 expression list ok1.es;
 56 @@                                                 56 @@
 57                                                    57 
 58 if (...)                                           58 if (...)
 59 - {                                                59 - {
 60   WARN(1,es);                                      60   WARN(1,es);
 61 - }                                                61 - }
 62                                                    62 
 63 // -------------------------------------------     63 // --------------------------------------------------------------------
 64                                                    64 
 65 @bad2@                                             65 @bad2@
 66 position p;                                        66 position p;
 67 @@                                                 67 @@
 68                                                    68 
 69 printk(...);                                       69 printk(...);
 70 printk@p(...);                                     70 printk@p(...);
 71 WARN_ON_ONCE(1);                                   71 WARN_ON_ONCE(1);
 72                                                    72 
 73 @r2 depends on context || report || org@           73 @r2 depends on context || report || org@
 74 position p != bad1.p;                              74 position p != bad1.p;
 75 @@                                                 75 @@
 76                                                    76 
 77  printk@p(...);                                    77  printk@p(...);
 78 *WARN_ON_ONCE(1);                                  78 *WARN_ON_ONCE(1);
 79                                                    79 
 80 @script:python depends on org@                     80 @script:python depends on org@
 81 p << r2.p;                                         81 p << r2.p;
 82 @@                                                 82 @@
 83                                                    83 
 84 cocci.print_main("printk + WARN_ON_ONCE can be     84 cocci.print_main("printk + WARN_ON_ONCE can be just WARN_ONCE",p)
 85                                                    85 
 86 @script:python depends on report@                  86 @script:python depends on report@
 87 p << r2.p;                                         87 p << r2.p;
 88 @@                                                 88 @@
 89                                                    89 
 90 msg = "SUGGESTION: printk + WARN_ON_ONCE can b     90 msg = "SUGGESTION: printk + WARN_ON_ONCE can be just WARN_ONCE"
 91 coccilib.report.print_report(p[0],msg)             91 coccilib.report.print_report(p[0],msg)
 92                                                    92 
 93 @ok2 depends on patch@                             93 @ok2 depends on patch@
 94 expression list es;                                94 expression list es;
 95 position p != bad2.p;                              95 position p != bad2.p;
 96 @@                                                 96 @@
 97                                                    97 
 98 -printk@p(                                         98 -printk@p(
 99 +WARN_ONCE(1,                                      99 +WARN_ONCE(1,
100   es);                                            100   es);
101 -WARN_ON_ONCE(1);                                 101 -WARN_ON_ONCE(1);
102                                                   102 
103 @depends on patch@                                103 @depends on patch@
104 expression list ok2.es;                           104 expression list ok2.es;
105 @@                                                105 @@
106                                                   106 
107 if (...)                                          107 if (...)
108 - {                                               108 - {
109   WARN_ONCE(1,es);                                109   WARN_ONCE(1,es);
110 - }                                               110 - }
                                                      

~ [ source navigation ] ~ [ diff markup ] ~ [ identifier search ] ~

kernel.org | git.kernel.org | LWN.net | Project Home | SVN repository | Mail admin

Linux® is a registered trademark of Linus Torvalds in the United States and other countries.
TOMOYO® is a registered trademark of NTT DATA CORPORATION.

sflogo.php