1 // SPDX-License-Identifier: GPL-2.0-only <<
2 /// This semantic patch looks for kmalloc etc 1 /// This semantic patch looks for kmalloc etc that are not followed by a
3 /// NULL check. It only gives a report in the 2 /// NULL check. It only gives a report in the case where there is some
4 /// error handling code later in the function, 3 /// error handling code later in the function, which may be helpful
5 /// in determining what the error handling cod 4 /// in determining what the error handling code for the call to kmalloc etc
6 /// should be. 5 /// should be.
7 /// 6 ///
8 // Confidence: High 7 // Confidence: High
9 // Copyright: (C) 2010 Nicolas Palix, DIKU. !! 8 // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2.
10 // Copyright: (C) 2010 Julia Lawall, DIKU. !! 9 // Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2.
11 // Copyright: (C) 2010 Gilles Muller, INRIA/Li !! 10 // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2.
12 // URL: https://coccinelle.gitlabpages.inria.f !! 11 // URL: http://coccinelle.lip6.fr/
13 // Comments: 12 // Comments:
14 // Options: --no-includes --include-headers 13 // Options: --no-includes --include-headers
15 14
16 virtual context 15 virtual context
17 virtual org 16 virtual org
18 virtual report 17 virtual report
19 18
20 @withtest@ 19 @withtest@
21 expression x; 20 expression x;
22 position p; 21 position p;
23 identifier f,fld; 22 identifier f,fld;
24 @@ 23 @@
25 24
26 x@p = f(...); 25 x@p = f(...);
27 ... when != x->fld 26 ... when != x->fld
28 \(x == NULL \| x != NULL\) 27 \(x == NULL \| x != NULL\)
29 28
30 @fixed depends on context && !org && !report@ 29 @fixed depends on context && !org && !report@
31 expression x,x1; 30 expression x,x1;
32 position p1 != withtest.p; 31 position p1 != withtest.p;
33 statement S; 32 statement S;
34 position any withtest.p; 33 position any withtest.p;
35 identifier f; 34 identifier f;
36 @@ 35 @@
37 36
38 *x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); 37 *x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
39 ... 38 ...
40 *x1@p = f(...); 39 *x1@p = f(...);
41 if (!x1) S 40 if (!x1) S
42 41
43 // ------------------------------------------- 42 // ------------------------------------------------------------------------
44 43
45 @rfixed depends on (org || report) && !context 44 @rfixed depends on (org || report) && !context exists@
46 expression x,x1; 45 expression x,x1;
47 position p1 != withtest.p; 46 position p1 != withtest.p;
48 position p2; 47 position p2;
49 statement S; 48 statement S;
50 position any withtest.p; 49 position any withtest.p;
51 identifier f; 50 identifier f;
52 @@ 51 @@
53 52
54 x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); 53 x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
55 ... 54 ...
56 x1@p = f@p2(...); 55 x1@p = f@p2(...);
57 if (!x1) S 56 if (!x1) S
58 57
59 @script:python depends on org@ 58 @script:python depends on org@
60 p1 << rfixed.p1; 59 p1 << rfixed.p1;
61 p2 << rfixed.p2; 60 p2 << rfixed.p2;
62 @@ 61 @@
63 62
64 cocci.print_main("alloc call",p1) 63 cocci.print_main("alloc call",p1)
65 cocci.print_secs("possible model",p2) 64 cocci.print_secs("possible model",p2)
66 65
67 @script:python depends on report@ 66 @script:python depends on report@
68 p1 << rfixed.p1; 67 p1 << rfixed.p1;
69 p2 << rfixed.p2; 68 p2 << rfixed.p2;
70 @@ 69 @@
71 70
72 msg = "alloc with no test, possible model on l 71 msg = "alloc with no test, possible model on line %s" % (p2[0].line)
73 coccilib.report.print_report(p1[0],msg) 72 coccilib.report.print_report(p1[0],msg)
Linux® is a registered trademark of Linus Torvalds in the United States and other countries.
TOMOYO® is a registered trademark of NTT DATA CORPORATION.