1 #!/usr/bin/env perl 1 #!/usr/bin/env perl
2 # SPDX-License-Identifier: GPL-2.0-or-later 2 # SPDX-License-Identifier: GPL-2.0-or-later
3 use strict; 3 use strict;
4 4
5 # Copyright (c) 2017-2020 Mauro Carvalho Cheha< 5 # Copyright (c) 2017-2020 Mauro Carvalho Chehab <mchehab@kernel.org>
6 # 6 #
7 7
8 my $prefix = "./"; 8 my $prefix = "./";
9 $prefix = "$ENV{'srctree'}/" if ($ENV{'srctree 9 $prefix = "$ENV{'srctree'}/" if ($ENV{'srctree'});
10 10
11 my $conf = $prefix . "Documentation/conf.py"; 11 my $conf = $prefix . "Documentation/conf.py";
12 my $requirement_file = $prefix . "Documentatio 12 my $requirement_file = $prefix . "Documentation/sphinx/requirements.txt";
13 my $virtenv_prefix = "sphinx_"; 13 my $virtenv_prefix = "sphinx_";
14 14
15 # 15 #
16 # Static vars 16 # Static vars
17 # 17 #
18 18
19 my %missing; 19 my %missing;
20 my $system_release; 20 my $system_release;
21 my $need = 0; 21 my $need = 0;
22 my $optional = 0; 22 my $optional = 0;
23 my $need_symlink = 0; 23 my $need_symlink = 0;
24 my $need_sphinx = 0; 24 my $need_sphinx = 0;
25 my $need_pip = 0; 25 my $need_pip = 0;
26 my $need_virtualenv = 0; 26 my $need_virtualenv = 0;
27 my $rec_sphinx_upgrade = 0; 27 my $rec_sphinx_upgrade = 0;
28 my $verbose_warn_install = 1; 28 my $verbose_warn_install = 1;
29 my $install = ""; 29 my $install = "";
30 my $virtenv_dir = ""; 30 my $virtenv_dir = "";
31 my $python_cmd = ""; 31 my $python_cmd = "";
32 my $activate_cmd; 32 my $activate_cmd;
33 my $min_version; 33 my $min_version;
34 my $cur_version; 34 my $cur_version;
35 my $rec_version = "3.4.3"; 35 my $rec_version = "3.4.3";
36 my $latest_avail_ver; 36 my $latest_avail_ver;
37 37
38 # 38 #
39 # Command line arguments 39 # Command line arguments
40 # 40 #
41 41
42 my $pdf = 1; 42 my $pdf = 1;
43 my $virtualenv = 1; 43 my $virtualenv = 1;
44 my $version_check = 0; 44 my $version_check = 0;
45 45
46 # 46 #
47 # List of required texlive packages on Fedora 47 # List of required texlive packages on Fedora and OpenSuse
48 # 48 #
49 49
50 my %texlive = ( 50 my %texlive = (
51 'amsfonts.sty' => 'texlive-amsfo 51 'amsfonts.sty' => 'texlive-amsfonts',
52 'amsmath.sty' => 'texlive-amsma 52 'amsmath.sty' => 'texlive-amsmath',
53 'amssymb.sty' => 'texlive-amsfo 53 'amssymb.sty' => 'texlive-amsfonts',
54 'amsthm.sty' => 'texlive-amscl 54 'amsthm.sty' => 'texlive-amscls',
55 'anyfontsize.sty' => 'texlive-anyfo 55 'anyfontsize.sty' => 'texlive-anyfontsize',
56 'atbegshi.sty' => 'texlive-oberd 56 'atbegshi.sty' => 'texlive-oberdiek',
57 'bm.sty' => 'texlive-tools 57 'bm.sty' => 'texlive-tools',
58 'capt-of.sty' => 'texlive-capt- 58 'capt-of.sty' => 'texlive-capt-of',
59 'cmap.sty' => 'texlive-cmap' 59 'cmap.sty' => 'texlive-cmap',
60 'ecrm1000.tfm' => 'texlive-ec', 60 'ecrm1000.tfm' => 'texlive-ec',
61 'eqparbox.sty' => 'texlive-eqpar 61 'eqparbox.sty' => 'texlive-eqparbox',
62 'eu1enc.def' => 'texlive-euenc 62 'eu1enc.def' => 'texlive-euenc',
63 'fancybox.sty' => 'texlive-fancy 63 'fancybox.sty' => 'texlive-fancybox',
64 'fancyvrb.sty' => 'texlive-fancy 64 'fancyvrb.sty' => 'texlive-fancyvrb',
65 'float.sty' => 'texlive-float 65 'float.sty' => 'texlive-float',
66 'fncychap.sty' => 'texlive-fncyc 66 'fncychap.sty' => 'texlive-fncychap',
67 'footnote.sty' => 'texlive-mdwto 67 'footnote.sty' => 'texlive-mdwtools',
68 'framed.sty' => 'texlive-frame 68 'framed.sty' => 'texlive-framed',
69 'luatex85.sty' => 'texlive-luate 69 'luatex85.sty' => 'texlive-luatex85',
70 'multirow.sty' => 'texlive-multi 70 'multirow.sty' => 'texlive-multirow',
71 'needspace.sty' => 'texlive-needs 71 'needspace.sty' => 'texlive-needspace',
72 'palatino.sty' => 'texlive-psnfs 72 'palatino.sty' => 'texlive-psnfss',
73 'parskip.sty' => 'texlive-parsk 73 'parskip.sty' => 'texlive-parskip',
74 'polyglossia.sty' => 'texlive-polyg 74 'polyglossia.sty' => 'texlive-polyglossia',
75 'tabulary.sty' => 'texlive-tabul 75 'tabulary.sty' => 'texlive-tabulary',
76 'threeparttable.sty' => 'texlive-three 76 'threeparttable.sty' => 'texlive-threeparttable',
77 'titlesec.sty' => 'texlive-title 77 'titlesec.sty' => 'texlive-titlesec',
78 'ucs.sty' => 'texlive-ucs', 78 'ucs.sty' => 'texlive-ucs',
79 'upquote.sty' => 'texlive-upquo 79 'upquote.sty' => 'texlive-upquote',
80 'wrapfig.sty' => 'texlive-wrapf 80 'wrapfig.sty' => 'texlive-wrapfig',
81 'ctexhook.sty' => 'texlive-ctex' 81 'ctexhook.sty' => 'texlive-ctex',
82 ); 82 );
83 83
84 # 84 #
85 # Subroutines that checks if a feature exists 85 # Subroutines that checks if a feature exists
86 # 86 #
87 87
88 sub check_missing(%) 88 sub check_missing(%)
89 { 89 {
90 my %map = %{$_[0]}; 90 my %map = %{$_[0]};
91 91
92 foreach my $prog (sort keys %missing) 92 foreach my $prog (sort keys %missing) {
93 my $is_optional = $missing{$pr 93 my $is_optional = $missing{$prog};
94 94
95 # At least on some LTS distros 95 # At least on some LTS distros like CentOS 7, texlive doesn't
96 # provide all packages we need 96 # provide all packages we need. When such distros are
97 # detected, we have to disable 97 # detected, we have to disable PDF output.
98 # 98 #
99 # So, we need to ignore the pa 99 # So, we need to ignore the packages that distros would
100 # need for LaTeX to work 100 # need for LaTeX to work
101 if ($is_optional == 2 && !$pdf 101 if ($is_optional == 2 && !$pdf) {
102 $optional--; 102 $optional--;
103 next; 103 next;
104 } 104 }
105 105
106 if ($verbose_warn_install) { 106 if ($verbose_warn_install) {
107 if ($is_optional) { 107 if ($is_optional) {
108 print "Warning 108 print "Warning: better to also install \"$prog\".\n";
109 } else { 109 } else {
110 print "ERROR: 110 print "ERROR: please install \"$prog\", otherwise, build won't work.\n";
111 } 111 }
112 } 112 }
113 if (defined($map{$prog})) { 113 if (defined($map{$prog})) {
114 $install .= " " . $map 114 $install .= " " . $map{$prog};
115 } else { 115 } else {
116 $install .= " " . $pro 116 $install .= " " . $prog;
117 } 117 }
118 } 118 }
119 119
120 $install =~ s/^\s//; 120 $install =~ s/^\s//;
121 } 121 }
122 122
123 sub add_package($$) 123 sub add_package($$)
124 { 124 {
125 my $package = shift; 125 my $package = shift;
126 my $is_optional = shift; 126 my $is_optional = shift;
127 127
128 $missing{$package} = $is_optional; 128 $missing{$package} = $is_optional;
129 if ($is_optional) { 129 if ($is_optional) {
130 $optional++; 130 $optional++;
131 } else { 131 } else {
132 $need++; 132 $need++;
133 } 133 }
134 } 134 }
135 135
136 sub check_missing_file($$$) 136 sub check_missing_file($$$)
137 { 137 {
138 my $files = shift; 138 my $files = shift;
139 my $package = shift; 139 my $package = shift;
140 my $is_optional = shift; 140 my $is_optional = shift;
141 141
142 for (@$files) { 142 for (@$files) {
143 return if(-e $_); 143 return if(-e $_);
144 } 144 }
145 145
146 add_package($package, $is_optional); 146 add_package($package, $is_optional);
147 } 147 }
148 148
149 sub findprog($) 149 sub findprog($)
150 { 150 {
151 foreach(split(/:/, $ENV{PATH})) { 151 foreach(split(/:/, $ENV{PATH})) {
152 return "$_/$_[0]" if(-x "$_/$_ 152 return "$_/$_[0]" if(-x "$_/$_[0]");
153 } 153 }
154 } 154 }
155 155
156 sub find_python_no_venv() 156 sub find_python_no_venv()
157 { 157 {
158 my $prog = shift; 158 my $prog = shift;
159 159
160 my $cur_dir = qx(pwd); 160 my $cur_dir = qx(pwd);
161 $cur_dir =~ s/\s+$//; 161 $cur_dir =~ s/\s+$//;
162 162
163 foreach my $dir (split(/:/, $ENV{PATH} 163 foreach my $dir (split(/:/, $ENV{PATH})) {
164 next if ($dir =~ m,($cur_dir)/ 164 next if ($dir =~ m,($cur_dir)/sphinx,);
165 return "$dir/python3" if(-x "$ 165 return "$dir/python3" if(-x "$dir/python3");
166 } 166 }
167 foreach my $dir (split(/:/, $ENV{PATH} 167 foreach my $dir (split(/:/, $ENV{PATH})) {
168 next if ($dir =~ m,($cur_dir)/ 168 next if ($dir =~ m,($cur_dir)/sphinx,);
169 return "$dir/python" if(-x "$d 169 return "$dir/python" if(-x "$dir/python");
170 } 170 }
171 return "python"; 171 return "python";
172 } 172 }
173 173
174 sub check_program($$) 174 sub check_program($$)
175 { 175 {
176 my $prog = shift; 176 my $prog = shift;
177 my $is_optional = shift; 177 my $is_optional = shift;
178 178
179 return $prog if findprog($prog); 179 return $prog if findprog($prog);
180 180
181 add_package($prog, $is_optional); 181 add_package($prog, $is_optional);
182 } 182 }
183 183
184 sub check_perl_module($$) 184 sub check_perl_module($$)
185 { 185 {
186 my $prog = shift; 186 my $prog = shift;
187 my $is_optional = shift; 187 my $is_optional = shift;
188 188
189 my $err = system("perl -M$prog -e 1 2> 189 my $err = system("perl -M$prog -e 1 2>/dev/null /dev/null");
190 return if ($err == 0); 190 return if ($err == 0);
191 191
192 add_package($prog, $is_optional); 192 add_package($prog, $is_optional);
193 } 193 }
194 194
195 sub check_python_module($$) 195 sub check_python_module($$)
196 { 196 {
197 my $prog = shift; 197 my $prog = shift;
198 my $is_optional = shift; 198 my $is_optional = shift;
199 199
200 return if (!$python_cmd); 200 return if (!$python_cmd);
201 201
202 my $err = system("$python_cmd -c 'impo 202 my $err = system("$python_cmd -c 'import $prog' 2>/dev/null /dev/null");
203 return if ($err == 0); 203 return if ($err == 0);
204 204
205 add_package($prog, $is_optional); 205 add_package($prog, $is_optional);
206 } 206 }
207 207
208 sub check_rpm_missing($$) 208 sub check_rpm_missing($$)
209 { 209 {
210 my @pkgs = @{$_[0]}; 210 my @pkgs = @{$_[0]};
211 my $is_optional = $_[1]; 211 my $is_optional = $_[1];
212 212
213 foreach my $prog(@pkgs) { 213 foreach my $prog(@pkgs) {
214 my $err = system("rpm -q '$pro 214 my $err = system("rpm -q '$prog' 2>/dev/null >/dev/null");
215 add_package($prog, $is_optiona 215 add_package($prog, $is_optional) if ($err);
216 } 216 }
217 } 217 }
218 218
219 sub check_pacman_missing($$) 219 sub check_pacman_missing($$)
220 { 220 {
221 my @pkgs = @{$_[0]}; 221 my @pkgs = @{$_[0]};
222 my $is_optional = $_[1]; 222 my $is_optional = $_[1];
223 223
224 foreach my $prog(@pkgs) { 224 foreach my $prog(@pkgs) {
225 my $err = system("pacman -Q '$ 225 my $err = system("pacman -Q '$prog' 2>/dev/null >/dev/null");
226 add_package($prog, $is_optiona 226 add_package($prog, $is_optional) if ($err);
227 } 227 }
228 } 228 }
229 229
230 sub check_missing_tex($) 230 sub check_missing_tex($)
231 { 231 {
232 my $is_optional = shift; 232 my $is_optional = shift;
233 my $kpsewhich = findprog("kpsewhich"); 233 my $kpsewhich = findprog("kpsewhich");
234 234
235 foreach my $prog(keys %texlive) { 235 foreach my $prog(keys %texlive) {
236 my $package = $texlive{$prog}; 236 my $package = $texlive{$prog};
237 if (!$kpsewhich) { 237 if (!$kpsewhich) {
238 add_package($package, 238 add_package($package, $is_optional);
239 next; 239 next;
240 } 240 }
241 my $file = qx($kpsewhich $prog 241 my $file = qx($kpsewhich $prog);
242 add_package($package, $is_opti 242 add_package($package, $is_optional) if ($file =~ /^\s*$/);
243 } 243 }
244 } 244 }
245 245
246 sub get_sphinx_fname() 246 sub get_sphinx_fname()
247 { 247 {
248 my $fname = "sphinx-build"; 248 my $fname = "sphinx-build";
249 return $fname if findprog($fname); 249 return $fname if findprog($fname);
250 250
251 $fname = "sphinx-build-3"; 251 $fname = "sphinx-build-3";
252 if (findprog($fname)) { 252 if (findprog($fname)) {
253 $need_symlink = 1; 253 $need_symlink = 1;
254 return $fname; 254 return $fname;
255 } 255 }
256 256
257 return ""; 257 return "";
258 } 258 }
259 259
260 sub get_sphinx_version($) 260 sub get_sphinx_version($)
261 { 261 {
262 my $cmd = shift; 262 my $cmd = shift;
263 my $ver; 263 my $ver;
264 264
265 open IN, "$cmd --version 2>&1 |"; 265 open IN, "$cmd --version 2>&1 |";
266 while (<IN>) { 266 while (<IN>) {
267 if (m/^\s*sphinx-build\s+([\d\ 267 if (m/^\s*sphinx-build\s+([\d\.]+)((\+\/[\da-f]+)|(b\d+))?$/) {
268 $ver=$1; 268 $ver=$1;
269 last; 269 last;
270 } 270 }
271 # Sphinx 1.2.x uses a differen 271 # Sphinx 1.2.x uses a different format
272 if (m/^\s*Sphinx.*\s+([\d\.]+) 272 if (m/^\s*Sphinx.*\s+([\d\.]+)$/) {
273 $ver=$1; 273 $ver=$1;
274 last; 274 last;
275 } 275 }
276 } 276 }
277 close IN; 277 close IN;
278 return $ver; 278 return $ver;
279 } 279 }
280 280
281 sub check_sphinx() 281 sub check_sphinx()
282 { 282 {
283 open IN, $conf or die "Can't open $con 283 open IN, $conf or die "Can't open $conf";
284 while (<IN>) { 284 while (<IN>) {
285 if (m/^\s*needs_sphinx\s*=\s*[ 285 if (m/^\s*needs_sphinx\s*=\s*[\'\"]([\d\.]+)[\'\"]/) {
286 $min_version=$1; 286 $min_version=$1;
287 last; 287 last;
288 } 288 }
289 } 289 }
290 close IN; 290 close IN;
291 291
292 die "Can't get needs_sphinx version fr 292 die "Can't get needs_sphinx version from $conf" if (!$min_version);
293 293
294 $virtenv_dir = $virtenv_prefix . "late 294 $virtenv_dir = $virtenv_prefix . "latest";
295 295
296 my $sphinx = get_sphinx_fname(); 296 my $sphinx = get_sphinx_fname();
297 if ($sphinx eq "") { 297 if ($sphinx eq "") {
298 $need_sphinx = 1; 298 $need_sphinx = 1;
299 return; 299 return;
300 } 300 }
301 301
302 $cur_version = get_sphinx_version($sph 302 $cur_version = get_sphinx_version($sphinx);
>> 303 die ("$sphinx returned an error") if (!$cur_version);
>> 304
303 die "$sphinx didn't return its version 305 die "$sphinx didn't return its version" if (!$cur_version);
304 306
305 if ($cur_version lt $min_version) { 307 if ($cur_version lt $min_version) {
306 printf "ERROR: Sphinx version 308 printf "ERROR: Sphinx version is %s. It should be >= %s\n",
307 $cur_version, $min_vers 309 $cur_version, $min_version;
308 $need_sphinx = 1; 310 $need_sphinx = 1;
309 return; 311 return;
310 } 312 }
311 313
312 return if ($cur_version lt $rec_versio 314 return if ($cur_version lt $rec_version);
313 315
314 # On version check mode, just assume S 316 # On version check mode, just assume Sphinx has all mandatory deps
315 exit (0) if ($version_check); 317 exit (0) if ($version_check);
316 } 318 }
317 319
318 # 320 #
319 # Ancillary subroutines 321 # Ancillary subroutines
320 # 322 #
321 323
322 sub catcheck($) 324 sub catcheck($)
323 { 325 {
324 my $res = ""; 326 my $res = "";
325 $res = qx(cat $_[0]) if (-r $_[0]); 327 $res = qx(cat $_[0]) if (-r $_[0]);
326 return $res; 328 return $res;
327 } 329 }
328 330
329 sub which($) 331 sub which($)
330 { 332 {
331 my $file = shift; 333 my $file = shift;
332 my @path = split ":", $ENV{PATH}; 334 my @path = split ":", $ENV{PATH};
333 335
334 foreach my $dir(@path) { 336 foreach my $dir(@path) {
335 my $name = $dir.'/'.$file; 337 my $name = $dir.'/'.$file;
336 return $name if (-x $name ); 338 return $name if (-x $name );
337 } 339 }
338 return undef; 340 return undef;
339 } 341 }
340 342
341 # 343 #
342 # Subroutines that check distro-specific hints 344 # Subroutines that check distro-specific hints
343 # 345 #
344 346
345 sub give_debian_hints() 347 sub give_debian_hints()
346 { 348 {
347 my %map = ( 349 my %map = (
348 "python-sphinx" => "py 350 "python-sphinx" => "python3-sphinx",
349 "yaml" => "py 351 "yaml" => "python3-yaml",
350 "ensurepip" => "py 352 "ensurepip" => "python3-venv",
351 "virtualenv" => "vi 353 "virtualenv" => "virtualenv",
352 "dot" => "gr 354 "dot" => "graphviz",
353 "convert" => "im 355 "convert" => "imagemagick",
354 "Pod::Usage" => "pe 356 "Pod::Usage" => "perl-modules",
355 "xelatex" => "te 357 "xelatex" => "texlive-xetex",
356 "rsvg-convert" => "li 358 "rsvg-convert" => "librsvg2-bin",
357 ); 359 );
358 360
359 if ($pdf) { 361 if ($pdf) {
360 check_missing_file(["/usr/shar 362 check_missing_file(["/usr/share/texlive/texmf-dist/tex/latex/ctex/ctexhook.sty"],
361 "texlive-la 363 "texlive-lang-chinese", 2);
362 364
363 check_missing_file(["/usr/shar 365 check_missing_file(["/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf"],
364 "fonts-deja 366 "fonts-dejavu", 2);
365 367
366 check_missing_file(["/usr/shar 368 check_missing_file(["/usr/share/fonts/noto-cjk/NotoSansCJK-Regular.ttc",
367 "/usr/shar 369 "/usr/share/fonts/opentype/noto/NotoSansCJK-Regular.ttc",
368 "/usr/shar 370 "/usr/share/fonts/opentype/noto/NotoSerifCJK-Regular.ttc"],
369 "fonts-noto 371 "fonts-noto-cjk", 2);
370 } 372 }
371 373
372 check_program("dvipng", 2) if ($pdf); 374 check_program("dvipng", 2) if ($pdf);
373 check_missing(\%map); 375 check_missing(\%map);
374 376
375 return if (!$need && !$optional); 377 return if (!$need && !$optional);
376 printf("You should run:\n") if ($verbo 378 printf("You should run:\n") if ($verbose_warn_install);
377 printf("\n\tsudo apt-get install $inst 379 printf("\n\tsudo apt-get install $install\n");
378 } 380 }
379 381
380 sub give_redhat_hints() 382 sub give_redhat_hints()
381 { 383 {
382 my %map = ( 384 my %map = (
383 "python-sphinx" => "py 385 "python-sphinx" => "python3-sphinx",
384 "yaml" => "py 386 "yaml" => "python3-pyyaml",
385 "virtualenv" => "py 387 "virtualenv" => "python3-virtualenv",
386 "dot" => "gr 388 "dot" => "graphviz",
387 "convert" => "Im 389 "convert" => "ImageMagick",
388 "Pod::Usage" => "pe 390 "Pod::Usage" => "perl-Pod-Usage",
389 "xelatex" => "te 391 "xelatex" => "texlive-xetex-bin",
390 "rsvg-convert" => "li 392 "rsvg-convert" => "librsvg2-tools",
391 ); 393 );
392 394
393 my @fedora26_opt_pkgs = ( 395 my @fedora26_opt_pkgs = (
394 "graphviz-gd", # Fedo 396 "graphviz-gd", # Fedora 26: needed for PDF support
395 ); 397 );
396 398
397 my @fedora_tex_pkgs = ( 399 my @fedora_tex_pkgs = (
398 "texlive-collection-fontsrecom 400 "texlive-collection-fontsrecommended",
399 "texlive-collection-latex", 401 "texlive-collection-latex",
400 "texlive-xecjk", 402 "texlive-xecjk",
401 "dejavu-sans-fonts", 403 "dejavu-sans-fonts",
402 "dejavu-serif-fonts", 404 "dejavu-serif-fonts",
403 "dejavu-sans-mono-fonts", 405 "dejavu-sans-mono-fonts",
404 ); 406 );
405 407
406 # 408 #
407 # Checks valid for RHEL/CentOS version 409 # Checks valid for RHEL/CentOS version 7.x.
408 # 410 #
409 my $old = 0; 411 my $old = 0;
410 my $rel; 412 my $rel;
411 my $noto_sans_redhat = "google-noto-sa 413 my $noto_sans_redhat = "google-noto-sans-cjk-ttc-fonts";
412 $rel = $1 if ($system_release =~ /rele 414 $rel = $1 if ($system_release =~ /release\s+(\d+)/);
413 415
414 if (!($system_release =~ /Fedora/)) { 416 if (!($system_release =~ /Fedora/)) {
415 $map{"virtualenv"} = "python-v 417 $map{"virtualenv"} = "python-virtualenv";
416 418
417 if ($rel && $rel < 8) { 419 if ($rel && $rel < 8) {
418 $old = 1; 420 $old = 1;
419 $pdf = 0; 421 $pdf = 0;
420 422
421 printf("Note: texlive 423 printf("Note: texlive packages on RHEL/CENTOS <= 7 are incomplete. Can't support PDF output\n");
422 printf("If you want to 424 printf("If you want to build PDF, please read:\n");
423 printf("\thttps://www. 425 printf("\thttps://www.systutorials.com/241660/how-to-install-tex-live-on-centos-7-linux/\n");
424 } 426 }
425 } else { 427 } else {
426 if ($rel && $rel < 26) { 428 if ($rel && $rel < 26) {
427 $old = 1; 429 $old = 1;
428 } 430 }
429 if ($rel && $rel >= 38) { 431 if ($rel && $rel >= 38) {
430 $noto_sans_redhat = "g 432 $noto_sans_redhat = "google-noto-sans-cjk-fonts";
431 } 433 }
432 } 434 }
433 if (!$rel) { 435 if (!$rel) {
434 printf("Couldn't identify rele 436 printf("Couldn't identify release number\n");
435 $old = 1; 437 $old = 1;
436 $pdf = 0; 438 $pdf = 0;
437 } 439 }
438 440
439 if ($pdf) { 441 if ($pdf) {
440 check_missing_file(["/usr/shar 442 check_missing_file(["/usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc",
441 "/usr/shar 443 "/usr/share/fonts/google-noto-sans-cjk-fonts/NotoSansCJK-Regular.ttc"],
442 $noto_sans_ 444 $noto_sans_redhat, 2);
443 } 445 }
444 446
445 check_rpm_missing(\@fedora26_opt_pkgs, 447 check_rpm_missing(\@fedora26_opt_pkgs, 2) if ($pdf && !$old);
446 check_rpm_missing(\@fedora_tex_pkgs, 2 448 check_rpm_missing(\@fedora_tex_pkgs, 2) if ($pdf);
447 check_missing_tex(2) if ($pdf); 449 check_missing_tex(2) if ($pdf);
448 check_missing(\%map); 450 check_missing(\%map);
449 451
450 return if (!$need && !$optional); 452 return if (!$need && !$optional);
451 453
452 if (!$old) { 454 if (!$old) {
453 # dnf, for Fedora 18+ 455 # dnf, for Fedora 18+
454 printf("You should run:\n") if 456 printf("You should run:\n") if ($verbose_warn_install);
455 printf("\n\tsudo dnf install - 457 printf("\n\tsudo dnf install -y $install\n");
456 } else { 458 } else {
457 # yum, for RHEL (and clones) o 459 # yum, for RHEL (and clones) or Fedora version < 18
458 printf("You should run:\n") if 460 printf("You should run:\n") if ($verbose_warn_install);
459 printf("\n\tsudo yum install - 461 printf("\n\tsudo yum install -y $install\n");
460 } 462 }
461 } 463 }
462 464
463 sub give_opensuse_hints() 465 sub give_opensuse_hints()
464 { 466 {
465 my %map = ( 467 my %map = (
466 "python-sphinx" => "py 468 "python-sphinx" => "python3-sphinx",
467 "yaml" => "py 469 "yaml" => "python3-pyyaml",
468 "virtualenv" => "py 470 "virtualenv" => "python3-virtualenv",
469 "dot" => "gr 471 "dot" => "graphviz",
470 "convert" => "Im 472 "convert" => "ImageMagick",
471 "Pod::Usage" => "pe 473 "Pod::Usage" => "perl-Pod-Usage",
472 "xelatex" => "te 474 "xelatex" => "texlive-xetex-bin",
473 ); 475 );
474 476
475 # On Tumbleweed, this package is also 477 # On Tumbleweed, this package is also named rsvg-convert
476 $map{"rsvg-convert"} = "rsvg-view" if 478 $map{"rsvg-convert"} = "rsvg-view" if (!($system_release =~ /Tumbleweed/));
477 479
478 my @suse_tex_pkgs = ( 480 my @suse_tex_pkgs = (
479 "texlive-babel-english", 481 "texlive-babel-english",
480 "texlive-caption", 482 "texlive-caption",
481 "texlive-colortbl", 483 "texlive-colortbl",
482 "texlive-courier", 484 "texlive-courier",
483 "texlive-dvips", 485 "texlive-dvips",
484 "texlive-helvetic", 486 "texlive-helvetic",
485 "texlive-makeindex", 487 "texlive-makeindex",
486 "texlive-metafont", 488 "texlive-metafont",
487 "texlive-metapost", 489 "texlive-metapost",
488 "texlive-palatino", 490 "texlive-palatino",
489 "texlive-preview", 491 "texlive-preview",
490 "texlive-times", 492 "texlive-times",
491 "texlive-zapfchan", 493 "texlive-zapfchan",
492 "texlive-zapfding", 494 "texlive-zapfding",
493 ); 495 );
494 496
495 $map{"latexmk"} = "texlive-latexmk-bin 497 $map{"latexmk"} = "texlive-latexmk-bin";
496 498
497 # FIXME: add support for installing CJ 499 # FIXME: add support for installing CJK fonts
498 # 500 #
499 # I tried hard, but was unable to find 501 # I tried hard, but was unable to find a way to install
500 # "Noto Sans CJK SC" on openSUSE 502 # "Noto Sans CJK SC" on openSUSE
501 503
502 check_rpm_missing(\@suse_tex_pkgs, 2) 504 check_rpm_missing(\@suse_tex_pkgs, 2) if ($pdf);
503 check_missing_tex(2) if ($pdf); 505 check_missing_tex(2) if ($pdf);
504 check_missing(\%map); 506 check_missing(\%map);
505 507
506 return if (!$need && !$optional); 508 return if (!$need && !$optional);
507 printf("You should run:\n") if ($verbo 509 printf("You should run:\n") if ($verbose_warn_install);
508 printf("\n\tsudo zypper install --no-r 510 printf("\n\tsudo zypper install --no-recommends $install\n");
509 } 511 }
510 512
511 sub give_mageia_hints() 513 sub give_mageia_hints()
512 { 514 {
513 my %map = ( 515 my %map = (
514 "python-sphinx" => "py 516 "python-sphinx" => "python3-sphinx",
515 "yaml" => "py 517 "yaml" => "python3-yaml",
516 "virtualenv" => "py 518 "virtualenv" => "python3-virtualenv",
517 "dot" => "gr 519 "dot" => "graphviz",
518 "convert" => "Im 520 "convert" => "ImageMagick",
519 "Pod::Usage" => "pe 521 "Pod::Usage" => "perl-Pod-Usage",
520 "xelatex" => "te 522 "xelatex" => "texlive",
521 "rsvg-convert" => "li 523 "rsvg-convert" => "librsvg2",
522 ); 524 );
523 525
524 my @tex_pkgs = ( 526 my @tex_pkgs = (
525 "texlive-fontsextra", 527 "texlive-fontsextra",
526 ); 528 );
527 529
528 $map{"latexmk"} = "texlive-collection- 530 $map{"latexmk"} = "texlive-collection-basic";
529 531
530 my $packager_cmd; 532 my $packager_cmd;
531 my $noto_sans; 533 my $noto_sans;
532 if ($system_release =~ /OpenMandriva/) 534 if ($system_release =~ /OpenMandriva/) {
533 $packager_cmd = "dnf install"; 535 $packager_cmd = "dnf install";
534 $noto_sans = "noto-sans-cjk-fo 536 $noto_sans = "noto-sans-cjk-fonts";
535 @tex_pkgs = ( "texlive-collect 537 @tex_pkgs = ( "texlive-collection-fontsextra" );
536 } else { 538 } else {
537 $packager_cmd = "urpmi"; 539 $packager_cmd = "urpmi";
538 $noto_sans = "google-noto-sans 540 $noto_sans = "google-noto-sans-cjk-ttc-fonts";
539 } 541 }
540 542
541 543
542 if ($pdf) { 544 if ($pdf) {
543 check_missing_file(["/usr/shar 545 check_missing_file(["/usr/share/fonts/google-noto-cjk/NotoSansCJK-Regular.ttc",
544 "/usr/shar 546 "/usr/share/fonts/TTF/NotoSans-Regular.ttf"],
545 $noto_sans, 547 $noto_sans, 2);
546 } 548 }
547 549
548 check_rpm_missing(\@tex_pkgs, 2) if ($ 550 check_rpm_missing(\@tex_pkgs, 2) if ($pdf);
549 check_missing(\%map); 551 check_missing(\%map);
550 552
551 return if (!$need && !$optional); 553 return if (!$need && !$optional);
552 printf("You should run:\n") if ($verbo 554 printf("You should run:\n") if ($verbose_warn_install);
553 printf("\n\tsudo $packager_cmd $instal 555 printf("\n\tsudo $packager_cmd $install\n");
554 } 556 }
555 557
556 sub give_arch_linux_hints() 558 sub give_arch_linux_hints()
557 { 559 {
558 my %map = ( 560 my %map = (
559 "yaml" => "py 561 "yaml" => "python-yaml",
560 "virtualenv" => "py 562 "virtualenv" => "python-virtualenv",
561 "dot" => "gr 563 "dot" => "graphviz",
562 "convert" => "im 564 "convert" => "imagemagick",
563 "xelatex" => "te 565 "xelatex" => "texlive-xetex",
564 "latexmk" => "te 566 "latexmk" => "texlive-core",
565 "rsvg-convert" => "ex 567 "rsvg-convert" => "extra/librsvg",
566 ); 568 );
567 569
568 my @archlinux_tex_pkgs = ( 570 my @archlinux_tex_pkgs = (
569 "texlive-core", 571 "texlive-core",
570 "texlive-latexextra", 572 "texlive-latexextra",
571 "ttf-dejavu", 573 "ttf-dejavu",
572 ); 574 );
573 check_pacman_missing(\@archlinux_tex_p 575 check_pacman_missing(\@archlinux_tex_pkgs, 2) if ($pdf);
574 576
575 if ($pdf) { 577 if ($pdf) {
576 check_missing_file(["/usr/shar 578 check_missing_file(["/usr/share/fonts/noto-cjk/NotoSansCJK-Regular.ttc"],
577 "noto-fonts 579 "noto-fonts-cjk", 2);
578 } 580 }
579 581
580 check_missing(\%map); 582 check_missing(\%map);
581 583
582 return if (!$need && !$optional); 584 return if (!$need && !$optional);
583 printf("You should run:\n") if ($verbo 585 printf("You should run:\n") if ($verbose_warn_install);
584 printf("\n\tsudo pacman -S $install\n" 586 printf("\n\tsudo pacman -S $install\n");
585 } 587 }
586 588
587 sub give_gentoo_hints() 589 sub give_gentoo_hints()
588 { 590 {
589 my %map = ( 591 my %map = (
590 "yaml" => "de 592 "yaml" => "dev-python/pyyaml",
591 "virtualenv" => "de 593 "virtualenv" => "dev-python/virtualenv",
592 "dot" => "me 594 "dot" => "media-gfx/graphviz",
593 "convert" => "me 595 "convert" => "media-gfx/imagemagick",
594 "xelatex" => "de 596 "xelatex" => "dev-texlive/texlive-xetex media-fonts/dejavu",
595 "rsvg-convert" => "gn 597 "rsvg-convert" => "gnome-base/librsvg",
596 ); 598 );
597 599
598 check_missing_file(["/usr/share/fonts/ 600 check_missing_file(["/usr/share/fonts/dejavu/DejaVuSans.ttf"],
599 "media-fonts/dejavu 601 "media-fonts/dejavu", 2) if ($pdf);
600 602
601 if ($pdf) { 603 if ($pdf) {
602 check_missing_file(["/usr/shar 604 check_missing_file(["/usr/share/fonts/noto-cjk/NotoSansCJKsc-Regular.otf",
603 "/usr/shar 605 "/usr/share/fonts/noto-cjk/NotoSerifCJK-Regular.ttc"],
604 "media-font 606 "media-fonts/noto-cjk", 2);
605 } 607 }
606 608
607 check_missing(\%map); 609 check_missing(\%map);
608 610
609 return if (!$need && !$optional); 611 return if (!$need && !$optional);
610 612
611 printf("You should run:\n") if ($verbo 613 printf("You should run:\n") if ($verbose_warn_install);
612 printf("\n"); 614 printf("\n");
613 615
614 my $imagemagick = "media-gfx/imagemagi 616 my $imagemagick = "media-gfx/imagemagick svg png";
615 my $cairo = "media-gfx/graphviz cairo 617 my $cairo = "media-gfx/graphviz cairo pdf";
616 my $portage_imagemagick = "/etc/portag 618 my $portage_imagemagick = "/etc/portage/package.use/imagemagick";
617 my $portage_cairo = "/etc/portage/pack 619 my $portage_cairo = "/etc/portage/package.use/graphviz";
618 620
619 if (qx(grep imagemagick $portage_image 621 if (qx(grep imagemagick $portage_imagemagick 2>/dev/null) eq "") {
620 printf("\tsudo su -c 'echo \"$ 622 printf("\tsudo su -c 'echo \"$imagemagick\" > $portage_imagemagick'\n")
621 } 623 }
622 if (qx(grep graphviz $portage_cairo 2> 624 if (qx(grep graphviz $portage_cairo 2>/dev/null) eq "") {
623 printf("\tsudo su -c 'echo \"$ 625 printf("\tsudo su -c 'echo \"$cairo\" > $portage_cairo'\n");
624 } 626 }
625 627
626 printf("\tsudo emerge --ask $install\n 628 printf("\tsudo emerge --ask $install\n");
627 629
628 } 630 }
629 631
630 sub check_distros() 632 sub check_distros()
631 { 633 {
632 # Distro-specific hints 634 # Distro-specific hints
633 if ($system_release =~ /Red Hat Enterp 635 if ($system_release =~ /Red Hat Enterprise Linux/) {
634 give_redhat_hints; 636 give_redhat_hints;
635 return; 637 return;
636 } 638 }
637 if ($system_release =~ /CentOS/) { 639 if ($system_release =~ /CentOS/) {
638 give_redhat_hints; 640 give_redhat_hints;
639 return; 641 return;
640 } 642 }
641 if ($system_release =~ /Scientific Lin 643 if ($system_release =~ /Scientific Linux/) {
642 give_redhat_hints; 644 give_redhat_hints;
643 return; 645 return;
644 } 646 }
645 if ($system_release =~ /Oracle Linux S 647 if ($system_release =~ /Oracle Linux Server/) {
646 give_redhat_hints; 648 give_redhat_hints;
647 return; 649 return;
648 } 650 }
649 if ($system_release =~ /Fedora/) { 651 if ($system_release =~ /Fedora/) {
650 give_redhat_hints; 652 give_redhat_hints;
651 return; 653 return;
652 } 654 }
653 if ($system_release =~ /Ubuntu/) { 655 if ($system_release =~ /Ubuntu/) {
654 give_debian_hints; 656 give_debian_hints;
655 return; 657 return;
656 } 658 }
657 if ($system_release =~ /Debian/) { 659 if ($system_release =~ /Debian/) {
658 give_debian_hints; 660 give_debian_hints;
659 return; 661 return;
660 } 662 }
661 if ($system_release =~ /openSUSE/) { 663 if ($system_release =~ /openSUSE/) {
662 give_opensuse_hints; 664 give_opensuse_hints;
663 return; 665 return;
664 } 666 }
665 if ($system_release =~ /Mageia/) { 667 if ($system_release =~ /Mageia/) {
666 give_mageia_hints; 668 give_mageia_hints;
667 return; 669 return;
668 } 670 }
669 if ($system_release =~ /OpenMandriva/) 671 if ($system_release =~ /OpenMandriva/) {
670 give_mageia_hints; 672 give_mageia_hints;
671 return; 673 return;
672 } 674 }
673 if ($system_release =~ /Arch Linux/) { 675 if ($system_release =~ /Arch Linux/) {
674 give_arch_linux_hints; 676 give_arch_linux_hints;
675 return; 677 return;
676 } 678 }
677 if ($system_release =~ /Gentoo/) { 679 if ($system_release =~ /Gentoo/) {
678 give_gentoo_hints; 680 give_gentoo_hints;
679 return; 681 return;
680 } 682 }
681 683
682 # 684 #
683 # Fall-back to generic hint code for o 685 # Fall-back to generic hint code for other distros
684 # That's far from ideal, specially for 686 # That's far from ideal, specially for LaTeX dependencies.
685 # 687 #
686 my %map = ( 688 my %map = (
687 "sphinx-build" => "sphinx" 689 "sphinx-build" => "sphinx"
688 ); 690 );
689 check_missing_tex(2) if ($pdf); 691 check_missing_tex(2) if ($pdf);
690 check_missing(\%map); 692 check_missing(\%map);
691 print "I don't know distro $system_rel 693 print "I don't know distro $system_release.\n";
692 print "So, I can't provide you a hint 694 print "So, I can't provide you a hint with the install procedure.\n";
693 print "There are likely missing depend 695 print "There are likely missing dependencies.\n";
694 } 696 }
695 697
696 # 698 #
697 # Common dependencies 699 # Common dependencies
698 # 700 #
699 701
700 sub deactivate_help() 702 sub deactivate_help()
701 { 703 {
702 printf "\n If you want to exit the 704 printf "\n If you want to exit the virtualenv, you can use:\n";
703 printf "\tdeactivate\n"; 705 printf "\tdeactivate\n";
704 } 706 }
705 707
706 sub get_virtenv() 708 sub get_virtenv()
707 { 709 {
708 my $ver; 710 my $ver;
709 my $min_activate = "$ENV{'PWD'}/${virt 711 my $min_activate = "$ENV{'PWD'}/${virtenv_prefix}${min_version}/bin/activate";
710 my @activates = glob "$ENV{'PWD'}/${vi 712 my @activates = glob "$ENV{'PWD'}/${virtenv_prefix}*/bin/activate";
711 713
712 @activates = sort {$b cmp $a} @activat 714 @activates = sort {$b cmp $a} @activates;
713 715
714 foreach my $f (@activates) { 716 foreach my $f (@activates) {
715 next if ($f lt $min_activate); 717 next if ($f lt $min_activate);
716 718
717 my $sphinx_cmd = $f; 719 my $sphinx_cmd = $f;
718 $sphinx_cmd =~ s/activate/sphi 720 $sphinx_cmd =~ s/activate/sphinx-build/;
719 next if (! -f $sphinx_cmd); 721 next if (! -f $sphinx_cmd);
720 722
721 my $ver = get_sphinx_version($ 723 my $ver = get_sphinx_version($sphinx_cmd);
722 724
723 if (!$ver) { 725 if (!$ver) {
724 $f =~ s#/bin/activate# 726 $f =~ s#/bin/activate##;
725 print("Warning: virtua 727 print("Warning: virtual environment $f is not working.\nPython version upgrade? Remove it with:\n\n\trm -rf $f\n\n");
726 } 728 }
727 729
728 if ($need_sphinx && ($ver ge $ 730 if ($need_sphinx && ($ver ge $min_version)) {
729 return ($f, $ver); 731 return ($f, $ver);
730 } elsif ($ver gt $cur_version) 732 } elsif ($ver gt $cur_version) {
731 return ($f, $ver); 733 return ($f, $ver);
732 } 734 }
733 } 735 }
734 return ("", ""); 736 return ("", "");
735 } 737 }
736 738
737 sub recommend_sphinx_upgrade() 739 sub recommend_sphinx_upgrade()
738 { 740 {
739 my $venv_ver; 741 my $venv_ver;
740 742
741 # Avoid running sphinx-builds from ven 743 # Avoid running sphinx-builds from venv if $cur_version is good
742 if ($cur_version && ($cur_version ge $ 744 if ($cur_version && ($cur_version ge $rec_version)) {
743 $latest_avail_ver = $cur_versi 745 $latest_avail_ver = $cur_version;
744 return; 746 return;
745 } 747 }
746 748
747 # Get the highest version from sphinx_ 749 # Get the highest version from sphinx_*/bin/sphinx-build and the
748 # corresponding command to activate th 750 # corresponding command to activate the venv/virtenv
749 ($activate_cmd, $venv_ver) = get_virte 751 ($activate_cmd, $venv_ver) = get_virtenv();
750 752
751 # Store the highest version from Sphin 753 # Store the highest version from Sphinx existing virtualenvs
752 if (($activate_cmd ne "") && ($venv_ve 754 if (($activate_cmd ne "") && ($venv_ver gt $cur_version)) {
753 $latest_avail_ver = $venv_ver; 755 $latest_avail_ver = $venv_ver;
754 } else { 756 } else {
755 $latest_avail_ver = $cur_versi 757 $latest_avail_ver = $cur_version if ($cur_version);
756 } 758 }
757 759
758 # As we don't know package version of 760 # As we don't know package version of Sphinx, and there's no
759 # virtual environments, don't check if 761 # virtual environments, don't check if upgrades are needed
760 if (!$virtualenv) { 762 if (!$virtualenv) {
761 return if (!$latest_avail_ver) 763 return if (!$latest_avail_ver);
762 } 764 }
763 765
764 # Either there are already a virtual e 766 # Either there are already a virtual env or a new one should be created
765 $need_pip = 1; 767 $need_pip = 1;
766 768
767 return if (!$latest_avail_ver); 769 return if (!$latest_avail_ver);
768 770
769 # Return if the reason is due to an up 771 # Return if the reason is due to an upgrade or not
770 if ($latest_avail_ver lt $rec_version) 772 if ($latest_avail_ver lt $rec_version) {
771 $rec_sphinx_upgrade = 1; 773 $rec_sphinx_upgrade = 1;
772 } 774 }
773 775
774 return $latest_avail_ver; 776 return $latest_avail_ver;
775 } 777 }
776 778
777 # 779 #
778 # The logic here is complex, as it have to dea 780 # The logic here is complex, as it have to deal with different versions:
779 # - minimal supported version; 781 # - minimal supported version;
780 # - minimal PDF version; 782 # - minimal PDF version;
781 # - recommended version. 783 # - recommended version.
782 # It also needs to work fine with both distro' 784 # It also needs to work fine with both distro's package and venv/virtualenv
783 sub recommend_sphinx_version($) 785 sub recommend_sphinx_version($)
784 { 786 {
785 my $virtualenv_cmd = shift; 787 my $virtualenv_cmd = shift;
786 788
787 # Version is OK. Nothing to do. 789 # Version is OK. Nothing to do.
788 if ($cur_version && ($cur_version ge $ 790 if ($cur_version && ($cur_version ge $rec_version)) {
789 return; 791 return;
790 }; 792 };
791 793
792 if (!$need_sphinx) { 794 if (!$need_sphinx) {
793 # sphinx-build is present and 795 # sphinx-build is present and its version is >= $min_version
794 796
795 #only recommend enabling a new 797 #only recommend enabling a newer virtenv version if makes sense.
796 if ($latest_avail_ver gt $cur_ 798 if ($latest_avail_ver gt $cur_version) {
797 printf "\nYou may also 799 printf "\nYou may also use the newer Sphinx version $latest_avail_ver with:\n";
798 printf "\tdeactivate\n 800 printf "\tdeactivate\n" if ($ENV{'PWD'} =~ /${virtenv_prefix}/);
799 printf "\t. $activate_ 801 printf "\t. $activate_cmd\n";
800 deactivate_help(); 802 deactivate_help();
801 803
802 return; 804 return;
803 } 805 }
804 return if ($latest_avail_ver g 806 return if ($latest_avail_ver ge $rec_version);
805 } 807 }
806 808
807 if (!$virtualenv) { 809 if (!$virtualenv) {
808 # No sphinx either via package 810 # No sphinx either via package or via virtenv. As we can't
809 # Compare the versions here, j 811 # Compare the versions here, just return, recommending the
810 # user to install it from the 812 # user to install it from the package distro.
811 return if (!$latest_avail_ver) 813 return if (!$latest_avail_ver);
812 814
813 # User doesn't want a virtenv 815 # User doesn't want a virtenv recommendation, but he already
814 # installed one via virtenv wi 816 # installed one via virtenv with a newer version.
815 # So, print commands to enable 817 # So, print commands to enable it
816 if ($latest_avail_ver gt $cur_ 818 if ($latest_avail_ver gt $cur_version) {
817 printf "\nYou may also 819 printf "\nYou may also use the Sphinx virtualenv version $latest_avail_ver with:\n";
818 printf "\tdeactivate\n 820 printf "\tdeactivate\n" if ($ENV{'PWD'} =~ /${virtenv_prefix}/);
819 printf "\t. $activate_ 821 printf "\t. $activate_cmd\n";
820 deactivate_help(); 822 deactivate_help();
821 823
822 return; 824 return;
823 } 825 }
824 print "\n"; 826 print "\n";
825 } else { 827 } else {
826 $need++ if ($need_sphinx); 828 $need++ if ($need_sphinx);
827 } 829 }
828 830
829 # Suggest newer versions if current on 831 # Suggest newer versions if current ones are too old
830 if ($latest_avail_ver && $latest_avail 832 if ($latest_avail_ver && $latest_avail_ver ge $min_version) {
831 # If there's a good enough ver 833 # If there's a good enough version, ask the user to enable it
832 if ($latest_avail_ver ge $rec_ 834 if ($latest_avail_ver ge $rec_version) {
833 printf "\nNeed to acti 835 printf "\nNeed to activate Sphinx (version $latest_avail_ver) on virtualenv with:\n";
834 printf "\t. $activate_ 836 printf "\t. $activate_cmd\n";
835 deactivate_help(); 837 deactivate_help();
836 838
837 return; 839 return;
838 } 840 }
839 841
840 # Version is above the minimal 842 # Version is above the minimal required one, but may be
841 # below the recommended one. S 843 # below the recommended one. So, print warnings/notes
842 844
843 if ($latest_avail_ver lt $rec_ 845 if ($latest_avail_ver lt $rec_version) {
844 print "Warning: It is 846 print "Warning: It is recommended at least Sphinx version $rec_version.\n";
845 } 847 }
846 } 848 }
847 849
848 # At this point, either it needs Sphin 850 # At this point, either it needs Sphinx or upgrade is recommended,
849 # both via pip 851 # both via pip
850 852
851 if ($rec_sphinx_upgrade) { 853 if ($rec_sphinx_upgrade) {
852 if (!$virtualenv) { 854 if (!$virtualenv) {
853 print "Instead of inst 855 print "Instead of install/upgrade Python Sphinx pkg, you could use pip/pypi with:\n\n";
854 } else { 856 } else {
855 print "To upgrade Sphi 857 print "To upgrade Sphinx, use:\n\n";
856 } 858 }
857 } else { 859 } else {
858 print "\nSphinx needs to be in 860 print "\nSphinx needs to be installed either:\n1) via pip/pypi with:\n\n";
859 } 861 }
860 862
861 $python_cmd = find_python_no_venv(); 863 $python_cmd = find_python_no_venv();
862 864
863 printf "\t$virtualenv_cmd $virtenv_dir 865 printf "\t$virtualenv_cmd $virtenv_dir\n";
864 866
865 printf "\t. $virtenv_dir/bin/activate\ 867 printf "\t. $virtenv_dir/bin/activate\n";
866 printf "\tpip install -r $requirement_ 868 printf "\tpip install -r $requirement_file\n";
867 deactivate_help(); 869 deactivate_help();
868 870
869 printf "\n2) As a package with:\n"; 871 printf "\n2) As a package with:\n";
870 872
871 my $old_need = $need; 873 my $old_need = $need;
872 my $old_optional = $optional; 874 my $old_optional = $optional;
873 %missing = (); 875 %missing = ();
874 $pdf = 0; 876 $pdf = 0;
875 $optional = 0; 877 $optional = 0;
876 $install = ""; 878 $install = "";
877 $verbose_warn_install = 0; 879 $verbose_warn_install = 0;
878 880
879 add_package("python-sphinx", 0); 881 add_package("python-sphinx", 0);
880 882
881 check_distros(); 883 check_distros();
882 884
883 $need = $old_need; 885 $need = $old_need;
884 $optional = $old_optional; 886 $optional = $old_optional;
885 887
886 printf "\n Please note that Sphinx 888 printf "\n Please note that Sphinx >= 3.0 will currently produce false-positive\n";
887 printf " warning when the same name 889 printf " warning when the same name is used for more than one type (functions,\n";
888 printf " structs, enums,...). This i 890 printf " structs, enums,...). This is known Sphinx bug. For more details, see:\n";
889 printf "\thttps://github.com/sphinx-do 891 printf "\thttps://github.com/sphinx-doc/sphinx/pull/8313\n";
890 } 892 }
891 893
892 sub check_needs() 894 sub check_needs()
893 { 895 {
894 # Check if Sphinx is already accessibl 896 # Check if Sphinx is already accessible from current environment
895 check_sphinx(); 897 check_sphinx();
896 898
897 if ($system_release) { 899 if ($system_release) {
898 print "Detected OS: $system_re 900 print "Detected OS: $system_release.\n";
899 } else { 901 } else {
900 print "Unknown OS\n"; 902 print "Unknown OS\n";
901 } 903 }
902 printf "Sphinx version: %s\n\n", $cur_ 904 printf "Sphinx version: %s\n\n", $cur_version if ($cur_version);
903 905
904 # Check python command line, trying fi 906 # Check python command line, trying first python3
905 $python_cmd = findprog("python3"); 907 $python_cmd = findprog("python3");
906 $python_cmd = check_program("python", 908 $python_cmd = check_program("python", 0) if (!$python_cmd);
907 909
908 # Check the type of virtual env, depen 910 # Check the type of virtual env, depending on Python version
909 if ($python_cmd) { 911 if ($python_cmd) {
910 if ($virtualenv) { 912 if ($virtualenv) {
911 my $tmp = qx($python_c 913 my $tmp = qx($python_cmd --version 2>&1);
912 if ($tmp =~ m/(\d+\.)( 914 if ($tmp =~ m/(\d+\.)(\d+\.)/) {
913 if ($1 < 3) { 915 if ($1 < 3) {
914 # Fail 916 # Fail if it finds python2 (or worse)
915 die "P 917 die "Python 3 is required to build the kernel docs\n";
916 } 918 }
917 if ($1 == 3 && 919 if ($1 == 3 && $2 < 3) {
918 # Need 920 # Need Python 3.3 or upper for venv
919 $need_ 921 $need_virtualenv = 1;
920 } 922 }
921 } else { 923 } else {
922 die "Warning: 924 die "Warning: couldn't identify $python_cmd version!";
923 } 925 }
924 } else { 926 } else {
925 add_package("python-sp 927 add_package("python-sphinx", 0);
926 } 928 }
927 } 929 }
928 930
929 my $venv_ver = recommend_sphinx_upgrad 931 my $venv_ver = recommend_sphinx_upgrade();
930 932
931 my $virtualenv_cmd; 933 my $virtualenv_cmd;
932 934
933 if ($need_pip) { 935 if ($need_pip) {
934 # Set virtualenv command line, 936 # Set virtualenv command line, if python < 3.3
935 if ($need_virtualenv) { 937 if ($need_virtualenv) {
936 $virtualenv_cmd = find 938 $virtualenv_cmd = findprog("virtualenv-3");
937 $virtualenv_cmd = find 939 $virtualenv_cmd = findprog("virtualenv-3.5") if (!$virtualenv_cmd);
938 if (!$virtualenv_cmd) 940 if (!$virtualenv_cmd) {
939 check_program( 941 check_program("virtualenv", 0);
940 $virtualenv_cm 942 $virtualenv_cmd = "virtualenv";
941 } 943 }
942 } else { 944 } else {
943 $virtualenv_cmd = "$py 945 $virtualenv_cmd = "$python_cmd -m venv";
944 check_python_module("e 946 check_python_module("ensurepip", 0);
945 } 947 }
946 } 948 }
947 949
948 # Check for needed programs/tools 950 # Check for needed programs/tools
949 check_perl_module("Pod::Usage", 0); 951 check_perl_module("Pod::Usage", 0);
950 check_python_module("yaml", 0); 952 check_python_module("yaml", 0);
951 check_program("make", 0); 953 check_program("make", 0);
952 check_program("gcc", 0); 954 check_program("gcc", 0);
953 check_program("dot", 1); 955 check_program("dot", 1);
954 check_program("convert", 1); 956 check_program("convert", 1);
955 957
956 # Extra PDF files - should use 2 for i 958 # Extra PDF files - should use 2 for is_optional
957 check_program("xelatex", 2) if ($pdf); 959 check_program("xelatex", 2) if ($pdf);
958 check_program("rsvg-convert", 2) if ($ 960 check_program("rsvg-convert", 2) if ($pdf);
959 check_program("latexmk", 2) if ($pdf); 961 check_program("latexmk", 2) if ($pdf);
960 962
961 # Do distro-specific checks and output 963 # Do distro-specific checks and output distro-install commands
962 check_distros(); 964 check_distros();
963 965
964 if (!$python_cmd) { 966 if (!$python_cmd) {
965 if ($need == 1) { 967 if ($need == 1) {
966 die "Can't build as $n 968 die "Can't build as $need mandatory dependency is missing";
967 } elsif ($need) { 969 } elsif ($need) {
968 die "Can't build as $n 970 die "Can't build as $need mandatory dependencies are missing";
969 } 971 }
970 } 972 }
971 973
972 # Check if sphinx-build is called sphi 974 # Check if sphinx-build is called sphinx-build-3
973 if ($need_symlink) { 975 if ($need_symlink) {
974 printf "\tsudo ln -sf %s /usr/ 976 printf "\tsudo ln -sf %s /usr/bin/sphinx-build\n\n",
975 which("sphinx-build-3") 977 which("sphinx-build-3");
976 } 978 }
977 979
978 recommend_sphinx_version($virtualenv_c 980 recommend_sphinx_version($virtualenv_cmd);
979 printf "\n"; 981 printf "\n";
980 982
981 print "All optional dependencies are m 983 print "All optional dependencies are met.\n" if (!$optional);
982 984
983 if ($need == 1) { 985 if ($need == 1) {
984 die "Can't build as $need mand 986 die "Can't build as $need mandatory dependency is missing";
985 } elsif ($need) { 987 } elsif ($need) {
986 die "Can't build as $need mand 988 die "Can't build as $need mandatory dependencies are missing";
987 } 989 }
988 990
989 print "Needed package dependencies are 991 print "Needed package dependencies are met.\n";
990 } 992 }
991 993
992 # 994 #
993 # Main 995 # Main
994 # 996 #
995 997
996 while (@ARGV) { 998 while (@ARGV) {
997 my $arg = shift(@ARGV); 999 my $arg = shift(@ARGV);
998 1000
999 if ($arg eq "--no-virtualenv") { 1001 if ($arg eq "--no-virtualenv") {
1000 $virtualenv = 0; 1002 $virtualenv = 0;
1001 } elsif ($arg eq "--no-pdf"){ 1003 } elsif ($arg eq "--no-pdf"){
1002 $pdf = 0; 1004 $pdf = 0;
1003 } elsif ($arg eq "--version-check"){ 1005 } elsif ($arg eq "--version-check"){
1004 $version_check = 1; 1006 $version_check = 1;
1005 } else { 1007 } else {
1006 print "Usage:\n\t$0 <--no-vir 1008 print "Usage:\n\t$0 <--no-virtualenv> <--no-pdf> <--version-check>\n\n";
1007 print "Where:\n"; 1009 print "Where:\n";
1008 print "\t--no-virtualenv\t- R 1010 print "\t--no-virtualenv\t- Recommend installing Sphinx instead of using a virtualenv\n";
1009 print "\t--version-check\t- i 1011 print "\t--version-check\t- if version is compatible, don't check for missing dependencies\n";
1010 print "\t--no-pdf\t- don't ch 1012 print "\t--no-pdf\t- don't check for dependencies required to build PDF docs\n\n";
1011 exit -1; 1013 exit -1;
1012 } 1014 }
1013 } 1015 }
1014 1016
1015 # 1017 #
1016 # Determine the system type. There's no stand 1018 # Determine the system type. There's no standard unique way that would
1017 # work with all distros with a minimal packag 1019 # work with all distros with a minimal package install. So, several
1018 # methods are used here. 1020 # methods are used here.
1019 # 1021 #
1020 # By default, it will use lsb_release functio 1022 # By default, it will use lsb_release function. If not available, it will
1021 # fail back to reading the known different pl 1023 # fail back to reading the known different places where the distro name
1022 # is stored 1024 # is stored
1023 # 1025 #
1024 1026
1025 $system_release = qx(lsb_release -d) if which 1027 $system_release = qx(lsb_release -d) if which("lsb_release");
1026 $system_release =~ s/Description:\s*// if ($s 1028 $system_release =~ s/Description:\s*// if ($system_release);
1027 $system_release = catcheck("/etc/system-relea 1029 $system_release = catcheck("/etc/system-release") if !$system_release;
1028 $system_release = catcheck("/etc/redhat-relea 1030 $system_release = catcheck("/etc/redhat-release") if !$system_release;
1029 $system_release = catcheck("/etc/lsb-release" 1031 $system_release = catcheck("/etc/lsb-release") if !$system_release;
1030 $system_release = catcheck("/etc/gentoo-relea 1032 $system_release = catcheck("/etc/gentoo-release") if !$system_release;
1031 1033
1032 # This seems more common than LSB these days 1034 # This seems more common than LSB these days
1033 if (!$system_release) { 1035 if (!$system_release) {
1034 my %os_var; 1036 my %os_var;
1035 if (open IN, "cat /etc/os-release|") 1037 if (open IN, "cat /etc/os-release|") {
1036 while (<IN>) { 1038 while (<IN>) {
1037 if (m/^([\w\d\_]+)=\" 1039 if (m/^([\w\d\_]+)=\"?([^\"]*)\"?\n/) {
1038 $os_var{$1}=$ 1040 $os_var{$1}=$2;
1039 } 1041 }
1040 } 1042 }
1041 $system_release = $os_var{"NA 1043 $system_release = $os_var{"NAME"};
1042 if (defined($os_var{"VERSION_ 1044 if (defined($os_var{"VERSION_ID"})) {
1043 $system_release .= " 1045 $system_release .= " " . $os_var{"VERSION_ID"} if (defined($os_var{"VERSION_ID"}));
1044 } else { 1046 } else {
1045 $system_release .= " 1047 $system_release .= " " . $os_var{"VERSION"};
1046 } 1048 }
1047 } 1049 }
1048 } 1050 }
1049 $system_release = catcheck("/etc/issue") if ! 1051 $system_release = catcheck("/etc/issue") if !$system_release;
1050 $system_release =~ s/\s+$//; 1052 $system_release =~ s/\s+$//;
1051 1053
1052 check_needs; 1054 check_needs;
Linux® is a registered trademark of Linus Torvalds in the United States and other countries.
TOMOYO® is a registered trademark of NTT DATA CORPORATION.